2016-01-12 19:50:48 +01:00
|
|
|
<?php
|
|
|
|
|
2016-05-18 21:48:24 +02:00
|
|
|
require_once 'application/config/ConfigManager.php';
|
2016-01-12 19:50:48 +01:00
|
|
|
require_once 'tests/Updater/DummyUpdater.php';
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Class UpdaterTest.
|
|
|
|
* Runs unit tests against the Updater class.
|
|
|
|
*/
|
|
|
|
class UpdaterTest extends PHPUnit_Framework_TestCase
|
|
|
|
{
|
2016-01-20 23:34:33 +01:00
|
|
|
/**
|
|
|
|
* @var string Path to test datastore.
|
|
|
|
*/
|
|
|
|
protected static $testDatastore = 'sandbox/datastore.php';
|
|
|
|
|
2016-05-18 21:48:24 +02:00
|
|
|
/**
|
2016-05-29 12:32:14 +02:00
|
|
|
* @var string Config file path (without extension).
|
2016-05-18 21:48:24 +02:00
|
|
|
*/
|
2016-05-29 16:10:32 +02:00
|
|
|
protected static $configFile = 'tests/utils/config/configJson';
|
2016-05-18 21:48:24 +02:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @var ConfigManager
|
|
|
|
*/
|
|
|
|
protected $conf;
|
|
|
|
|
2016-01-12 19:50:48 +01:00
|
|
|
/**
|
|
|
|
* Executed before each test.
|
|
|
|
*/
|
|
|
|
public function setUp()
|
|
|
|
{
|
2016-06-09 20:04:02 +02:00
|
|
|
$this->conf = new ConfigManager(self::$configFile);
|
2016-01-12 19:50:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test read_updates_file with an empty/missing file.
|
|
|
|
*/
|
|
|
|
public function testReadEmptyUpdatesFile()
|
|
|
|
{
|
|
|
|
$this->assertEquals(array(), read_updates_file(''));
|
2016-06-11 09:08:02 +02:00
|
|
|
$updatesFile = $this->conf->get('resource.data_dir') . '/updates.txt';
|
2016-01-12 19:50:48 +01:00
|
|
|
touch($updatesFile);
|
|
|
|
$this->assertEquals(array(), read_updates_file($updatesFile));
|
2016-05-29 16:10:32 +02:00
|
|
|
unlink($updatesFile);
|
2016-01-12 19:50:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test read/write updates file.
|
|
|
|
*/
|
|
|
|
public function testReadWriteUpdatesFile()
|
|
|
|
{
|
2016-06-11 09:08:02 +02:00
|
|
|
$updatesFile = $this->conf->get('resource.data_dir') . '/updates.txt';
|
2016-01-12 19:50:48 +01:00
|
|
|
$updatesMethods = array('m1', 'm2', 'm3');
|
|
|
|
|
|
|
|
write_updates_file($updatesFile, $updatesMethods);
|
|
|
|
$readMethods = read_updates_file($updatesFile);
|
|
|
|
$this->assertEquals($readMethods, $updatesMethods);
|
|
|
|
|
|
|
|
// Update
|
|
|
|
$updatesMethods[] = 'm4';
|
|
|
|
write_updates_file($updatesFile, $updatesMethods);
|
|
|
|
$readMethods = read_updates_file($updatesFile);
|
|
|
|
$this->assertEquals($readMethods, $updatesMethods);
|
2016-05-29 16:10:32 +02:00
|
|
|
unlink($updatesFile);
|
2016-01-12 19:50:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test errors in write_updates_file(): empty updates file.
|
|
|
|
*
|
|
|
|
* @expectedException Exception
|
|
|
|
* @expectedExceptionMessageRegExp /Updates file path is not set(.*)/
|
|
|
|
*/
|
|
|
|
public function testWriteEmptyUpdatesFile()
|
|
|
|
{
|
|
|
|
write_updates_file('', array('test'));
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test errors in write_updates_file(): not writable updates file.
|
|
|
|
*
|
|
|
|
* @expectedException Exception
|
|
|
|
* @expectedExceptionMessageRegExp /Unable to write(.*)/
|
|
|
|
*/
|
|
|
|
public function testWriteUpdatesFileNotWritable()
|
|
|
|
{
|
2016-06-11 09:08:02 +02:00
|
|
|
$updatesFile = $this->conf->get('resource.data_dir') . '/updates.txt';
|
2016-01-12 19:50:48 +01:00
|
|
|
touch($updatesFile);
|
|
|
|
chmod($updatesFile, 0444);
|
2016-05-29 16:10:32 +02:00
|
|
|
try {
|
|
|
|
@write_updates_file($updatesFile, array('test'));
|
|
|
|
} catch (Exception $e) {
|
|
|
|
unlink($updatesFile);
|
|
|
|
throw $e;
|
|
|
|
}
|
2016-01-12 19:50:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test the update() method, with no update to run.
|
|
|
|
* 1. Everything already run.
|
|
|
|
* 2. User is logged out.
|
|
|
|
*/
|
|
|
|
public function testNoUpdates()
|
|
|
|
{
|
|
|
|
$updates = array(
|
|
|
|
'updateMethodDummy1',
|
|
|
|
'updateMethodDummy2',
|
|
|
|
'updateMethodDummy3',
|
|
|
|
'updateMethodException',
|
|
|
|
);
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new DummyUpdater($updates, array(), $this->conf, true);
|
2016-01-12 19:50:48 +01:00
|
|
|
$this->assertEquals(array(), $updater->update());
|
|
|
|
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new DummyUpdater(array(), array(), $this->conf, false);
|
2016-01-12 19:50:48 +01:00
|
|
|
$this->assertEquals(array(), $updater->update());
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test the update() method, with all updates to run (except the failing one).
|
|
|
|
*/
|
|
|
|
public function testUpdatesFirstTime()
|
|
|
|
{
|
|
|
|
$updates = array('updateMethodException',);
|
|
|
|
$expectedUpdates = array(
|
|
|
|
'updateMethodDummy1',
|
|
|
|
'updateMethodDummy2',
|
|
|
|
'updateMethodDummy3',
|
|
|
|
);
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new DummyUpdater($updates, array(), $this->conf, true);
|
2016-01-12 19:50:48 +01:00
|
|
|
$this->assertEquals($expectedUpdates, $updater->update());
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test the update() method, only one update to run.
|
|
|
|
*/
|
|
|
|
public function testOneUpdate()
|
|
|
|
{
|
|
|
|
$updates = array(
|
|
|
|
'updateMethodDummy1',
|
|
|
|
'updateMethodDummy3',
|
|
|
|
'updateMethodException',
|
|
|
|
);
|
|
|
|
$expectedUpdate = array('updateMethodDummy2');
|
|
|
|
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new DummyUpdater($updates, array(), $this->conf, true);
|
2016-01-12 19:50:48 +01:00
|
|
|
$this->assertEquals($expectedUpdate, $updater->update());
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test Update failed.
|
|
|
|
*
|
|
|
|
* @expectedException UpdaterException
|
|
|
|
*/
|
|
|
|
public function testUpdateFailed()
|
|
|
|
{
|
|
|
|
$updates = array(
|
|
|
|
'updateMethodDummy1',
|
|
|
|
'updateMethodDummy2',
|
|
|
|
'updateMethodDummy3',
|
|
|
|
);
|
|
|
|
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new DummyUpdater($updates, array(), $this->conf, true);
|
2016-01-12 19:50:48 +01:00
|
|
|
$updater->update();
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test update mergeDeprecatedConfig:
|
|
|
|
* 1. init a config file.
|
|
|
|
* 2. init a options.php file with update value.
|
|
|
|
* 3. merge.
|
|
|
|
* 4. check updated value in config file.
|
|
|
|
*/
|
|
|
|
public function testUpdateMergeDeprecatedConfig()
|
|
|
|
{
|
2016-06-09 20:04:02 +02:00
|
|
|
$this->conf->setConfigFile('tests/utils/config/configPhp');
|
|
|
|
$this->conf->reset();
|
2016-05-18 21:48:24 +02:00
|
|
|
|
|
|
|
$optionsFile = 'tests/Updater/options.php';
|
2016-05-29 16:10:32 +02:00
|
|
|
$options = '<?php
|
|
|
|
$GLOBALS[\'privateLinkByDefault\'] = true;';
|
|
|
|
file_put_contents($optionsFile, $options);
|
2016-01-12 19:50:48 +01:00
|
|
|
|
2016-05-29 16:10:32 +02:00
|
|
|
// tmp config file.
|
2016-06-09 20:04:02 +02:00
|
|
|
$this->conf->setConfigFile('tests/Updater/config');
|
2016-01-12 19:50:48 +01:00
|
|
|
|
|
|
|
// merge configs
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new Updater(array(), array(), $this->conf, true);
|
2016-05-29 12:32:14 +02:00
|
|
|
// This writes a new config file in tests/Updater/config.php
|
2016-01-12 19:50:48 +01:00
|
|
|
$updater->updateMethodMergeDeprecatedConfigFile();
|
|
|
|
|
|
|
|
// make sure updated field is changed
|
2016-05-18 21:48:24 +02:00
|
|
|
$this->conf->reload();
|
2016-06-11 09:08:02 +02:00
|
|
|
$this->assertTrue($this->conf->get('privacy.default_private_links'));
|
2016-05-18 21:48:24 +02:00
|
|
|
$this->assertFalse(is_file($optionsFile));
|
2016-05-29 12:32:14 +02:00
|
|
|
// Delete the generated file.
|
2016-06-09 20:04:02 +02:00
|
|
|
unlink($this->conf->getConfigFileExt());
|
2016-01-12 19:50:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test mergeDeprecatedConfig in without options file.
|
|
|
|
*/
|
|
|
|
public function testMergeDeprecatedConfigNoFile()
|
|
|
|
{
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new Updater(array(), array(), $this->conf, true);
|
2016-01-12 19:50:48 +01:00
|
|
|
$updater->updateMethodMergeDeprecatedConfigFile();
|
|
|
|
|
2016-05-29 16:10:32 +02:00
|
|
|
$this->assertEquals('root', $this->conf->get('credentials.login'));
|
2016-01-12 19:50:48 +01:00
|
|
|
}
|
2016-01-20 23:34:33 +01:00
|
|
|
|
2016-05-18 21:48:24 +02:00
|
|
|
/**
|
|
|
|
* Test renameDashTags update method.
|
|
|
|
*/
|
2016-01-20 23:34:33 +01:00
|
|
|
public function testRenameDashTags()
|
|
|
|
{
|
|
|
|
$refDB = new ReferenceLinkDB();
|
|
|
|
$refDB->write(self::$testDatastore);
|
|
|
|
$linkDB = new LinkDB(self::$testDatastore, true, false);
|
2016-03-21 21:40:49 +01:00
|
|
|
$this->assertEmpty($linkDB->filterSearch(array('searchtags' => 'exclude')));
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new Updater(array(), $linkDB, $this->conf, true);
|
2016-01-20 23:34:33 +01:00
|
|
|
$updater->updateMethodRenameDashTags();
|
2016-03-21 21:40:49 +01:00
|
|
|
$this->assertNotEmpty($linkDB->filterSearch(array('searchtags' => 'exclude')));
|
2016-01-20 23:34:33 +01:00
|
|
|
}
|
2016-05-29 12:32:14 +02:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Convert old PHP config file to JSON config.
|
|
|
|
*/
|
|
|
|
public function testConfigToJson()
|
|
|
|
{
|
|
|
|
$configFile = 'tests/utils/config/configPhp';
|
2016-06-09 20:04:02 +02:00
|
|
|
$this->conf->setConfigFile($configFile);
|
|
|
|
$this->conf->reset();
|
2016-05-29 12:32:14 +02:00
|
|
|
|
|
|
|
// The ConfigIO is initialized with ConfigPhp.
|
2016-06-09 20:04:02 +02:00
|
|
|
$this->assertTrue($this->conf->getConfigIO() instanceof ConfigPhp);
|
2016-05-29 12:32:14 +02:00
|
|
|
|
2016-06-09 20:04:02 +02:00
|
|
|
$updater = new Updater(array(), array(), $this->conf, false);
|
2016-05-29 12:32:14 +02:00
|
|
|
$done = $updater->updateMethodConfigToJson();
|
|
|
|
$this->assertTrue($done);
|
|
|
|
|
|
|
|
// The ConfigIO has been updated to ConfigJson.
|
2016-06-09 20:04:02 +02:00
|
|
|
$this->assertTrue($this->conf->getConfigIO() instanceof ConfigJson);
|
|
|
|
$this->assertTrue(file_exists($this->conf->getConfigFileExt()));
|
2016-05-29 12:32:14 +02:00
|
|
|
|
|
|
|
// Check JSON config data.
|
2016-06-09 20:04:02 +02:00
|
|
|
$this->conf->reload();
|
|
|
|
$this->assertEquals('root', $this->conf->get('credentials.login'));
|
2016-06-11 09:08:02 +02:00
|
|
|
$this->assertEquals('lala', $this->conf->get('redirector.url'));
|
|
|
|
$this->assertEquals('data/datastore.php', $this->conf->get('resource.datastore'));
|
2016-06-09 20:04:02 +02:00
|
|
|
$this->assertEquals('1', $this->conf->get('plugins.WALLABAG_VERSION'));
|
2016-05-29 12:32:14 +02:00
|
|
|
|
|
|
|
rename($configFile . '.save.php', $configFile . '.php');
|
2016-06-09 20:04:02 +02:00
|
|
|
unlink($this->conf->getConfigFileExt());
|
2016-05-29 12:32:14 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Launch config conversion update with an existing JSON file => nothing to do.
|
|
|
|
*/
|
|
|
|
public function testConfigToJsonNothingToDo()
|
|
|
|
{
|
2016-06-09 20:04:02 +02:00
|
|
|
$filetime = filemtime($this->conf->getConfigFileExt());
|
|
|
|
$updater = new Updater(array(), array(), $this->conf, false);
|
2016-05-29 12:32:14 +02:00
|
|
|
$done = $updater->updateMethodConfigToJson();
|
|
|
|
$this->assertTrue($done);
|
2016-06-09 20:04:02 +02:00
|
|
|
$expected = filemtime($this->conf->getConfigFileExt());
|
2016-05-29 12:32:14 +02:00
|
|
|
$this->assertEquals($expected, $filetime);
|
|
|
|
}
|
2016-08-02 12:54:55 +02:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Test escapeUnescapedConfig with valid data.
|
|
|
|
*/
|
|
|
|
public function testEscapeConfig()
|
|
|
|
{
|
|
|
|
$sandbox = 'sandbox/config';
|
|
|
|
copy(self::$configFile .'.json.php', $sandbox .'.json.php');
|
|
|
|
$this->conf = new ConfigManager($sandbox);
|
|
|
|
$title = '<script>alert("title");</script>';
|
|
|
|
$headerLink = '<script>alert("header_link");</script>';
|
|
|
|
$redirectorUrl = '<script>alert("redirector");</script>';
|
|
|
|
$this->conf->set('general.title', $title);
|
|
|
|
$this->conf->set('general.header_link', $headerLink);
|
|
|
|
$this->conf->set('redirector.url', $redirectorUrl);
|
|
|
|
$updater = new Updater(array(), array(), $this->conf, true);
|
|
|
|
$done = $updater->updateMethodEscapeUnescapedConfig();
|
|
|
|
$this->assertTrue($done);
|
|
|
|
$this->conf->reload();
|
|
|
|
$this->assertEquals(escape($title), $this->conf->get('general.title'));
|
|
|
|
$this->assertEquals(escape($headerLink), $this->conf->get('general.header_link'));
|
|
|
|
$this->assertEquals(escape($redirectorUrl), $this->conf->get('redirector.url'));
|
|
|
|
unlink($sandbox .'.json.php');
|
|
|
|
}
|
2016-01-12 19:50:48 +01:00
|
|
|
}
|