Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

LinkDB: prefix private members with an underscore

Browse source 
Relates to , 

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
This commit is contained in:
VirtualTam 2015-07-09 21:07:37 +02:00
parent e92f1ba59e
commit 07b6fa750b
3 changed files with 74 additions and 74 deletions

4
tests/LinkDBTest.php
View file

@ -103,7 +103,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase
unlink(self::$testDatastore);
$this->assertFileNotExists(self::$testDatastore);
$checkDB = self::getMethod('checkDB');
$checkDB = self::getMethod('_checkDB');
$checkDB->invokeArgs($linkDB, array());
$this->assertFileExists(self::$testDatastore);
@ -120,7 +120,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase
$datastoreSize = filesize(self::$testDatastore);
$this->assertGreaterThan(0, $datastoreSize);
$checkDB = self::getMethod('checkDB');
$checkDB = self::getMethod('_checkDB');
$checkDB->invokeArgs($linkDB, array());
// ensure the datastore is left unmodified

20
tests/utils/ReferenceLinkDB.php
View file

@ -4,9 +4,9 @@
*/
class ReferenceLinkDB
{
private $links = array();
private $publicCount = 0;
private $privateCount = 0;
private $_links = array();
private $_publicCount = 0;
private $_privateCount = 0;
/**
* Populates the test DB with reference data
@ -81,13 +81,13 @@ class ReferenceLinkDB
'linkdate' => $date,
'tags' => $tags,
);
$this->links[$date] = $link;
$this->_links[$date] = $link;
if ($private) {
$this->privateCount++;
$this->_privateCount++;
return;
}
$this->publicCount++;
$this->_publicCount++;
}
/**
@ -97,7 +97,7 @@ class ReferenceLinkDB
{
file_put_contents(
$filename,
'<?php /* '.base64_encode(gzdeflate(serialize($this->links))).' */ ?>'
'<?php /* '.base64_encode(gzdeflate(serialize($this->_links))).' */ ?>'
);
}
@ -106,7 +106,7 @@ class ReferenceLinkDB
*/
public function countLinks()
{
return $this->publicCount + $this->privateCount;
return $this->_publicCount + $this->_privateCount;
}
/**
@ -114,7 +114,7 @@ class ReferenceLinkDB
*/
public function countPublicLinks()
{
return $this->publicCount;
return $this->_publicCount;
}
/**
@ -122,7 +122,7 @@ class ReferenceLinkDB
*/
public function countPrivateLinks()
{
return $this->privateCount;
return $this->_privateCount;
}
}
?>