Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix: redirect to referrer after bookmark deletion

Browse source 
Except if the referer points to a permalink (which has been deleted).

Fixes #1622
This commit is contained in:
ArthurHoaro 2020-11-05 16:14:22 +01:00
parent 38b55fbf3d
commit 330ac859fb
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
application/front/controller/admin/ShaareManageController.php
View file

@ -66,8 +66,8 @@ public function deleteBookmark(Request $request, Response $response): Response
return $response->write('<script>self.close();</script>');
}
// Don't redirect to where we were previously because the datastore has changed.
return $this->redirect($response, '/');
// Don't redirect to permalink after deletion.
return $this->redirectFromReferer($request, $response, ['shaare/']);
}
/**

6
tests/front/controller/admin/ShaareManageControllerTest/DeleteBookmarkTest.php
View file

@ -38,6 +38,8 @@ public function testDeleteSingleBookmark(): void
{
$parameters = ['id' => '123'];
$this->container->environment['HTTP_REFERER'] = 'http://shaarli/subfolder/shaare/abcdef';
$request = $this->createMock(Request::class);
$request
->method('getParam')
@ -90,6 +92,8 @@ public function testDeleteMultipleBookmarks(): void
{
$parameters = ['id' => '123 456 789'];
$this->container->environment['HTTP_REFERER'] = 'http://shaarli/subfolder/?searchtags=abcdef';
$request = $this->createMock(Request::class);
$request
->method('getParam')
@ -152,7 +156,7 @@ public function testDeleteMultipleBookmarks(): void
$result = $this->controller->deleteBookmark($request, $response);
static::assertSame(302, $result->getStatusCode());
static::assertSame(['/subfolder/'], $result->getHeader('location'));
static::assertSame(['/subfolder/?searchtags=abcdef'], $result->getHeader('location'));
}
/**