Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #1602 from ArthurHoaro/fix/root-exceptions

Browse source 
Dislay an error if an exception occurs in the error handler
This commit is contained in:
ArthurHoaro 2020-10-20 21:37:20 +02:00 committed by GitHub
commit 3445443349
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
application/Utils.php
View file

@ -463,3 +463,12 @@ function t($text, $nText = '', $nb = 1, $domain = 'shaarli')
{ {
return dn__($domain, $text, $nText, $nb); return dn__($domain, $text, $nText, $nb);
} }
/**
* Converts an exception into a printable stack trace string.
*/
function exception2text(Throwable $e): string
{
return $e->getMessage() . PHP_EOL . $e->getFile() . $e->getLine() . PHP_EOL . $e->getTraceAsString();
}

5
application/front/controller/visitor/ErrorController.php
View file

@ -28,10 +28,7 @@ public function __invoke(Request $request, Response $response, \Throwable $throw
// Internal error (any other Throwable) // Internal error (any other Throwable)
if ($this->container->conf->get('dev.debug', false)) { if ($this->container->conf->get('dev.debug', false)) {
$this->assignView('message', $throwable->getMessage()); $this->assignView('message', $throwable->getMessage());
$this->assignView( $this->assignView('stacktrace', exception2text($throwable));
'stacktrace',
nl2br(get_class($throwable) .': '. PHP_EOL . $throwable->getTraceAsString())
);
} else { } else {
$this->assignView('message', t('An unexpected error occurred.')); $this->assignView('message', t('An unexpected error occurred.'));
} }

12
index.php
View file

@ -151,6 +151,12 @@
$this->get('/history', '\Shaarli\Api\Controllers\HistoryController:getHistory')->setName('getHistory'); $this->get('/history', '\Shaarli\Api\Controllers\HistoryController:getHistory')->setName('getHistory');
})->add('\Shaarli\Api\ApiMiddleware'); })->add('\Shaarli\Api\ApiMiddleware');
$response = $app->run(true); try {
$response = $app->run(true);
$app->respond($response); $app->respond($response);
} catch (Throwable $e) {
die(nl2br(
'An unexpected error happened, and the error template could not be displayed.' . PHP_EOL . PHP_EOL .
exception2text($e)
));
}