Merge pull request #1733 from ArthurHoaro/feature/phpcs-tests

composer.json

@@ -71,5 +71,11 @@
             "Shaarli\\Updater\\": "application/updater",
             "Shaarli\\Updater\\Exception\\": "application/updater/exception"
         }
+    },
+    "autoload-dev": {
+        "psr-4": {
+          "Shaarli\\Tests\\": "tests",
+          "Shaarli\\Tests\\Utils\\": "tests/utils"
+        }
     }
 }

doc/md/dev/Development.md

@@ -169,13 +169,11 @@ Patches should try to stick to the [PHP Standard Recommendations](http://www.php
 - [PSR-2](http://www.php-fig.org/psr/psr-2/) - Coding Style Guide
 - [PSR-12](http://www.php-fig.org/psr/psr-12/) - Extended Coding Style  Guide
 
-These are enforced on pull requests using our Continuous Integration tools.
+These are enforced on pull requests using our Continuous Integration tools with [PHP Code Sniffer](https://github.com/squizlabs/PHP_CodeSniffer).
 
-**Work in progress:** Static analysis is currently being discussed here: in [#95 - Fix coding style (static analysis)](https://github.com/shaarli/Shaarli/issues/95), [#130 - Continuous Integration tools & features](https://github.com/shaarli/Shaarli/issues/130)
+Static analysis tools are installed with Composer dependencies, and used through Shaarli's [Makefile](https://github.com/shaarli/Shaarli/blob/master/Makefile) with `make code_sniffer`.
-
-Static analysis tools can be installed with Composer, and used through Shaarli's [Makefile](https://github.com/shaarli/Shaarli/blob/master/Makefile).
 
 For an overview of the available features, see:
 
 - [Code quality: Makefile to run static code checkers](https://github.com/shaarli/Shaarli/pull/124) (#124)
-- [Run PHPCS against different coding standards](https://github.com/shaarli/Shaarli/pull/276) (#276)
+- [Apply PHP Code Sniffer to Shaarli code base](https://github.com/shaarli/Shaarli/pull/1635) (#1635)

phpcs.xml

@@ -5,7 +5,7 @@
   <file>index.php</file>
   <file>application</file>
   <file>plugins</file>
-<!--  <file>tests</file>-->
+  <file>tests</file>
 
   <exclude-pattern>*/*.css</exclude-pattern>
   <exclude-pattern>*/*.js</exclude-pattern>
@@ -19,5 +19,11 @@
     <!--  index.php bootstraps everything, so yes mixed symbols with side effects  -->
     <exclude-pattern>index.php</exclude-pattern>
     <exclude-pattern>plugins/*</exclude-pattern>
+    <exclude-pattern>tests/bootstrap.php</exclude-pattern>
+    <exclude-pattern>tests/utils/RainTPL.php</exclude-pattern>
+  </rule>
+
+  <rule ref="PSR1.Classes.ClassDeclaration.MissingNamespace">
+    <exclude-pattern>tests/utils/RainTPL.php</exclude-pattern>
   </rule>
 </ruleset>

tests/PluginManagerTest.php

@@ -39,7 +39,7 @@ public function setUp(): void
     public function testPlugin(): void
     {
         PluginManager::$PLUGINS_PATH = self::$pluginPath;
-        $this->pluginManager->load(array(self::$pluginName));
+        $this->pluginManager->load([self::$pluginName]);
 
         $this->assertTrue(function_exists('hook_test_random'));
 
@@ -50,19 +50,19 @@ public function testPlugin(): void
         static::assertSame('woot', $data[1]);
 
         $data = [0 => 'woot'];
-        $this->pluginManager->executeHooks('random', $data, array('target' => 'test'));
+        $this->pluginManager->executeHooks('random', $data, ['target' => 'test']);
 
         static::assertCount(2, $data);
         static::assertSame('page test', $data[1]);
 
         $data = [0 => 'woot'];
-        $this->pluginManager->executeHooks('random', $data, array('loggedin' => true));
+        $this->pluginManager->executeHooks('random', $data, ['loggedin' => true]);
 
         static::assertCount(2, $data);
         static::assertEquals('loggedin', $data[1]);
 
         $data = [0 => 'woot'];
-        $this->pluginManager->executeHooks('random', $data, array('loggedin' => null));
+        $this->pluginManager->executeHooks('random', $data, ['loggedin' => null]);
 
         static::assertCount(3, $data);
         static::assertEquals('loggedin', $data[1]);
@@ -76,7 +76,7 @@ public function testPlugin(): void
     public function testPluginWithPhpError(): void
     {
         PluginManager::$PLUGINS_PATH = self::$pluginPath;
-        $this->pluginManager->load(array(self::$pluginName));
+        $this->pluginManager->load([self::$pluginName]);
 
         $this->assertTrue(function_exists('hook_test_error'));
 

tests/ThumbnailerTest.php

@@ -15,9 +15,9 @@
  */
 class ThumbnailerTest extends TestCase
 {
-    const WIDTH = 190;
+    protected const WIDTH = 190;
 
-    const HEIGHT = 210;
+    protected const HEIGHT = 210;
 
     /**
      * @var Thumbnailer;
@@ -103,10 +103,10 @@ protected function rrmdirContent($dir)
             $objects = scandir($dir);
             foreach ($objects as $object) {
                 if ($object != "." && $object != "..") {
-                    if (is_dir($dir."/".$object)) {
+                    if (is_dir($dir . "/" . $object)) {
-                        $this->rrmdirContent($dir."/".$object);
+                        $this->rrmdirContent($dir . "/" . $object);
                     } else {
-                        unlink($dir."/".$object);
+                        unlink($dir . "/" . $object);
                     }
                 }
             }

tests/TimeZoneTest.php

@@ -1,14 +1,17 @@
 <?php
+
 /**
  * TimeZone's tests
  */
 
-require_once 'application/TimeZone.php';
+namespace Shaarli\Tests;
+
+use Shaarli\TestCase;
 
 /**
  * Unitary tests for timezone utilities
  */
-class TimeZoneTest extends \Shaarli\TestCase
+class TimeZoneTest extends TestCase
 {
     /**
      * @var array of timezones

tests/UtilsTest.php

@@ -1,16 +1,18 @@
 <?php
+
 /**
  * Utilities' tests
  */
 
-require_once 'application/Utils.php';
+namespace Shaarli\Tests;
-require_once 'application/Languages.php';
 
+use DateTime;
+use Shaarli\TestCase;
 
 /**
  * Unitary tests for Shaarli utilities
  */
-class UtilsTest extends \Shaarli\TestCase
+class UtilsTest extends TestCase
 {
     // Log file
     protected static $testLogFile = 'tests.log';
@@ -54,7 +56,7 @@ protected function setUp(): void
     /**
      * Returns a list of the elements from the last logged entry
      *
-     * @return list (date, ip address, message)
+     * @return array (date, ip address, message)
      */
     protected function getLastLogEntry()
     {
@@ -187,7 +189,7 @@ public function testGenerateLocation()
     public function testGenerateLocationLoop()
     {
         $ref = 'http://localhost/?test';
-        $this->assertEquals('./?', generateLocation($ref, 'localhost', array('test')));
+        $this->assertEquals('./?', generateLocation($ref, 'localhost', ['test']));
     }
 
     /**
@@ -313,15 +315,15 @@ public function testReturnBytes()
      */
     public function testHumanBytes()
     {
-        $this->assertEquals('2'. t('kiB'), human_bytes(2 * 1024));
+        $this->assertEquals('2' . t('kiB'), human_bytes(2 * 1024));
-        $this->assertEquals('2'. t('kiB'), human_bytes(strval(2 * 1024)));
+        $this->assertEquals('2' . t('kiB'), human_bytes(strval(2 * 1024)));
-        $this->assertEquals('2'. t('MiB'), human_bytes(2 * (pow(1024, 2))));
+        $this->assertEquals('2' . t('MiB'), human_bytes(2 * (pow(1024, 2))));
-        $this->assertEquals('2'. t('MiB'), human_bytes(strval(2 * (pow(1024, 2)))));
+        $this->assertEquals('2' . t('MiB'), human_bytes(strval(2 * (pow(1024, 2)))));
-        $this->assertEquals('2'. t('GiB'), human_bytes(2 * (pow(1024, 3))));
+        $this->assertEquals('2' . t('GiB'), human_bytes(2 * (pow(1024, 3))));
-        $this->assertEquals('2'. t('GiB'), human_bytes(strval(2 * (pow(1024, 3)))));
+        $this->assertEquals('2' . t('GiB'), human_bytes(strval(2 * (pow(1024, 3)))));
-        $this->assertEquals('374'. t('B'), human_bytes(374));
+        $this->assertEquals('374' . t('B'), human_bytes(374));
-        $this->assertEquals('374'. t('B'), human_bytes('374'));
+        $this->assertEquals('374' . t('B'), human_bytes('374'));
-        $this->assertEquals('232'. t('kiB'), human_bytes(237481));
+        $this->assertEquals('232' . t('kiB'), human_bytes(237481));
         $this->assertEquals(t('Unlimited'), human_bytes('0'));
         $this->assertEquals(t('Unlimited'), human_bytes(0));
         $this->assertEquals(t('Setting not set'), human_bytes(''));
@@ -332,9 +334,9 @@ public function testHumanBytes()
      */
     public function testGetMaxUploadSize()
     {
-        $this->assertEquals('1'. t('MiB'), get_max_upload_size(2097152, '1024k'));
+        $this->assertEquals('1' . t('MiB'), get_max_upload_size(2097152, '1024k'));
-        $this->assertEquals('1'. t('MiB'), get_max_upload_size('1m', '2m'));
+        $this->assertEquals('1' . t('MiB'), get_max_upload_size('1m', '2m'));
-        $this->assertEquals('100'. t('B'), get_max_upload_size(100, 100));
+        $this->assertEquals('100' . t('B'), get_max_upload_size(100, 100));
     }
 
     /**

tests/api/ApiMiddlewareTest.php

@@ -1,9 +1,11 @@
 <?php
+
 namespace Shaarli\Api;
 
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -32,7 +34,7 @@ class ApiMiddlewareTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -49,7 +51,7 @@ protected function setUp(): void
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('api.secret', 'NapoleonWasALizard');
 
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
 
         $history = new History('sandbox/history.php');
@@ -80,7 +82,7 @@ public function testInvokeMiddlewareWithValidToken(): void
         $env = Environment::mock([
             'REQUEST_METHOD' => 'GET',
             'REQUEST_URI' => '/echo',
-            'HTTP_AUTHORIZATION'=> 'Bearer ' . ApiUtilsTest::generateValidJwtToken('NapoleonWasALizard'),
+            'HTTP_AUTHORIZATION' => 'Bearer ' . ApiUtilsTest::generateValidJwtToken('NapoleonWasALizard'),
         ]);
         $request = Request::createFromEnvironment($env);
         $response = new Response();
@@ -196,7 +198,7 @@ public function testInvokeMiddlewareNoSecretSetDebug()
         $env = Environment::mock([
             'REQUEST_METHOD' => 'GET',
             'REQUEST_URI' => '/echo',
-            'HTTP_AUTHORIZATION'=> 'Bearer jwt',
+            'HTTP_AUTHORIZATION' => 'Bearer jwt',
         ]);
         $request = Request::createFromEnvironment($env);
         $response = new Response();
@@ -219,7 +221,7 @@ public function testInvalidJwtAuthHeaderDebug()
         $env = Environment::mock([
             'REQUEST_METHOD' => 'GET',
             'REQUEST_URI' => '/echo',
-            'HTTP_AUTHORIZATION'=> 'PolarBearer jwt',
+            'HTTP_AUTHORIZATION' => 'PolarBearer jwt',
         ]);
         $request = Request::createFromEnvironment($env);
         $response = new Response();
@@ -245,7 +247,7 @@ public function testInvokeMiddlewareInvalidJwtDebug()
         $env = Environment::mock([
             'REQUEST_METHOD' => 'GET',
             'REQUEST_URI' => '/echo',
-            'HTTP_AUTHORIZATION'=> 'Bearer jwt',
+            'HTTP_AUTHORIZATION' => 'Bearer jwt',
         ]);
         $request = Request::createFromEnvironment($env);
         $response = new Response();

tests/api/ApiUtilsTest.php

@@ -32,10 +32,10 @@ public static function generateValidJwtToken($secret)
             "alg": "HS512"
         }');
         $payload = Base64Url::encode('{
-            "iat": '. time() .'
+            "iat": ' . time() . '
         }');
-        $signature = Base64Url::encode(hash_hmac('sha512', $header .'.'. $payload, $secret, true));
+        $signature = Base64Url::encode(hash_hmac('sha512', $header . '.' . $payload, $secret, true));
-        return $header .'.'. $payload .'.'. $signature;
+        return $header . '.' . $payload . '.' . $signature;
     }
 
     /**

tests/api/controllers/history/HistoryTest.php

@@ -4,14 +4,14 @@
 
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
+use Shaarli\TestCase;
+use Shaarli\Tests\Utils\ReferenceHistory;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
 use Slim\Http\Response;
 
-require_once 'tests/utils/ReferenceHistory.php';
+class HistoryTest extends TestCase
-
-class HistoryTest extends \Shaarli\TestCase
 {
     /**
      * @var string datastore to test write operations
@@ -24,7 +24,7 @@ class HistoryTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceHistory instance.
+     * @var ReferenceHistory instance.
      */
     protected $refHistory = null;
 
@@ -44,7 +44,7 @@ class HistoryTest extends \Shaarli\TestCase
     protected function setUp(): void
     {
         $this->conf = new ConfigManager('tests/utils/config/configJson');
-        $this->refHistory = new \ReferenceHistory();
+        $this->refHistory = new ReferenceHistory();
         $this->refHistory->write(self::$testHistory);
         $this->container = new Container();
         $this->container['conf'] = $this->conf;

tests/api/controllers/info/InfoTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Api\Controllers;
 
 use malkusch\lock\mutex\NoMutex;
@@ -7,6 +8,7 @@
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -32,7 +34,7 @@ class InfoTest extends TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -54,7 +56,7 @@ protected function setUp(): void
         $mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
         $this->pluginManager = new PluginManager($this->conf);
         $history = new History('sandbox/history.php');
@@ -95,7 +97,7 @@ public function testGetInfo()
         $this->assertEquals(200, $response->getStatusCode());
         $data = json_decode((string) $response->getBody(), true);
 
-        $this->assertEquals(\ReferenceLinkDB::$NB_LINKS_TOTAL, $data['global_counter']);
+        $this->assertEquals(ReferenceLinkDB::$NB_LINKS_TOTAL, $data['global_counter']);
         $this->assertEquals(2, $data['private_counter']);
         $this->assertEquals('Shaarli', $data['settings']['title']);
         $this->assertEquals('?', $data['settings']['header_link']);
@@ -106,7 +108,7 @@ public function testGetInfo()
         $title = 'My bookmarks';
         $headerLink = 'http://shaarli.tld';
         $timezone = 'Europe/Paris';
-        $enabledPlugins = array('foo', 'bar');
+        $enabledPlugins = ['foo', 'bar'];
         $defaultPrivateLinks = true;
         $this->conf->set('general.title', $title);
         $this->conf->set('general.header_link', $headerLink);
@@ -118,7 +120,7 @@ public function testGetInfo()
         $this->assertEquals(200, $response->getStatusCode());
         $data = json_decode((string) $response->getBody(), true);
 
-        $this->assertEquals(\ReferenceLinkDB::$NB_LINKS_TOTAL, $data['global_counter']);
+        $this->assertEquals(ReferenceLinkDB::$NB_LINKS_TOTAL, $data['global_counter']);
         $this->assertEquals(2, $data['private_counter']);
         $this->assertEquals($title, $data['settings']['title']);
         $this->assertEquals($headerLink, $data['settings']['header_link']);

tests/api/controllers/links/DeleteLinkTest.php

@@ -1,6 +1,5 @@
 <?php
 
-
 namespace Shaarli\Api\Controllers;
 
 use malkusch\lock\mutex\NoMutex;
@@ -8,6 +7,8 @@
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceHistory;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -31,7 +32,7 @@ class DeleteLinkTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -69,9 +70,9 @@ protected function setUp(): void
         $this->mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
-        $refHistory = new \ReferenceHistory();
+        $refHistory = new ReferenceHistory();
         $refHistory->write(self::$testHistory);
         $this->history = new History(self::$testHistory);
         $this->pluginManager = new PluginManager($this->conf);

tests/api/controllers/links/GetLinkIdTest.php

@@ -8,6 +8,7 @@
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -35,7 +36,7 @@ class GetLinkIdTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -52,7 +53,7 @@ class GetLinkIdTest extends \Shaarli\TestCase
     /**
      * Number of JSON fields per link.
      */
-    const NB_FIELDS_LINK = 9;
+    protected const NB_FIELDS_LINK = 9;
 
     /**
      * Before each test, instantiate a new Api with its config, plugins and bookmarks.
@@ -62,7 +63,7 @@ protected function setUp(): void
         $mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
         $history = new History('sandbox/history.php');
 

tests/api/controllers/links/GetLinksTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Api\Controllers;
 
 use malkusch\lock\mutex\NoMutex;
@@ -8,6 +9,7 @@
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -35,7 +37,7 @@ class GetLinksTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -52,7 +54,7 @@ class GetLinksTest extends \Shaarli\TestCase
     /**
      * Number of JSON field per link.
      */
-    const NB_FIELDS_LINK = 9;
+    protected const NB_FIELDS_LINK = 9;
 
     /**
      * Before every test, instantiate a new Api with its config, plugins and bookmarks.
@@ -62,7 +64,7 @@ protected function setUp(): void
         $mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
         $history = new History('sandbox/history.php');
 
@@ -329,7 +331,7 @@ public function testGetLinksSearchTerm()
         // URL encoding
         $env = Environment::mock([
             'REQUEST_METHOD' => 'GET',
-            'QUERY_STRING' => 'searchterm='. urlencode('@web')
+            'QUERY_STRING' => 'searchterm=' . urlencode('@web')
         ]);
         $request = Request::createFromEnvironment($env);
         $response = $this->controller->getLinks($request, new Response());
@@ -430,7 +432,7 @@ public function testGetLinksSearchTags()
         $response = $this->controller->getLinks($request, new Response());
         $this->assertEquals(200, $response->getStatusCode());
         $data = json_decode((string) $response->getBody(), true);
-        $this->assertEquals(\ReferenceLinkDB::$NB_LINKS_TOTAL, count($data));
+        $this->assertEquals(ReferenceLinkDB::$NB_LINKS_TOTAL, count($data));
         $this->assertEquals(10, $data[0]['id']);
         $this->assertEquals(41, $data[2]['id']);
 

tests/api/controllers/links/PostLinkTest.php

@@ -9,6 +9,8 @@
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
+use Shaarli\Tests\Utils\ReferenceHistory;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -40,7 +42,7 @@ class PostLinkTest extends TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -67,7 +69,7 @@ class PostLinkTest extends TestCase
     /**
      * Number of JSON field per link.
      */
-    const NB_FIELDS_LINK = 9;
+    protected const NB_FIELDS_LINK = 9;
 
     /**
      * Before every test, instantiate a new Api with its config, plugins and bookmarks.
@@ -77,9 +79,9 @@ protected function setUp(): void
         $mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
-        $refHistory = new \ReferenceHistory();
+        $refHistory = new ReferenceHistory();
         $refHistory->write(self::$testHistory);
         $this->history = new History(self::$testHistory);
         $pluginManager = new PluginManager($this->conf);

tests/api/controllers/links/PutLinkTest.php

@@ -1,6 +1,5 @@
 <?php
 
-
 namespace Shaarli\Api\Controllers;
 
 use malkusch\lock\mutex\NoMutex;
@@ -9,6 +8,8 @@
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceHistory;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -32,7 +33,7 @@ class PutLinkTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -59,7 +60,7 @@ class PutLinkTest extends \Shaarli\TestCase
     /**
      * Number of JSON field per link.
      */
-    const NB_FIELDS_LINK = 9;
+    protected const NB_FIELDS_LINK = 9;
 
     /**
      * Before every test, instantiate a new Api with its config, plugins and bookmarks.
@@ -69,9 +70,9 @@ protected function setUp(): void
         $mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
-        $refHistory = new \ReferenceHistory();
+        $refHistory = new ReferenceHistory();
         $refHistory->write(self::$testHistory);
         $this->history = new History(self::$testHistory);
         $pluginManager = new PluginManager($this->conf);

tests/api/controllers/tags/DeleteTagTest.php

@@ -1,6 +1,5 @@
 <?php
 
-
 namespace Shaarli\Api\Controllers;
 
 use malkusch\lock\mutex\NoMutex;
@@ -9,6 +8,8 @@
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceHistory;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -32,7 +33,7 @@ class DeleteTagTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -70,9 +71,9 @@ protected function setUp(): void
         $this->mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
-        $refHistory = new \ReferenceHistory();
+        $refHistory = new ReferenceHistory();
         $refHistory->write(self::$testHistory);
         $this->history = new History(self::$testHistory);
         $this->pluginManager = new PluginManager($this->conf);

tests/api/controllers/tags/GetTagNameTest.php

@@ -8,6 +8,7 @@
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -33,7 +34,7 @@ class GetTagNameTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -53,7 +54,7 @@ class GetTagNameTest extends \Shaarli\TestCase
     /**
      * Number of JSON fields per link.
      */
-    const NB_FIELDS_TAG = 2;
+    protected const NB_FIELDS_TAG = 2;
 
     /**
      * Before each test, instantiate a new Api with its config, plugins and bookmarks.
@@ -63,7 +64,7 @@ protected function setUp(): void
         $mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
         $history = new History('sandbox/history.php');
 

tests/api/controllers/tags/GetTagsTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Api\Controllers;
 
 use malkusch\lock\mutex\NoMutex;
@@ -7,6 +8,7 @@
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -32,7 +34,7 @@ class GetTagsTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -57,7 +59,7 @@ class GetTagsTest extends \Shaarli\TestCase
     /**
      * Number of JSON field per link.
      */
-    const NB_FIELDS_TAG = 2;
+    protected const NB_FIELDS_TAG = 2;
 
     /**
      * Before every test, instantiate a new Api with its config, plugins and bookmarks.
@@ -67,7 +69,7 @@ protected function setUp(): void
         $mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
         $history = new History('sandbox/history.php');
         $this->pluginManager = new PluginManager($this->conf);

tests/api/controllers/tags/PutTagTest.php

@@ -9,6 +9,8 @@
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
+use Shaarli\Tests\Utils\ReferenceHistory;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Slim\Container;
 use Slim\Http\Environment;
 use Slim\Http\Request;
@@ -32,7 +34,7 @@ class PutTagTest extends \Shaarli\TestCase
     protected $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected $refDB = null;
 
@@ -62,7 +64,7 @@ class PutTagTest extends \Shaarli\TestCase
     /**
      * Number of JSON field per link.
      */
-    const NB_FIELDS_TAG = 2;
+    protected const NB_FIELDS_TAG = 2;
 
     /**
      * Before every test, instantiate a new Api with its config, plugins and bookmarks.
@@ -72,9 +74,9 @@ protected function setUp(): void
         $mutex = new NoMutex();
         $this->conf = new ConfigManager('tests/utils/config/configJson');
         $this->conf->set('resource.datastore', self::$testDatastore);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
-        $refHistory = new \ReferenceHistory();
+        $refHistory = new ReferenceHistory();
         $refHistory->write(self::$testHistory);
         $this->history = new History(self::$testHistory);
         $this->pluginManager = new PluginManager($this->conf);

tests/bookmark/BookmarkArrayTest.php

@@ -3,6 +3,7 @@
 namespace Shaarli\Bookmark;
 
 use Shaarli\TestCase;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 
 /**
  * Class BookmarkArrayTest
@@ -185,7 +186,7 @@ public function testArrayAccessIterate()
         $this->assertCount(3, $array);
 
         foreach ($array as $id => $bookmark) {
-            $this->assertEquals(${'bookmark'. $id}, $bookmark);
+            $this->assertEquals(${'bookmark' . $id}, $bookmark);
         }
     }
 
@@ -194,7 +195,7 @@ public function testArrayAccessIterate()
      */
     public function testReorder()
     {
-        $refDB = new \ReferenceLinkDB();
+        $refDB = new ReferenceLinkDB();
         $refDB->write('sandbox/datastore.php');
 
 

tests/bookmark/BookmarkFileServiceTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Link datastore tests
  */
@@ -7,7 +8,6 @@
 
 use DateTime;
 use malkusch\lock\mutex\NoMutex;
-use ReferenceLinkDB;
 use ReflectionClass;
 use Shaarli;
 use Shaarli\Bookmark\Exception\BookmarkNotFoundException;
@@ -16,6 +16,8 @@
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
+use Shaarli\Tests\Utils\FakeBookmarkService;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 
 /**
  * Unitary tests for LegacyLinkDBTest
@@ -82,19 +84,19 @@ protected function setUp(): void
             unlink(self::$testDatastore);
         }
 
-        if (file_exists(self::$testConf .'.json.php')) {
+        if (file_exists(self::$testConf . '.json.php')) {
-            unlink(self::$testConf .'.json.php');
+            unlink(self::$testConf . '.json.php');
         }
 
         if (file_exists(self::$testUpdates)) {
             unlink(self::$testUpdates);
         }
 
-        copy('tests/utils/config/configJson.json.php', self::$testConf .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$testConf . '.json.php');
         $this->conf = new ConfigManager(self::$testConf);
         $this->conf->set('resource.datastore', self::$testDatastore);
         $this->conf->set('resource.updates', self::$testUpdates);
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
         $this->history = new History('sandbox/history.php');
         $this->pluginManager = new PluginManager($this->conf);
@@ -123,12 +125,12 @@ public function testDatabaseMigration()
             define('SHAARLI_VERSION', 'dev');
         }
 
-        $this->refDB = new \ReferenceLinkDB(true);
+        $this->refDB = new ReferenceLinkDB(true);
         $this->refDB->write(self::$testDatastore);
         $db = self::getMethod('migrate');
         $db->invokeArgs($this->privateLinkDB, []);
 
-        $db = new \FakeBookmarkService(
+        $db = new FakeBookmarkService(
             $this->conf,
             $this->pluginManager,
             $this->history,
@@ -203,7 +205,7 @@ public function testAddFull()
         $this->assertEquals($updated, $bookmark->getUpdated());
 
         // reload from file
-        $this->privateLinkDB = new \FakeBookmarkService(
+        $this->privateLinkDB = new FakeBookmarkService(
             $this->conf,
             $this->pluginManager,
             $this->history,
@@ -714,7 +716,7 @@ public function testCheckDBNewLoggedOut()
     {
         unlink(self::$testDatastore);
         $this->assertFileNotExists(self::$testDatastore);
-        $db = new \FakeBookmarkService($this->conf, $this->pluginManager, $this->history, $this->mutex, false);
+        $db = new FakeBookmarkService($this->conf, $this->pluginManager, $this->history, $this->mutex, false);
         $this->assertFileNotExists(self::$testDatastore);
         $this->assertInstanceOf(BookmarkArray::class, $db->getBookmarks());
         $this->assertCount(0, $db->getBookmarks());

tests/bookmark/BookmarkFilterTest.php

@@ -3,11 +3,12 @@
 namespace Shaarli\Bookmark;
 
 use malkusch\lock\mutex\NoMutex;
-use ReferenceLinkDB;
 use Shaarli\Config\ConfigManager;
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
+use Shaarli\Tests\Utils\FakeBookmarkService;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 
 /**
  * Class BookmarkFilterTest.
@@ -46,10 +47,10 @@ public static function setUpBeforeClass(): void
         $conf = new ConfigManager('tests/utils/config/configJson');
         $conf->set('resource.datastore', self::$testDatastore);
         static::$pluginManager = new PluginManager($conf);
-        self::$refDB = new \ReferenceLinkDB();
+        self::$refDB = new ReferenceLinkDB();
         self::$refDB->write(self::$testDatastore);
         $history = new History('sandbox/history.php');
-        self::$bookmarkService = new \FakeBookmarkService($conf, static::$pluginManager, $history, $mutex, true);
+        self::$bookmarkService = new FakeBookmarkService($conf, static::$pluginManager, $history, $mutex, true);
         self::$linkFilter = new BookmarkFilter(self::$bookmarkService->getBookmarks(), $conf, static::$pluginManager);
     }
 
@@ -417,28 +418,28 @@ public function testFilterCrossedSearch()
             1,
             count(self::$linkFilter->filter(
                 BookmarkFilter::$FILTER_TAG | BookmarkFilter::$FILTER_TEXT,
-                array($tags, $terms)
+                [$tags, $terms]
             ))
         );
         $this->assertEquals(
             2,
             count(self::$linkFilter->filter(
                 BookmarkFilter::$FILTER_TAG | BookmarkFilter::$FILTER_TEXT,
-                array('', $terms)
+                ['', $terms]
             ))
         );
         $this->assertEquals(
             1,
             count(self::$linkFilter->filter(
                 BookmarkFilter::$FILTER_TAG | BookmarkFilter::$FILTER_TEXT,
-                array(false, 'PSR-2')
+                [false, 'PSR-2']
             ))
         );
         $this->assertEquals(
             1,
             count(self::$linkFilter->filter(
                 BookmarkFilter::$FILTER_TAG | BookmarkFilter::$FILTER_TEXT,
-                array($tags, '')
+                [$tags, '']
             ))
         );
         $this->assertEquals(

tests/bookmark/BookmarkInitializerTest.php

@@ -7,6 +7,7 @@
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 
 /**
  * Class BookmarkInitializerTest
@@ -52,7 +53,7 @@ public function setUp(): void
             unlink(self::$testDatastore);
         }
 
-        copy('tests/utils/config/configJson.json.php', self::$testConf .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$testConf . '.json.php');
         $this->conf = new ConfigManager(self::$testConf);
         $this->conf->set('resource.datastore', self::$testDatastore);
         $this->pluginManager = new PluginManager($this->conf);
@@ -73,7 +74,7 @@ public function setUp(): void
      */
     public function testInitializeNotEmptyDataStore(): void
     {
-        $refDB = new \ReferenceLinkDB();
+        $refDB = new ReferenceLinkDB();
         $refDB->write(self::$testDatastore);
         $this->bookmarkService = new BookmarkFileService(
             $this->conf,

tests/bookmark/BookmarkTest.php

@@ -167,7 +167,7 @@ public function testValidateNotValidNoId()
             $exception = $e;
         }
         $this->assertNotNull($exception);
-        $this->assertContainsPolyfill('- ID: '. PHP_EOL, $exception->getMessage());
+        $this->assertContainsPolyfill('- ID: ' . PHP_EOL, $exception->getMessage());
     }
 
     /**
@@ -186,7 +186,7 @@ public function testValidateNotValidNoShortUrl()
             $exception = $e;
         }
         $this->assertNotNull($exception);
-        $this->assertContainsPolyfill('- ShortUrl: '. PHP_EOL, $exception->getMessage());
+        $this->assertContainsPolyfill('- ShortUrl: ' . PHP_EOL, $exception->getMessage());
     }
 
     /**
@@ -205,7 +205,7 @@ public function testValidateNotValidNoCreated()
             $exception = $e;
         }
         $this->assertNotNull($exception);
-        $this->assertContainsPolyfill('- Created: '. PHP_EOL, $exception->getMessage());
+        $this->assertContainsPolyfill('- Created: ' . PHP_EOL, $exception->getMessage());
     }
 
     /**

tests/bookmark/LinkUtilsTest.php

@@ -4,8 +4,6 @@
 
 use Shaarli\TestCase;
 
-require_once 'tests/utils/CurlUtils.php';
-
 /**
  * Class LinkUtilsTest.
  */
@@ -142,7 +140,7 @@ public function testHtmlExtractExistentNameTag()
         $this->assertEquals($description, html_extract_tag('description', $html));
 
         // OpenGraph multiple properties both end with noise
-        $html = '<meta tag1="content1" property="og:unrelated1 og:description og:unrelated2" '.
+        $html = '<meta tag1="content1" property="og:unrelated1 og:description og:unrelated2" ' .
             'tag2="content2" content="' . $description . '" tag3="content3">';
         $this->assertEquals($description, html_extract_tag('description', $html));
 
@@ -159,7 +157,7 @@ public function testHtmlExtractExistentNameTag()
         $this->assertEquals($description, html_extract_tag('description', $html));
 
         // OpenGraph reversed multiple properties both end with noise
-        $html = '<meta tag1="content1" content="' . $description . '" tag2="content2" '.
+        $html = '<meta tag1="content1" content="' . $description . '" tag2="content2" ' .
             'property="og:unrelated1 og:description og:unrelated2" tag3="content3">';
         $this->assertEquals($description, html_extract_tag('description', $html));
 
@@ -178,7 +176,7 @@ public function testHtmlExtractExistentNameTagWithMixedQuotes(): void
         $html = '<meta property="og:description" content="' . $description . '">';
         $this->assertEquals($description, html_extract_tag('description', $html));
 
-        $html = '<meta tag1="content1" property="og:unrelated1 og:description og:unrelated2" '.
+        $html = '<meta tag1="content1" property="og:unrelated1 og:description og:unrelated2" ' .
             'tag2="content2" content="' . $description . '" tag3="content3">';
         $this->assertEquals($description, html_extract_tag('description', $html));
 
@@ -190,7 +188,7 @@ public function testHtmlExtractExistentNameTagWithMixedQuotes(): void
         $html = '<meta property="og:description" content=\'' . $description . '\'>';
         $this->assertEquals($description, html_extract_tag('description', $html));
 
-        $html = '<meta tag1="content1" property="og:unrelated1 og:description og:unrelated2" '.
+        $html = '<meta tag1="content1" property="og:unrelated1 og:description og:unrelated2" ' .
             'tag2="content2" content=\'' . $description . '\' tag3="content3">';
         $this->assertEquals($description, html_extract_tag('description', $html));
 
@@ -247,9 +245,9 @@ public function testHtmlExtractNonExistentOgTag()
 
     public function testHtmlExtractDescriptionFromGoogleRealCase(): void
     {
-        $html = 'id="gsr"><meta content="Fêtes de fin d\'année" property="twitter:title"><meta '.
+        $html = 'id="gsr"><meta content="Fêtes de fin d\'année" property="twitter:title"><meta ' .
-                'content="Bonnes fêtes de fin d\'année ! #GoogleDoodle" property="twitter:description">'.
+                'content="Bonnes fêtes de fin d\'année ! #GoogleDoodle" property="twitter:description">' .
-                '<meta content="Bonnes fêtes de fin d\'année ! #GoogleDoodle" property="og:description">'.
+                '<meta content="Bonnes fêtes de fin d\'année ! #GoogleDoodle" property="og:description">' .
                 '<meta content="summary_large_image" property="twitter:card"><meta co'
         ;
         $this->assertSame('Bonnes fêtes de fin d\'année ! #GoogleDoodle', html_extract_tag('description', $html));
@@ -701,7 +699,10 @@ public function testTagsFilterWithSpaceSeparator(): void
         static::assertSame(['tag1', 'tag2', 'tag3'], tags_filter(['tag1', 'tag2', 'tag3'], $separator));
         static::assertSame(['tag1,', 'tag2@', 'tag3'], tags_filter(['tag1,', 'tag2@', 'tag3'], $separator));
         static::assertSame(['tag1', 'tag2', 'tag3'], tags_filter(['   tag1   ', 'tag2', 'tag3   '], $separator));
-        static::assertSame(['tag1', 'tag2', 'tag3'], tags_filter(['   tag1   ', ' ', 'tag2', '   ', 'tag3   '], $separator));
+        static::assertSame(
+            ['tag1', 'tag2', 'tag3'],
+            tags_filter(['   tag1   ', ' ', 'tag2', '   ', 'tag3   '], $separator)
+        );
         static::assertSame(['tag1'], tags_filter(['   tag1   '], $separator));
         static::assertSame([], tags_filter(['  '], $separator));
         static::assertSame([], tags_filter([], $separator));
@@ -721,7 +722,10 @@ public function testTagsArrayFilterWithSpaceSeparator(): void
             ['tag1', 'tag2, and other', 'tag3'],
             tags_filter(['@@@@ tag1@@@', ' @tag2, and other @', 'tag3@@@@'], $separator)
         );
-        static::assertSame(['tag1', 'tag2', 'tag3'], tags_filter(['@@@tag1@@@', '@', 'tag2', '@@@', 'tag3@@@'], $separator));
+        static::assertSame(
+            ['tag1', 'tag2', 'tag3'],
+            tags_filter(['@@@tag1@@@', '@', 'tag2', '@@@', 'tag3@@@'], $separator)
+        );
         static::assertSame(['tag1'], tags_filter(['@@@@tag1@@@@'], $separator));
         static::assertSame([], tags_filter(['@@@'], $separator));
         static::assertSame([], tags_filter([], $separator));

tests/bootstrap.php

@@ -2,6 +2,8 @@
 
 require_once 'vendor/autoload.php';
 
+use Shaarli\Tests\Utils\ReferenceSessionIdHashes;
+
 $conf = new \Shaarli\Config\ConfigManager('tests/utils/config/configJson');
 new \Shaarli\Languages('en', $conf);
 
@@ -13,23 +15,26 @@ function is_iterable($var)
     }
 }
 
-// TODO: remove this after fixing UT
+// raw functions
+require_once 'application/config/ConfigPlugin.php';
 require_once 'application/bookmark/LinkUtils.php';
-require_once 'application/Utils.php';
 require_once 'application/http/UrlUtils.php';
 require_once 'application/http/HttpUtils.php';
+require_once 'application/Utils.php';
+require_once 'application/TimeZone.php';
+require_once 'tests/utils/CurlUtils.php';
+require_once 'tests/utils/RainTPL.php';
+
+// TODO: remove this after fixing UT
 require_once 'tests/TestCase.php';
 require_once 'tests/container/ShaarliTestContainer.php';
 require_once 'tests/front/controller/visitor/FrontControllerMockHelper.php';
 require_once 'tests/front/controller/admin/FrontAdminControllerMockHelper.php';
-require_once 'tests/updater/DummyUpdater.php';
-require_once 'tests/utils/FakeBookmarkService.php';
 require_once 'tests/utils/FakeConfigManager.php';
 require_once 'tests/utils/ReferenceHistory.php';
 require_once 'tests/utils/ReferenceLinkDB.php';
-require_once 'tests/utils/ReferenceSessionIdHashes.php';
 
-\ReferenceSessionIdHashes::genAllHashes();
+ReferenceSessionIdHashes::genAllHashes();
 
 if (!defined('SHAARLI_MUTEX_FILE')) {
     define('SHAARLI_MUTEX_FILE', __FILE__);

tests/config/ConfigManagerTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Config;
 
 /**
@@ -29,13 +30,13 @@ public function testSetGet()
         $this->conf->set('paramInt', 42);
         $this->conf->set('paramString', 'value1');
         $this->conf->set('paramBool', false);
-        $this->conf->set('paramArray', array('foo' => 'bar'));
+        $this->conf->set('paramArray', ['foo' => 'bar']);
         $this->conf->set('paramNull', null);
 
         $this->assertEquals(42, $this->conf->get('paramInt'));
         $this->assertEquals('value1', $this->conf->get('paramString'));
         $this->assertFalse($this->conf->get('paramBool'));
-        $this->assertEquals(array('foo' => 'bar'), $this->conf->get('paramArray'));
+        $this->assertEquals(['foo' => 'bar'], $this->conf->get('paramArray'));
         $this->assertEquals(null, $this->conf->get('paramNull'));
     }
 
@@ -51,7 +52,7 @@ public function testSetWriteGet()
         $this->conf->set('paramInt', 42);
         $this->conf->set('paramString', 'value1');
         $this->conf->set('paramBool', false);
-        $this->conf->set('paramArray', array('foo' => 'bar'));
+        $this->conf->set('paramArray', ['foo' => 'bar']);
         $this->conf->set('paramNull', null);
 
         $this->conf->setConfigFile('tests/utils/config/configTmp');
@@ -62,7 +63,7 @@ public function testSetWriteGet()
         $this->assertEquals(42, $this->conf->get('paramInt'));
         $this->assertEquals('value1', $this->conf->get('paramString'));
         $this->assertFalse($this->conf->get('paramBool'));
-        $this->assertEquals(array('foo' => 'bar'), $this->conf->get('paramArray'));
+        $this->assertEquals(['foo' => 'bar'], $this->conf->get('paramArray'));
         $this->assertEquals(null, $this->conf->get('paramNull'));
     }
 
@@ -112,7 +113,7 @@ public function testSetArrayKey()
         $this->expectException(\Exception::class);
         $this->expectExceptionMessageRegExp('#^Invalid setting key parameter. String expected, got.*#');
 
-        $this->conf->set(array('foo' => 'bar'), 'stuff');
+        $this->conf->set(['foo' => 'bar'], 'stuff');
     }
 
     /**

tests/config/ConfigPhpTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Config;
 
 /**
@@ -37,7 +38,7 @@ public function testRead()
      */
     public function testReadNonExistent()
     {
-        $this->assertEquals(array(), $this->configIO->read('nope'));
+        $this->assertEquals([], $this->configIO->read('nope'));
     }
 
     /**
@@ -60,16 +61,16 @@ public function testReadEmpty()
     public function testWriteNew()
     {
         $dataFile = 'tests/utils/config/configWrite.php';
-        $data = array(
+        $data = [
             'login' => 'root',
             'redirector' => 'lala',
-            'config' => array(
+            'config' => [
                 'DATASTORE' => 'data/datastore.php',
-            ),
+            ],
-            'plugins' => array(
+            'plugins' => [
                 'WALLABAG_VERSION' => '1',
-            )
+            ]
-        );
+        ];
         $this->configIO->write($dataFile, $data);
         $expected = '<?php 
 $GLOBALS[\'login\'] = \'root\';

tests/config/ConfigPluginTest.php

@@ -1,15 +1,15 @@
 <?php
+
 namespace Shaarli\Config;
 
 use Shaarli\Config\Exception\PluginConfigOrderException;
 use Shaarli\Plugin\PluginManager;
-
+use Shaarli\TestCase;
-require_once 'application/config/ConfigPlugin.php';
 
 /**
  * Unitary tests for Shaarli config related functions
  */
-class ConfigPluginTest extends \Shaarli\TestCase
+class ConfigPluginTest extends TestCase
 {
     /**
      * Test save_plugin_config with valid data.
@@ -35,12 +35,16 @@ public function testSavePluginConfigValid()
 
         mkdir($path = __DIR__ . '/folder');
         PluginManager::$PLUGINS_PATH = $path;
-        array_map(function (string $plugin) use ($path) { touch($path . '/' . $plugin); }, $expected);
+        array_map(function (string $plugin) use ($path) {
+            touch($path . '/' . $plugin);
+        }, $expected);
 
         $out = save_plugin_config($data);
         $this->assertEquals($expected, $out);
 
-        array_map(function (string $plugin) use ($path) { unlink($path . '/' . $plugin); }, $expected);
+        array_map(function (string $plugin) use ($path) {
+            unlink($path . '/' . $plugin);
+        }, $expected);
         rmdir($path);
     }
 
@@ -49,15 +53,15 @@ public function testSavePluginConfigValid()
      */
     public function testSavePluginConfigInvalid()
     {
-        $this->expectException(\Shaarli\Config\Exception\PluginConfigOrderException::class);
+        $this->expectException(PluginConfigOrderException::class);
 
-        $data = array(
+        $data = [
             'plugin2' => 0,
             'plugin3' => 0,
             'order_plugin3' => 0,
             'plugin4' => 0,
             'order_plugin4' => 0,
-        );
+        ];
 
         save_plugin_config($data);
     }
@@ -67,7 +71,7 @@ public function testSavePluginConfigInvalid()
      */
     public function testSavePluginConfigEmpty()
     {
-        $this->assertEquals(array(), save_plugin_config(array()));
+        $this->assertEquals([], save_plugin_config([]));
     }
 
     /**
@@ -75,14 +79,14 @@ public function testSavePluginConfigEmpty()
      */
     public function testValidatePluginOrderValid()
     {
-        $data = array(
+        $data = [
             'order_plugin1' => 2,
             'plugin2' => 0,
             'plugin3' => 0,
             'order_plugin3' => 1,
             'plugin4' => 0,
             'order_plugin4' => 5,
-        );
+        ];
 
         $this->assertTrue(validate_plugin_order($data));
     }
@@ -92,11 +96,11 @@ public function testValidatePluginOrderValid()
      */
     public function testValidatePluginOrderInvalid()
     {
-        $data = array(
+        $data = [
             'order_plugin1' => 2,
             'order_plugin3' => 1,
             'order_plugin4' => 1,
-        );
+        ];
 
         $this->assertFalse(validate_plugin_order($data));
     }
@@ -106,20 +110,20 @@ public function testValidatePluginOrderInvalid()
      */
     public function testLoadPluginParameterValues()
     {
-        $plugins = array(
+        $plugins = [
-            'plugin_name' => array(
+            'plugin_name' => [
-                'parameters' => array(
+                'parameters' => [
-                    'param1' => array('value' => true),
+                    'param1' => ['value' => true],
-                    'param2' => array('value' => false),
+                    'param2' => ['value' => false],
-                    'param3' => array('value' => ''),
+                    'param3' => ['value' => ''],
-                )
+                ]
-            )
+            ]
-        );
+        ];
 
-        $parameters = array(
+        $parameters = [
             'param1' => 'value1',
             'param2' => 'value2',
-        );
+        ];
 
         $result = load_plugin_parameter_values($plugins, $parameters);
         $this->assertEquals('value1', $result['plugin_name']['parameters']['param1']['value']);

tests/feed/CachedPageTest.php

@@ -1,7 +1,9 @@
 <?php
+
 /**
  * PageCache tests
  */
+
 namespace Shaarli\Feed;
 
 /**

tests/feed/FeedBuilderTest.php

@@ -4,7 +4,6 @@
 
 use DateTime;
 use malkusch\lock\mutex\NoMutex;
-use ReferenceLinkDB;
 use Shaarli\Bookmark\Bookmark;
 use Shaarli\Bookmark\BookmarkFileService;
 use Shaarli\Bookmark\LinkDB;
@@ -13,6 +12,7 @@
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 
 /**
  * FeedBuilderTest class.
@@ -52,7 +52,7 @@ public static function setUpBeforeClass(): void
         $mutex = new NoMutex();
         $conf = new ConfigManager('tests/utils/config/configJson');
         $conf->set('resource.datastore', self::$testDatastore);
-        $refLinkDB = new \ReferenceLinkDB();
+        $refLinkDB = new ReferenceLinkDB();
         $refLinkDB->write(self::$testDatastore);
         $history = new History('sandbox/history.php');
         $factory = new FormatterFactory($conf, true);
@@ -66,13 +66,13 @@ public static function setUpBeforeClass(): void
             true
         );
 
-        self::$serverInfo = array(
+        self::$serverInfo = [
             'HTTPS' => 'Off',
             'SERVER_NAME' => 'host.tld',
             'SERVER_PORT' => '80',
             'SCRIPT_NAME' => '/index.php',
             'REQUEST_URI' => '/feed/atom',
-        );
+        ];
     }
 
     /**
@@ -100,7 +100,10 @@ public function testRSSBuildData()
         // Test first not pinned link (note link)
         $link = $data['links'][array_keys($data['links'])[0]];
         $this->assertEquals(41, $link['id']);
-        $this->assertEquals(DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114651'), $link['created']);
+        $this->assertEquals(
+            DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114651'),
+            $link['created']
+        );
         $this->assertEquals('http://host.tld/shaare/WDWyig', $link['guid']);
         $this->assertEquals('http://host.tld/shaare/WDWyig', $link['url']);
         $this->assertRegExp('/Tue, 10 Mar 2015 11:46:51 \+\d{4}/', $link['pub_iso_date']);
@@ -149,10 +152,10 @@ public function testAtomBuildData()
      */
     public function testBuildDataFiltered()
     {
-        $criteria = array(
+        $criteria = [
             'searchtags' => 'stuff',
             'searchterm' => 'beard',
-        );
+        ];
         $feedBuilder = new FeedBuilder(
             self::$bookmarkService,
             self::$formatter,
@@ -164,7 +167,10 @@ public function testBuildDataFiltered()
         $this->assertEquals(1, count($data['links']));
         $link = array_shift($data['links']);
         $this->assertEquals(41, $link['id']);
-        $this->assertEquals(DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114651'), $link['created']);
+        $this->assertEquals(
+            DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114651'),
+            $link['created']
+        );
     }
 
     /**
@@ -172,9 +178,9 @@ public function testBuildDataFiltered()
      */
     public function testBuildDataCount()
     {
-        $criteria = array(
+        $criteria = [
             'nb' => '3',
-        );
+        ];
         $feedBuilder = new FeedBuilder(
             self::$bookmarkService,
             self::$formatter,
@@ -186,7 +192,10 @@ public function testBuildDataCount()
         $this->assertEquals(3, count($data['links']));
         $link = $data['links'][array_keys($data['links'])[0]];
         $this->assertEquals(41, $link['id']);
-        $this->assertEquals(DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114651'), $link['created']);
+        $this->assertEquals(
+            DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114651'),
+            $link['created']
+        );
     }
 
     /**
@@ -208,7 +217,10 @@ public function testBuildDataPermalinks()
         // First link is a permalink
         $link = $data['links'][array_keys($data['links'])[0]];
         $this->assertEquals(41, $link['id']);
-        $this->assertEquals(DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114651'), $link['created']);
+        $this->assertEquals(
+            DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114651'),
+            $link['created']
+        );
         $this->assertEquals('http://host.tld/shaare/WDWyig', $link['guid']);
         $this->assertEquals('http://host.tld/shaare/WDWyig', $link['url']);
         $this->assertContainsPolyfill('Direct link', $link['description']);
@@ -216,7 +228,10 @@ public function testBuildDataPermalinks()
         // Second link is a direct link
         $link = $data['links'][array_keys($data['links'])[1]];
         $this->assertEquals(8, $link['id']);
-        $this->assertEquals(DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114633'), $link['created']);
+        $this->assertEquals(
+            DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150310_114633'),
+            $link['created']
+        );
         $this->assertEquals('http://host.tld/shaare/RttfEw', $link['guid']);
         $this->assertEquals('https://static.fsf.org/nosvn/faif-2.0.pdf', $link['url']);
         $this->assertContainsPolyfill('Direct link', $link['description']);
@@ -259,13 +274,13 @@ public function testBuildDataHideDates()
      */
     public function testBuildDataServerSubdir()
     {
-        $serverInfo = array(
+        $serverInfo = [
             'HTTPS' => 'Off',
             'SERVER_NAME' => 'host.tld',
             'SERVER_PORT' => '8080',
             'SCRIPT_NAME' => '/~user/shaarli/index.php',
             'REQUEST_URI' => '/~user/shaarli/feed/atom',
-        );
+        ];
         $feedBuilder = new FeedBuilder(
             self::$bookmarkService,
             self::$formatter,

tests/formatter/BookmarkDefaultFormatterTest.php

@@ -27,7 +27,7 @@ class BookmarkDefaultFormatterTest extends TestCase
      */
     protected function setUp(): void
     {
-        copy('tests/utils/config/configJson.json.php', self::$testConf .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$testConf . '.json.php');
         $this->conf = new ConfigManager(self::$testConf);
         $this->formatter = new BookmarkDefaultFormatter($this->conf, true);
     }
@@ -112,9 +112,9 @@ public function testFormatDescription()
     {
         $description = [];
         $description[] = 'This a <strong>description</strong>' . PHP_EOL;
-        $description[] = 'text https://sub.domain.tld?query=here&for=real#hash more text'. PHP_EOL;
+        $description[] = 'text https://sub.domain.tld?query=here&for=real#hash more text' . PHP_EOL;
-        $description[] = 'Also, there is an #hashtag added'. PHP_EOL;
+        $description[] = 'Also, there is an #hashtag added' . PHP_EOL;
-        $description[] = '    A  N  D KEEP     SPACES    !   '. PHP_EOL;
+        $description[] = '    A  N  D KEEP     SPACES    !   ' . PHP_EOL;
 
         $bookmark = new Bookmark();
         $bookmark->setDescription(implode('', $description));
@@ -122,10 +122,10 @@ public function testFormatDescription()
 
         $description[0] = 'This a &lt;strong&gt;description&lt;/strong&gt;<br />';
         $url = 'https://sub.domain.tld?query=here&amp;for=real#hash';
-        $description[1] = 'text <a href="'. $url .'">'. $url .'</a> more text<br />';
+        $description[1] = 'text <a href="' . $url . '">' . $url . '</a> more text<br />';
-        $description[2] = 'Also, there is an <a href="./add-tag/hashtag" '.
+        $description[2] = 'Also, there is an <a href="./add-tag/hashtag" ' .
             'title="Hashtag hashtag">#hashtag</a> added<br />';
-        $description[3] = '&nbsp; &nbsp; A &nbsp;N &nbsp;D KEEP &nbsp; &nbsp; '.
+        $description[3] = '&nbsp; &nbsp; A &nbsp;N &nbsp;D KEEP &nbsp; &nbsp; ' .
             'SPACES &nbsp; &nbsp;! &nbsp; <br />';
 
         $this->assertEquals(implode(PHP_EOL, $description) . PHP_EOL, $link['description']);
@@ -148,7 +148,7 @@ public function testFormatNoteWithIndexUrl()
         $this->assertEquals($root . $short, $link['url']);
         $this->assertEquals($root . $short, $link['real_url']);
         $this->assertEquals(
-            'Text <a href="'. $root .'./add-tag/hashtag" title="Hashtag hashtag">'.
+            'Text <a href="' . $root . './add-tag/hashtag" title="Hashtag hashtag">' .
             '#hashtag</a> more text',
             $link['description']
         );

tests/formatter/BookmarkMarkdownExtraFormatterTest.php

@@ -27,7 +27,7 @@ class BookmarkMarkdownExtraFormatterTest extends TestCase
      */
     public function setUp(): void
     {
-        copy('tests/utils/config/configJson.json.php', self::$testConf .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$testConf . '.json.php');
         $this->conf = new ConfigManager(self::$testConf);
         $this->formatter = new BookmarkMarkdownExtraFormatter($this->conf, true);
     }
@@ -60,8 +60,8 @@ public function testFormatExtra(): void
         );
         $this->assertEquals('This is a <strong>bookmark</strong>', $link['title']);
         $this->assertEquals(
-            '<div class="markdown"><p>'.
+            '<div class="markdown"><p>' .
-                '&lt;h2&gt;Content&lt;/h2&gt;&lt;p&gt;`Here is some content&lt;/p&gt;'.
+                '&lt;h2&gt;Content&lt;/h2&gt;&lt;p&gt;`Here is some content&lt;/p&gt;' .
             '</p></div>',
             $link['description']
         );
@@ -112,21 +112,21 @@ public function testFormatExtraMinimal(): void
      */
     public function testFormatExtrraDescription(): void
     {
-        $description = 'This a <strong>description</strong>'. PHP_EOL;
+        $description = 'This a <strong>description</strong>' . PHP_EOL;
-        $description .= 'text https://sub.domain.tld?query=here&for=real#hash more text'. PHP_EOL;
+        $description .= 'text https://sub.domain.tld?query=here&for=real#hash more text' . PHP_EOL;
-        $description .= 'Also, there is an #hashtag added'. PHP_EOL;
+        $description .= 'Also, there is an #hashtag added' . PHP_EOL;
-        $description .= '    A  N  D KEEP     SPACES    !   '. PHP_EOL;
+        $description .= '    A  N  D KEEP     SPACES    !   ' . PHP_EOL;
-        $description .= '# Header {.class}'. PHP_EOL;
+        $description .= '# Header {.class}' . PHP_EOL;
 
         $bookmark = new Bookmark();
         $bookmark->setDescription($description);
         $link = $this->formatter->format($bookmark);
 
         $description = '<div class="markdown"><p>';
-        $description .= 'This a &lt;strong&gt;description&lt;/strong&gt;<br />'. PHP_EOL;
+        $description .= 'This a &lt;strong&gt;description&lt;/strong&gt;<br />' . PHP_EOL;
         $url = 'https://sub.domain.tld?query=here&amp;for=real#hash';
-        $description .= 'text <a href="'. $url .'">'. $url .'</a> more text<br />'. PHP_EOL;
+        $description .= 'text <a href="' . $url . '">' . $url . '</a> more text<br />' . PHP_EOL;
-        $description .= 'Also, there is an <a href="./add-tag/hashtag">#hashtag</a> added<br />'. PHP_EOL;
+        $description .= 'Also, there is an <a href="./add-tag/hashtag">#hashtag</a> added<br />' . PHP_EOL;
         $description .= 'A  N  D KEEP     SPACES    !   </p>' . PHP_EOL;
         $description .= '<h1 class="class">Header</h1>';
         $description .= '</div>';
@@ -148,7 +148,7 @@ public function testFormatExtraNoteWithIndexUrl(): void
         $this->formatter->addContextData('index_url', $root = 'https://domain.tld/hithere/');
 
         $description = '<div class="markdown"><p>';
-        $description .= 'Text <a href="'. $root .'./add-tag/hashtag">#hashtag</a> more text';
+        $description .= 'Text <a href="' . $root . './add-tag/hashtag">#hashtag</a> more text';
         $description .= '</p></div>';
 
         $link = $this->formatter->format($bookmark);

tests/formatter/BookmarkMarkdownFormatterTest.php

@@ -27,7 +27,7 @@ class BookmarkMarkdownFormatterTest extends TestCase
      */
     protected function setUp(): void
     {
-        copy('tests/utils/config/configJson.json.php', self::$testConf .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$testConf . '.json.php');
         $this->conf = new ConfigManager(self::$testConf);
         $this->formatter = new BookmarkMarkdownFormatter($this->conf, true);
     }
@@ -60,8 +60,8 @@ public function testFormatFull()
         );
         $this->assertEquals('This is a <strong>bookmark</strong>', $link['title']);
         $this->assertEquals(
-            '<div class="markdown"><p>'.
+            '<div class="markdown"><p>' .
-                '&lt;h2&gt;Content&lt;/h2&gt;&lt;p&gt;`Here is some content&lt;/p&gt;'.
+                '&lt;h2&gt;Content&lt;/h2&gt;&lt;p&gt;`Here is some content&lt;/p&gt;' .
             '</p></div>',
             $link['description']
         );
@@ -112,20 +112,20 @@ public function testFormatMinimal()
      */
     public function testFormatDescription()
     {
-        $description = 'This a <strong>description</strong>'. PHP_EOL;
+        $description = 'This a <strong>description</strong>' . PHP_EOL;
-        $description .= 'text https://sub.domain.tld?query=here&for=real#hash more text'. PHP_EOL;
+        $description .= 'text https://sub.domain.tld?query=here&for=real#hash more text' . PHP_EOL;
-        $description .= 'Also, there is an #hashtag added'. PHP_EOL;
+        $description .= 'Also, there is an #hashtag added' . PHP_EOL;
-        $description .= '    A  N  D KEEP     SPACES    !   '. PHP_EOL;
+        $description .= '    A  N  D KEEP     SPACES    !   ' . PHP_EOL;
 
         $bookmark = new Bookmark();
         $bookmark->setDescription($description);
         $link = $this->formatter->format($bookmark);
 
         $description = '<div class="markdown"><p>';
-        $description .= 'This a &lt;strong&gt;description&lt;/strong&gt;<br />'. PHP_EOL;
+        $description .= 'This a &lt;strong&gt;description&lt;/strong&gt;<br />' . PHP_EOL;
         $url = 'https://sub.domain.tld?query=here&amp;for=real#hash';
-        $description .= 'text <a href="'. $url .'">'. $url .'</a> more text<br />'. PHP_EOL;
+        $description .= 'text <a href="' . $url . '">' . $url . '</a> more text<br />' . PHP_EOL;
-        $description .= 'Also, there is an <a href="./add-tag/hashtag">#hashtag</a> added<br />'. PHP_EOL;
+        $description .= 'Also, there is an <a href="./add-tag/hashtag">#hashtag</a> added<br />' . PHP_EOL;
         $description .= 'A  N  D KEEP     SPACES    !   ';
         $description .= '</p></div>';
 
@@ -137,11 +137,11 @@ public function testFormatDescription()
      */
     public function testFormatDescriptionWithSearchHighlight()
     {
-        $description = 'This a <strong>description</strong>'. PHP_EOL;
+        $description = 'This a <strong>description</strong>' . PHP_EOL;
-        $description .= 'text https://sub.domain.tld?query=here&for=real#hash more text'. PHP_EOL;
+        $description .= 'text https://sub.domain.tld?query=here&for=real#hash more text' . PHP_EOL;
-        $description .= 'Also, there is an #hashtag added'. PHP_EOL;
+        $description .= 'Also, there is an #hashtag added' . PHP_EOL;
-        $description .= '    A  N  D KEEP     SPACES    !   '. PHP_EOL;
+        $description .= '    A  N  D KEEP     SPACES    !   ' . PHP_EOL;
-        $description .= 'And [yet another link](https://other.domain.tld)'. PHP_EOL;
+        $description .= 'And [yet another link](https://other.domain.tld)' . PHP_EOL;
 
         $bookmark = new Bookmark();
         $bookmark->setDescription($description);
@@ -164,9 +164,9 @@ public function testFormatDescriptionWithSearchHighlight()
         $url = 'https://sub.domain.tld?query=here&amp;for=real#hash';
         $highlighted = 'https://<span class="search-highlight">sub</span>.domain.tld';
         $highlighted .= '?query=here&amp;for=real#<span class="search-highlight">hash</span>';
-        $description .= 'text <a href="'. $url .'">'. $highlighted .'</a> more text<br />'. PHP_EOL;
+        $description .= 'text <a href="' . $url . '">' . $highlighted . '</a> more text<br />' . PHP_EOL;
         $description .= 'Also, there is an <a href="./add-tag/hashtag">#<span class="search-highlight">hasht</span>' .
-            'ag</a> added<br />'. PHP_EOL;
+            'ag</a> added<br />' . PHP_EOL;
         $description .= 'A  N  D KEEP     SPACES    !<br />' . PHP_EOL;
         $description .= 'And <a href="https://other.domain.tld">' .
             '<span class="search-highlight">yet another link</span></a>';
@@ -189,7 +189,7 @@ public function testFormatNoteWithIndexUrl()
         $this->formatter->addContextData('index_url', $root = 'https://domain.tld/hithere/');
 
         $description = '<div class="markdown"><p>';
-        $description .= 'Text <a href="'. $root .'./add-tag/hashtag">#hashtag</a> more text';
+        $description .= 'Text <a href="' . $root . './add-tag/hashtag">#hashtag</a> more text';
         $description .= '</p></div>';
 
         $link = $this->formatter->format($bookmark);

tests/formatter/BookmarkRawFormatterTest.php

@@ -27,7 +27,7 @@ class BookmarkRawFormatterTest extends TestCase
      */
     protected function setUp(): void
     {
-        copy('tests/utils/config/configJson.json.php', self::$testConf .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$testConf . '.json.php');
         $this->conf = new ConfigManager(self::$testConf);
         $this->formatter = new BookmarkRawFormatter($this->conf, true);
     }

tests/formatter/FormatterFactoryTest.php

@@ -26,7 +26,7 @@ class FormatterFactoryTest extends TestCase
      */
     protected function setUp(): void
     {
-        copy('tests/utils/config/configJson.json.php', self::$testConf .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$testConf . '.json.php');
         $this->conf = new ConfigManager(self::$testConf);
         $this->factory = new FormatterFactory($this->conf, true);
     }

tests/front/ShaarliAdminMiddlewareTest.php

@@ -63,7 +63,8 @@ public function testMiddlewareWhileLoggedOut(): void
         $response = new Response();
 
         /** @var Response $result */
-        $result = $this->middleware->__invoke($request, $response, function () {});
+        $result = $this->middleware->__invoke($request, $response, function () {
+        });
 
         static::assertSame(302, $result->getStatusCode());
         static::assertSame(

tests/front/ShaarliMiddlewareTest.php

@@ -91,7 +91,7 @@ public function testMiddlewareExecutionWithFrontException(): void
         $controller = function (): void {
             $exception = new LoginBannedException();
 
-            throw new $exception;
+            throw new $exception();
         };
 
         $pageBuilder = $this->createMock(PageBuilder::class);
@@ -148,7 +148,8 @@ public function testMiddlewareExecutionWithServerException(): void
             return $uri;
         });
 
-        $dummyException = new class() extends \Exception {};
+        $dummyException = new class () extends \Exception {
+        };
 
         $response = new Response();
         $controller = function () use ($dummyException): void {

tests/front/controller/admin/ConfigureControllerTest.php

@@ -122,8 +122,7 @@ public function testSaveNewConfig(): void
                 }
 
                 return $parameters[$key];
-            }
+            });
-        );
 
         $response = new Response();
 
@@ -137,8 +136,7 @@ public function testSaveNewConfig(): void
                 }
 
                 static::assertSame($parametersConfigMapping[$key], $value);
-            }
+            });
-        );
 
         $result = $this->controller->save($request, $response);
         static::assertSame(302, $result->getStatusCode());

tests/front/controller/admin/ExportControllerTest.php

@@ -80,7 +80,10 @@ function (
                     string $selection,
                     bool $prependNoteUrl,
                     string $indexUrl
-                ) use ($parameters, $bookmarks): array {
+                ) use (
+                    $parameters,
+                    $bookmarks
+                ): array {
                     static::assertInstanceOf(BookmarkRawFormatter::class, $formatter);
                     static::assertSame($parameters['selection'], $selection);
                     static::assertTrue($prependNoteUrl);

tests/front/controller/admin/ImportControllerTest.php

@@ -74,7 +74,10 @@ public function testImportDefault(): void
                 function (
                     array $post,
                     UploadedFileInterface $file
-                ) use ($parameters, $requestFile): string {
+                ) use (
+                    $parameters,
+                    $requestFile
+                ): string {
                     static::assertSame($parameters, $post);
                     static::assertSame($requestFile, $file);
 

tests/front/controller/admin/PasswordControllerTest.php

@@ -52,12 +52,12 @@ public function testPostNewPasswordDefault(): void
     {
         $request = $this->createMock(Request::class);
         $request->method('getParam')->willReturnCallback(function (string $key): string {
-             if ('oldpassword' === $key) {
+            if ('oldpassword' === $key) {
-                 return 'old';
+                return 'old';
-             }
+            }
-             if ('setpassword' === $key) {
+            if ('setpassword' === $key) {
-                 return 'new';
+                return 'new';
-             }
+            }
 
              return $key;
         });

tests/front/controller/admin/PluginsControllerTest.php

@@ -16,7 +16,7 @@ class PluginsControllerTest extends TestCase
 {
     use FrontAdminControllerMockHelper;
 
-    const PLUGIN_NAMES = ['plugin1', 'plugin2', 'plugin3', 'plugin4'];
+    protected const PLUGIN_NAMES = ['plugin1', 'plugin2', 'plugin3', 'plugin4'];
 
     /** @var PluginsController */
     protected $controller;
@@ -29,13 +29,17 @@ public function setUp(): void
 
         mkdir($path = __DIR__ . '/folder');
         PluginManager::$PLUGINS_PATH = $path;
-        array_map(function (string $plugin) use ($path) { touch($path . '/' . $plugin); }, static::PLUGIN_NAMES);
+        array_map(function (string $plugin) use ($path) {
+            touch($path . '/' . $plugin);
+        }, static::PLUGIN_NAMES);
     }
 
     public function tearDown(): void
     {
         $path = __DIR__ . '/folder';
-        array_map(function (string $plugin) use ($path) { unlink($path . '/' . $plugin); }, static::PLUGIN_NAMES);
+        array_map(function (string $plugin) use ($path) {
+            unlink($path . '/' . $plugin);
+        }, static::PLUGIN_NAMES);
         rmdir($path);
     }
 

tests/front/controller/admin/ShaarePublishControllerTest/SaveBookmarkTest.php

@@ -365,5 +365,4 @@ public function testSaveBookmarkWrongToken(): void
 
         $this->controller->save($request, $response);
     }
-
 }

tests/front/controller/admin/ShaarliAdminControllerTest.php

@@ -26,7 +26,7 @@ public function setUp(): void
     {
         $this->createContainer();
 
-        $this->controller = new class($this->container) extends ShaarliAdminController
+        $this->controller = new class ($this->container) extends ShaarliAdminController
         {
             public function checkToken(Request $request): bool
             {

tests/front/controller/visitor/BookmarkListControllerTest.php

@@ -54,8 +54,7 @@ public function testIndexDefaultFirstPage(): void
                 (new Bookmark())->setId(1)->setUrl('http://url1.tld')->setTitle('Title 1'),
                 (new Bookmark())->setId(2)->setUrl('http://url2.tld')->setTitle('Title 2'),
                 (new Bookmark())->setId(3)->setUrl('http://url3.tld')->setTitle('Title 3'),
-            ], 0, 2)
+            ], 0, 2));
-        );
 
         $this->container->sessionManager
             ->method('getSessionParameter')

tests/front/controller/visitor/DailyControllerTest.php

@@ -102,7 +102,7 @@ function (string $hook, array $data, array $param) use ($currentDay, $previousDa
         static::assertSame(200, $result->getStatusCode());
         static::assertSame('daily', (string) $result->getBody());
         static::assertSame(
-            'Daily - '. format_date($currentDay, false, true) .' - Shaarli',
+            'Daily - ' . format_date($currentDay, false, true) . ' - Shaarli',
             $assignedVariables['pagetitle']
         );
         static::assertEquals($currentDay, $assignedVariables['dayDate']);
@@ -225,7 +225,7 @@ public function testValidIndexControllerInvokeNoFutureOrPast(): void
         static::assertSame(200, $result->getStatusCode());
         static::assertSame('daily', (string) $result->getBody());
         static::assertSame(
-            'Daily - '. format_date($currentDay, false, true) .' - Shaarli',
+            'Daily - ' . format_date($currentDay, false, true) . ' - Shaarli',
             $assignedVariables['pagetitle']
         );
         static::assertCount(1, $assignedVariables['linksToDisplay']);
@@ -285,7 +285,9 @@ public function testValidIndexControllerInvokeHeightAdjustment(): void
         static::assertCount(7, $assignedVariables['linksToDisplay']);
 
         $columnIds = function (array $column): array {
-            return array_map(function (array $item): int { return $item['id']; }, $column);
+            return array_map(function (array $item): int {
+                return $item['id'];
+            }, $column);
         };
 
         static::assertSame([1, 4, 6], $columnIds($assignedVariables['cols'][0]));
@@ -366,8 +368,7 @@ public function testValidRssControllerInvokeDefault(): void
                 $cachedPage->expects(static::once())->method('cache')->with('dailyrss');
 
                 return $cachedPage;
-            }
+            });
-        );
 
         // Save RainTPL assigned variables
         $assignedVariables = [];
@@ -390,7 +391,7 @@ public function testValidRssControllerInvokeDefault(): void
         static::assertEquals($date, $day['date']);
         static::assertSame($date->format(\DateTime::RSS), $day['date_rss']);
         static::assertSame(format_date($date, false), $day['date_human']);
-        static::assertSame('http://shaarli/subfolder/daily?day='. $dates[0]->format('Ymd'), $day['absolute_url']);
+        static::assertSame('http://shaarli/subfolder/daily?day=' . $dates[0]->format('Ymd'), $day['absolute_url']);
         static::assertCount(1, $day['links']);
         static::assertSame(1, $day['links'][0]['id']);
         static::assertSame('http://domain.tld/1', $day['links'][0]['url']);
@@ -402,7 +403,7 @@ public function testValidRssControllerInvokeDefault(): void
         static::assertEquals($date, $day['date']);
         static::assertSame($date->format(\DateTime::RSS), $day['date_rss']);
         static::assertSame(format_date($date, false), $day['date_human']);
-        static::assertSame('http://shaarli/subfolder/daily?day='. $dates[1]->format('Ymd'), $day['absolute_url']);
+        static::assertSame('http://shaarli/subfolder/daily?day=' . $dates[1]->format('Ymd'), $day['absolute_url']);
         static::assertCount(2, $day['links']);
 
         static::assertSame(2, $day['links'][0]['id']);
@@ -418,7 +419,7 @@ public function testValidRssControllerInvokeDefault(): void
         static::assertEquals($date, $day['date']);
         static::assertSame($date->format(\DateTime::RSS), $day['date_rss']);
         static::assertSame(format_date($date, false), $day['date_human']);
-        static::assertSame('http://shaarli/subfolder/daily?day='. $dates[2]->format('Ymd'), $day['absolute_url']);
+        static::assertSame('http://shaarli/subfolder/daily?day=' . $dates[2]->format('Ymd'), $day['absolute_url']);
         static::assertCount(1, $day['links']);
         static::assertSame(4, $day['links'][0]['id']);
         static::assertSame('http://domain.tld/4', $day['links'][0]['url']);
@@ -647,7 +648,7 @@ public function testSimpleRssWeekly(): void
         static::assertEquals($date, $day['date']);
         static::assertSame($date->format(\DateTime::RSS), $day['date_rss']);
         static::assertSame('Week 21 (May 18, 2020)', $day['date_human']);
-        static::assertSame('http://shaarli/subfolder/daily?week='. $dates[0]->format('YW'), $day['absolute_url']);
+        static::assertSame('http://shaarli/subfolder/daily?week=' . $dates[0]->format('YW'), $day['absolute_url']);
         static::assertCount(1, $day['links']);
 
         $day = $assignedVariables['days'][$dates[1]->format('YW')];
@@ -656,7 +657,7 @@ public function testSimpleRssWeekly(): void
         static::assertEquals($date, $day['date']);
         static::assertSame($date->format(\DateTime::RSS), $day['date_rss']);
         static::assertSame('Week 20 (May 11, 2020)', $day['date_human']);
-        static::assertSame('http://shaarli/subfolder/daily?week='. $dates[1]->format('YW'), $day['absolute_url']);
+        static::assertSame('http://shaarli/subfolder/daily?week=' . $dates[1]->format('YW'), $day['absolute_url']);
         static::assertCount(2, $day['links']);
     }
 
@@ -710,7 +711,7 @@ public function testSimpleRssMonthly(): void
         static::assertEquals($date, $day['date']);
         static::assertSame($date->format(\DateTime::RSS), $day['date_rss']);
         static::assertSame('May, 2020', $day['date_human']);
-        static::assertSame('http://shaarli/subfolder/daily?month='. $dates[0]->format('Ym'), $day['absolute_url']);
+        static::assertSame('http://shaarli/subfolder/daily?month=' . $dates[0]->format('Ym'), $day['absolute_url']);
         static::assertCount(1, $day['links']);
 
         $day = $assignedVariables['days'][$dates[1]->format('Ym')];
@@ -719,7 +720,7 @@ public function testSimpleRssMonthly(): void
         static::assertEquals($date, $day['date']);
         static::assertSame($date->format(\DateTime::RSS), $day['date_rss']);
         static::assertSame('April, 2020', $day['date_human']);
-        static::assertSame('http://shaarli/subfolder/daily?month='. $dates[1]->format('Ym'), $day['absolute_url']);
+        static::assertSame('http://shaarli/subfolder/daily?month=' . $dates[1]->format('Ym'), $day['absolute_url']);
         static::assertCount(2, $day['links']);
     }
 }

tests/front/controller/visitor/ErrorControllerTest.php

@@ -41,7 +41,8 @@ public function testDisplayFrontExceptionError(): void
         $result = ($this->controller)(
             $request,
             $response,
-            new class($message, $errorCode) extends ShaarliFrontException {}
+            new class ($message, $errorCode) extends ShaarliFrontException {
+            }
         );
 
         static::assertSame($errorCode, $result->getStatusCode());

tests/front/controller/visitor/FrontControllerMockHelper.php

@@ -118,5 +118,5 @@ protected static function generateString(int $length): string
     /**
      * Force to be used in PHPUnit context.
      */
-    protected abstract function isInTestsContext(): bool;
+    abstract protected function isInTestsContext(): bool;
 }

tests/front/controller/visitor/InstallControllerTest.php

@@ -15,7 +15,7 @@ class InstallControllerTest extends TestCase
 {
     use FrontControllerMockHelper;
 
-    const MOCK_FILE = '.tmp';
+    protected const MOCK_FILE = '.tmp';
 
     /** @var InstallController */
     protected $controller;

tests/front/controller/visitor/ShaarliVisitorControllerTest.php

@@ -32,7 +32,7 @@ public function setUp(): void
     {
         $this->createContainer();
 
-        $this->controller = new class($this->container) extends ShaarliVisitorController
+        $this->controller = new class ($this->container) extends ShaarliVisitorController
         {
             public function assignView(string $key, $value): ShaarliVisitorController
             {

tests/front/controller/visitor/TagCloudControllerTest.php

@@ -130,12 +130,12 @@ public function testValidCloudControllerInvokeWithParameters(): void
             ->method('executeHooks')
             ->withConsecutive(['render_tagcloud'])
             ->willReturnCallback(function (string $hook, array $data, array $param): array {
-               if ('render_tagcloud' === $hook) {
+                if ('render_tagcloud' === $hook) {
-                   static::assertSame('ghi@def@', $data['search_tags']);
+                    static::assertSame('ghi@def@', $data['search_tags']);
-                   static::assertCount(1, $data['tags']);
+                    static::assertCount(1, $data['tags']);
 
-                   static::assertArrayHasKey('loggedin', $param);
+                    static::assertArrayHasKey('loggedin', $param);
-               }
+                }
 
                 return $data;
             })

tests/helper/ApplicationUtilsTest.php

@@ -1,10 +1,9 @@
 <?php
+
 namespace Shaarli\Helper;
 
 use Shaarli\Config\ConfigManager;
-use Shaarli\FakeApplicationUtils;
+use Shaarli\Tests\Utils\FakeApplicationUtils;
-
-require_once 'tests/utils/FakeApplicationUtils.php';
 
 /**
  * Unitary tests for Shaarli utilities
@@ -49,7 +48,7 @@ public function testGetVersionCode()
             '0.5.4',
             ApplicationUtils::getVersion(
                 'https://raw.githubusercontent.com/shaarli/Shaarli/'
-                .'v0.5.4/shaarli_version.php',
+                . 'v0.5.4/shaarli_version.php',
                 $testTimeout
             )
         );
@@ -57,7 +56,7 @@ public function testGetVersionCode()
             self::$versionPattern,
             ApplicationUtils::getVersion(
                 'https://raw.githubusercontent.com/shaarli/Shaarli/'
-                .'latest/shaarli_version.php',
+                . 'latest/shaarli_version.php',
                 $testTimeout
             )
         );
@@ -68,7 +67,7 @@ public function testGetVersionCode()
      */
     public function testGetVersionCodeFromFile()
     {
-        file_put_contents('sandbox/version.php', '<?php /* 1.2.3 */ ?>'. PHP_EOL);
+        file_put_contents('sandbox/version.php', '<?php /* 1.2.3 */ ?>' . PHP_EOL);
         $this->assertEquals(
             '1.2.3',
             ApplicationUtils::getVersion('sandbox/version.php', 1)
@@ -301,7 +300,7 @@ public function testCheckCurrentResourcePermissions()
         $conf->set('resource.update_check', 'data/lastupdatecheck.txt');
 
         $this->assertEquals(
-            array(),
+            [],
             ApplicationUtils::checkResourcePermissions($conf)
         );
     }
@@ -324,7 +323,7 @@ public function testCheckCurrentResourcePermissionsErrors()
         $conf->set('resource.raintpl_theme', 'null/tpl/default');
         $conf->set('resource.update_check', 'null/data/lastupdatecheck.txt');
         $this->assertEquals(
-            array(
+            [
                 '"null/tpl" directory is not readable',
                 '"null/tpl/default" directory is not readable',
                 '"null/cache" directory is not readable',
@@ -335,7 +334,7 @@ public function testCheckCurrentResourcePermissionsErrors()
                 '"null/pagecache" directory is not writable',
                 '"null/tmp" directory is not readable',
                 '"null/tmp" directory is not writable'
-            ),
+            ],
             ApplicationUtils::checkResourcePermissions($conf)
         );
     }

tests/helper/DailyPageHelperTest.php

@@ -4,6 +4,7 @@
 
 namespace Shaarli\Helper;
 
+use DateTime;
 use DateTimeImmutable;
 use DateTimeInterface;
 use Shaarli\Bookmark\Bookmark;
@@ -147,7 +148,8 @@ public function getDescriptionByTypeExceptionUnknownType(): void
     /**
      * @dataProvider getRssLengthsByType
      */
-    public function testGeRssLengthsByType(string $type): void {
+    public function testGeRssLengthsByType(string $type): void
+    {
         $length = DailyPageHelper::getRssLengthByType($type);
 
         static::assertIsInt($length);
@@ -208,31 +210,31 @@ public function getRequestedTypes(): array
     public function getRequestedDateTimes(): array
     {
         return [
-            [DailyPageHelper::DAY, '20201013', null, new \DateTime('2020-10-13')],
+            [DailyPageHelper::DAY, '20201013', null, new DateTime('2020-10-13')],
             [
                 DailyPageHelper::DAY,
                 '',
-                (new Bookmark())->setCreated($date = new \DateTime('2020-10-13 12:05:31')),
+                (new Bookmark())->setCreated($date = new DateTime('2020-10-13 12:05:31')),
                 $date,
             ],
-            [DailyPageHelper::DAY, '', null, new \DateTime()],
+            [DailyPageHelper::DAY, '', null, new DateTime()],
-            [DailyPageHelper::WEEK, '202030', null, new \DateTime('2020-07-20')],
+            [DailyPageHelper::WEEK, '202030', null, new DateTime('2020-07-20')],
             [
                 DailyPageHelper::WEEK,
                 '',
-                (new Bookmark())->setCreated($date = new \DateTime('2020-10-13 12:05:31')),
+                (new Bookmark())->setCreated($date = new DateTime('2020-10-13 12:05:31')),
-                new \DateTime('2020-10-13'),
+                new DateTime('2020-10-13'),
             ],
-            [DailyPageHelper::WEEK, '', null, new \DateTime(), 'Ym'],
+            [DailyPageHelper::WEEK, '', null, new DateTime(), 'Ym'],
-            [DailyPageHelper::MONTH, '202008', null, new \DateTime('2020-08-01'), 'Ym'],
+            [DailyPageHelper::MONTH, '202008', null, new DateTime('2020-08-01'), 'Ym'],
             [
                 DailyPageHelper::MONTH,
                 '',
-                (new Bookmark())->setCreated($date = new \DateTime('2020-10-13 12:05:31')),
+                (new Bookmark())->setCreated($date = new DateTime('2020-10-13 12:05:31')),
-                new \DateTime('2020-10-13'),
+                new DateTime('2020-10-13'),
                 'Ym'
             ],
-            [DailyPageHelper::MONTH, '', null, new \DateTime(), 'Ym'],
+            [DailyPageHelper::MONTH, '', null, new DateTime(), 'Ym'],
         ];
     }
 
@@ -254,9 +256,9 @@ public function getFormatsByType(): array
     public function getStartDatesByType(): array
     {
         return [
-            [DailyPageHelper::DAY, new DateTimeImmutable('2020-10-09 04:05:06'), new \DateTime('2020-10-09 00:00:00')],
+            [DailyPageHelper::DAY, new DateTimeImmutable('2020-10-09 04:05:06'), new DateTime('2020-10-09 00:00:00')],
-            [DailyPageHelper::WEEK, new DateTimeImmutable('2020-10-09 04:05:06'), new \DateTime('2020-10-05 00:00:00')],
+            [DailyPageHelper::WEEK, new DateTimeImmutable('2020-10-09 04:05:06'), new DateTime('2020-10-05 00:00:00')],
-            [DailyPageHelper::MONTH, new DateTimeImmutable('2020-10-09 04:05:06'), new \DateTime('2020-10-01 00:00:00')],
+            [DailyPageHelper::MONTH, new DateTimeImmutable('2020-10-09 04:05:06'), new DateTime('2020-10-01 00:00:00')],
         ];
     }
 
@@ -266,9 +268,9 @@ public function getStartDatesByType(): array
     public function getEndDatesByType(): array
     {
         return [
-            [DailyPageHelper::DAY, new DateTimeImmutable('2020-10-09 04:05:06'), new \DateTime('2020-10-09 23:59:59')],
+            [DailyPageHelper::DAY, new DateTimeImmutable('2020-10-09 04:05:06'), new DateTime('2020-10-09 23:59:59')],
-            [DailyPageHelper::WEEK, new DateTimeImmutable('2020-10-09 04:05:06'), new \DateTime('2020-10-11 23:59:59')],
+            [DailyPageHelper::WEEK, new DateTimeImmutable('2020-10-09 04:05:06'), new DateTime('2020-10-11 23:59:59')],
-            [DailyPageHelper::MONTH, new DateTimeImmutable('2020-10-09 04:05:06'), new \DateTime('2020-10-31 23:59:59')],
+            [DailyPageHelper::MONTH, new DateTimeImmutable('2020-10-09 04:05:06'), new DateTime('2020-10-31 23:59:59')],
         ];
     }
 
@@ -321,20 +323,20 @@ public function getCacheDatePeriodByType(): array
             [
                 DailyPageHelper::DAY,
                 new DateTimeImmutable('2020-10-09 04:05:06'),
-                new \DateTime('2020-10-09 00:00:00'),
+                new DateTime('2020-10-09 00:00:00'),
-                new \DateTime('2020-10-09 23:59:59'),
+                new DateTime('2020-10-09 23:59:59'),
             ],
             [
                 DailyPageHelper::WEEK,
                 new DateTimeImmutable('2020-10-09 04:05:06'),
-                new \DateTime('2020-10-05 00:00:00'),
+                new DateTime('2020-10-05 00:00:00'),
-                new \DateTime('2020-10-11 23:59:59'),
+                new DateTime('2020-10-11 23:59:59'),
             ],
             [
                 DailyPageHelper::MONTH,
                 new DateTimeImmutable('2020-10-09 04:05:06'),
-                new \DateTime('2020-10-01 00:00:00'),
+                new DateTime('2020-10-01 00:00:00'),
-                new \DateTime('2020-10-31 23:59:59'),
+                new DateTime('2020-10-31 23:59:59'),
             ],
         ];
     }

tests/http/HttpUtils/ClientIpIdTest.php

@@ -1,12 +1,11 @@
 <?php
+
 /**
  * HttpUtils' tests
  */
 
 namespace Shaarli\Http;
 
-require_once 'application/http/HttpUtils.php';
-
 /**
  * Unitary tests for client_ip_id()
  */

tests/http/HttpUtils/GetHttpUrlTest.php

@@ -1,12 +1,11 @@
 <?php
+
 /**
  * HttpUtils' tests
  */
 
 namespace Shaarli\Http;
 
-require_once 'application/http/HttpUtils.php';
-
 /**
  * Unitary tests for get_http_response()
  */

tests/http/HttpUtils/GetIpAdressFromProxyTest.php

@@ -2,8 +2,6 @@
 
 namespace Shaarli\Http;
 
-require_once 'application/http/HttpUtils.php';
-
 /**
  * Unitary tests for getIpAddressFromProxy()
  */
@@ -15,7 +13,7 @@ class GetIpAdressFromProxyTest extends \Shaarli\TestCase
      */
     public function testWithoutProxy()
     {
-        $this->assertFalse(getIpAddressFromProxy(array(), array()));
+        $this->assertFalse(getIpAddressFromProxy([], []));
     }
 
     /**
@@ -24,8 +22,8 @@ public function testWithoutProxy()
     public function testWithOneForwardedIp()
     {
         $ip = '1.1.1.1';
-        $server = array('HTTP_X_FORWARDED_FOR' => $ip);
+        $server = ['HTTP_X_FORWARDED_FOR' => $ip];
-        $this->assertEquals($ip, getIpAddressFromProxy($server, array()));
+        $this->assertEquals($ip, getIpAddressFromProxy($server, []));
     }
 
     /**
@@ -36,11 +34,11 @@ public function testWithMultipleForwardedIp()
         $ip = '1.1.1.1';
         $ip2 = '2.2.2.2';
 
-        $server = array('HTTP_X_FORWARDED_FOR' => $ip .','. $ip2);
+        $server = ['HTTP_X_FORWARDED_FOR' => $ip . ',' . $ip2];
-        $this->assertEquals($ip2, getIpAddressFromProxy($server, array()));
+        $this->assertEquals($ip2, getIpAddressFromProxy($server, []));
 
-        $server = array('HTTP_X_FORWARDED_FOR' => $ip .' ,   '. $ip2);
+        $server = ['HTTP_X_FORWARDED_FOR' => $ip . ' ,   ' . $ip2];
-        $this->assertEquals($ip2, getIpAddressFromProxy($server, array()));
+        $this->assertEquals($ip2, getIpAddressFromProxy($server, []));
     }
 
     /**
@@ -51,11 +49,11 @@ public function testWithTrustedIp()
         $ip = '1.1.1.1';
         $ip2 = '2.2.2.2';
 
-        $server = array('HTTP_X_FORWARDED_FOR' => $ip);
+        $server = ['HTTP_X_FORWARDED_FOR' => $ip];
-        $this->assertFalse(getIpAddressFromProxy($server, array($ip)));
+        $this->assertFalse(getIpAddressFromProxy($server, [$ip]));
 
-        $server = array('HTTP_X_FORWARDED_FOR' => $ip .','. $ip2);
+        $server = ['HTTP_X_FORWARDED_FOR' => $ip . ',' . $ip2];
-        $this->assertEquals($ip2, getIpAddressFromProxy($server, array($ip)));
+        $this->assertEquals($ip2, getIpAddressFromProxy($server, [$ip]));
-        $this->assertFalse(getIpAddressFromProxy($server, array($ip, $ip2)));
+        $this->assertFalse(getIpAddressFromProxy($server, [$ip, $ip2]));
     }
 }

tests/http/HttpUtils/IndexUrlTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * HttpUtils' tests
  */
@@ -7,8 +8,6 @@
 
 use Shaarli\TestCase;
 
-require_once 'application/http/HttpUtils.php';
-
 /**
  * Unitary tests for index_url()
  */
@@ -22,24 +21,24 @@ public function testRemoveIndex()
         $this->assertEquals(
             'http://host.tld/',
             index_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/index.php'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'http://host.tld/admin/',
             index_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/admin/index.php'
-                )
+                ]
             )
         );
     }
@@ -52,24 +51,24 @@ public function testOtherResource()
         $this->assertEquals(
             'http://host.tld/page.php',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/page.php'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'http://host.tld/admin/page.php',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/admin/page.php'
-                )
+                ]
             )
         );
     }
@@ -82,26 +81,26 @@ public function testPageUrlWithRoute()
         $this->assertEquals(
             'http://host.tld/picture-wall',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/index.php',
                     'REQUEST_URI' => '/picture-wall',
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'http://host.tld/admin/picture-wall',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/admin/index.php',
                     'REQUEST_URI' => '/admin/picture-wall',
-                )
+                ]
             )
         );
     }
@@ -114,26 +113,26 @@ public function testPageUrlWithRouteUnderSubfolder()
         $this->assertEquals(
             'http://host.tld/subfolder/picture-wall',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/subfolder/index.php',
                     'REQUEST_URI' => '/subfolder/picture-wall',
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'http://host.tld/subfolder/admin/picture-wall',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/subfolder/admin/index.php',
                     'REQUEST_URI' => '/subfolder/admin/picture-wall',
-                )
+                ]
             )
         );
     }

tests/http/HttpUtils/IndexUrlTestWithConstant.php

@@ -25,26 +25,26 @@ public function testIndexUrlWithConstantDefined()
         $this->assertEquals(
             'http://other-host.tld/subfolder/',
             index_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/index.php',
                     'REQUEST_URI' => '/picture-wall',
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'http://other-host.tld/subfolder/',
             index_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/admin/index.php',
                     'REQUEST_URI' => '/admin/picture-wall',
-                )
+                ]
             )
         );
     }

tests/http/HttpUtils/IsHttpsTest.php

@@ -2,8 +2,6 @@
 
 namespace Shaarli\Http;
 
-require_once 'application/http/HttpUtils.php';
-
 /**
  * Class IsHttpsTest
  *

tests/http/HttpUtils/PageUrlTest.php

@@ -1,12 +1,11 @@
 <?php
+
 /**
  * HttpUtils' tests
  */
 
 namespace Shaarli\Http;
 
-require_once 'application/http/HttpUtils.php';
-
 /**
  * Unitary tests for page_url()
  */
@@ -20,26 +19,26 @@ public function testRemoveIndex()
         $this->assertEquals(
             'http://host.tld/?p1=v1&p2=v2',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/index.php',
                     'QUERY_STRING' => 'p1=v1&p2=v2'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'http://host.tld/admin/?action=edit_tag',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/admin/index.php',
                     'QUERY_STRING' => 'action=edit_tag'
-                )
+                ]
             )
         );
     }
@@ -52,26 +51,26 @@ public function testOtherResource()
         $this->assertEquals(
             'http://host.tld/page.php?p1=v1&p2=v2',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/page.php',
                     'QUERY_STRING' => 'p1=v1&p2=v2'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'http://host.tld/admin/page.php?action=edit_tag',
             page_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'SCRIPT_NAME' => '/admin/page.php',
                     'QUERY_STRING' => 'action=edit_tag'
-                )
+                ]
             )
         );
     }

tests/http/HttpUtils/ServerUrlTest.php

@@ -1,12 +1,11 @@
 <?php
+
 /**
  * HttpUtils' tests
  */
 
 namespace Shaarli\Http;
 
-require_once 'application/http/HttpUtils.php';
-
 /**
  * Unitary tests for server_url()
  */
@@ -20,22 +19,22 @@ public function testHttpsScheme()
         $this->assertEquals(
             'https://host.tld',
             server_url(
-                array(
+                [
                     'HTTPS' => 'ON',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '443'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'https://host.tld:8080',
             server_url(
-                array(
+                [
                     'HTTPS' => 'ON',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '8080'
-                )
+                ]
             )
         );
     }
@@ -48,22 +47,22 @@ public function testHttpsProxyForwardedHost()
         $this->assertEquals(
             'https://host.tld:8080',
             server_url(
-                array(
+                [
                     'HTTP_X_FORWARDED_PROTO' => 'https',
                     'HTTP_X_FORWARDED_PORT' => '8080',
                     'HTTP_X_FORWARDED_HOST' => 'host.tld'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'https://host.tld:4974',
             server_url(
-                array(
+                [
                     'HTTP_X_FORWARDED_PROTO' => 'https, https',
                     'HTTP_X_FORWARDED_PORT' => '4974, 80',
                     'HTTP_X_FORWARDED_HOST' => 'host.tld, example.com'
-                )
+                ]
             )
         );
     }
@@ -76,51 +75,51 @@ public function testHttpsProxyForward()
         $this->assertEquals(
             'https://host.tld:8080',
             server_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'HTTP_X_FORWARDED_PROTO' => 'https',
                     'HTTP_X_FORWARDED_PORT' => '8080'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'https://host.tld',
             server_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'HTTP_X_FORWARDED_PROTO' => 'https'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'https://host.tld',
             server_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'HTTP_X_FORWARDED_PROTO' => 'https',
                     'HTTP_X_FORWARDED_PORT' => '443'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'https://host.tld:4974',
             server_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'HTTP_X_FORWARDED_PROTO' => 'https, https',
                     'HTTP_X_FORWARDED_PORT' => '4974, 80'
-                )
+                ]
             )
         );
     }
@@ -134,11 +133,11 @@ public function testPort()
         $this->assertEquals(
             'http://host.tld:8080',
             server_url(
-                array(
+                [
                     'HTTPS' => 'OFF',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '8080'
-                )
+                ]
             )
         );
 
@@ -146,11 +145,11 @@ public function testPort()
         $this->assertEquals(
             'https://host.tld:8080',
             server_url(
-                array(
+                [
                     'HTTPS' => 'ON',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '8080'
-                )
+                ]
             )
         );
     }
@@ -163,11 +162,11 @@ public function testStandardHttpPort()
         $this->assertEquals(
             'http://host.tld',
             server_url(
-                array(
+                [
                     'HTTPS' => 'OFF',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80'
-                )
+                ]
             )
         );
     }
@@ -180,11 +179,11 @@ public function testStandardHttpsPort()
         $this->assertEquals(
             'https://host.tld',
             server_url(
-                array(
+                [
                     'HTTPS' => 'ON',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '443'
-                )
+                ]
             )
         );
     }
@@ -197,26 +196,26 @@ public function testHttpWithPort433()
         $this->assertEquals(
             'https://host.tld',
             server_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'HTTP_X_FORWARDED_PROTO' => 'http',
                     'HTTP_X_FORWARDED_PORT' => '443'
-                )
+                ]
             )
         );
 
         $this->assertEquals(
             'https://host.tld',
             server_url(
-                array(
+                [
                     'HTTPS' => 'Off',
                     'SERVER_NAME' => 'host.tld',
                     'SERVER_PORT' => '80',
                     'HTTP_X_FORWARDED_PROTO' => 'https, http',
                     'HTTP_X_FORWARDED_PORT' => '443, 80'
-                )
+                ]
             )
         );
     }

tests/http/MetadataRetrieverTest.php

@@ -66,7 +66,12 @@ function (&$charset) use (
             ->expects(static::once())
             ->method('getCurlDownloadCallback')
             ->willReturnCallback(
-                function (&$charset, &$title, &$description, &$tags) use (
+                function (
+                    &$charset,
+                    &$title,
+                    &$description,
+                    &$tags
+                ) use (
                     $remoteCharset,
                     $remoteTitle,
                     $remoteDesc,
@@ -95,7 +100,7 @@ function (&$charset, &$title, &$description, &$tags) use (
             ->expects(static::once())
             ->method('getHttpResponse')
             ->with($url, 30, 4194304)
-            ->willReturnCallback(function($url, $timeout, $maxBytes, $headerCallback, $dlCallback): void {
+            ->willReturnCallback(function ($url, $timeout, $maxBytes, $headerCallback, $dlCallback): void {
                 $headerCallback();
                 $dlCallback();
             })
@@ -124,7 +129,8 @@ public function testEmptyRetrieval(): void
             ->method('getCurlDownloadCallback')
             ->willReturnCallback(
                 function (): callable {
-                    return function (): void {};
+                    return function (): void {
+                    };
                 }
             )
         ;
@@ -133,7 +139,8 @@ function (): callable {
             ->method('getCurlHeaderCallback')
             ->willReturnCallback(
                 function (): callable {
-                    return function (): void {};
+                    return function (): void {
+                    };
                 }
             )
         ;
@@ -141,7 +148,7 @@ function (): callable {
             ->expects(static::once())
             ->method('getHttpResponse')
             ->with($url, 30, 4194304)
-            ->willReturnCallback(function($url, $timeout, $maxBytes, $headerCallback, $dlCallback): void {
+            ->willReturnCallback(function ($url, $timeout, $maxBytes, $headerCallback, $dlCallback): void {
                 $headerCallback();
                 $dlCallback();
             })

tests/http/UrlTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * UrlUtils's tests
  */

tests/http/UrlUtils/CleanupUrlTest.php

@@ -1,12 +1,11 @@
 <?php
+
 /**
  * Unitary tests for cleanup_url()
  */
 
 namespace Shaarli\Http;
 
-require_once 'application/http/UrlUtils.php';
-
 class CleanupUrlTest extends \Shaarli\TestCase
 {
     /**
@@ -29,7 +28,7 @@ public function testCleanupUrlEmpty()
     public function testCleanupUrlAlreadyClean()
     {
         $this->assertEquals($this->ref, cleanup_url($this->ref));
-        $this->ref2 = $this->ref.'/path/to/dir/';
+        $this->ref2 = $this->ref . '/path/to/dir/';
         $this->assertEquals($this->ref2, cleanup_url($this->ref2));
     }
 
@@ -38,9 +37,9 @@ public function testCleanupUrlAlreadyClean()
      */
     public function testCleanupUrlFragment()
     {
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'#tk.rss_all'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '#tk.rss_all'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'#xtor=RSS-'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '#xtor=RSS-'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'#xtor=RSS-U3ht0tkc4b'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '#xtor=RSS-U3ht0tkc4b'));
     }
 
     /**
@@ -48,23 +47,23 @@ public function testCleanupUrlFragment()
      */
     public function testCleanupUrlQuerySingle()
     {
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?action_object_map=junk'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?action_object_map=junk'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?action_ref_map=Cr4p!'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?action_ref_map=Cr4p!'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?action_type_map=g4R84g3'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?action_type_map=g4R84g3'));
 
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?fb_stuff=v41u3'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?fb_stuff=v41u3'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?fb=71m3w4573'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?fb=71m3w4573'));
 
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?utm_campaign=zomg'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?utm_campaign=zomg'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?utm_medium=numnum'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?utm_medium=numnum'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?utm_source=c0d3'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?utm_source=c0d3'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?utm_term=1n4l'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?utm_term=1n4l'));
 
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?xtor=some-url'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?xtor=some-url'));
 
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?campaign_name=junk'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?campaign_name=junk'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?campaign_start=junk'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?campaign_start=junk'));
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?campaign_item_index=junk'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?campaign_item_index=junk'));
     }
 
     /**
@@ -72,14 +71,14 @@ public function testCleanupUrlQuerySingle()
      */
     public function testCleanupUrlQueryMultiple()
     {
-        $this->assertEquals($this->ref, cleanup_url($this->ref.'?xtor=some-url&fb=som3th1ng'));
+        $this->assertEquals($this->ref, cleanup_url($this->ref . '?xtor=some-url&fb=som3th1ng'));
 
         $this->assertEquals($this->ref, cleanup_url(
-            $this->ref.'?fb=stuff&utm_campaign=zomg&utm_medium=numnum&utm_source=c0d3'
+            $this->ref . '?fb=stuff&utm_campaign=zomg&utm_medium=numnum&utm_source=c0d3'
         ));
 
         $this->assertEquals($this->ref, cleanup_url(
-            $this->ref.'?campaign_start=zomg&campaign_name=numnum'
+            $this->ref . '?campaign_start=zomg&campaign_name=numnum'
         ));
     }
 
@@ -89,22 +88,22 @@ public function testCleanupUrlQueryMultiple()
     public function testCleanupUrlQueryFragment()
     {
         $this->assertEquals($this->ref, cleanup_url(
-            $this->ref.'?xtor=some-url&fb=som3th1ng#tk.rss_all'
+            $this->ref . '?xtor=some-url&fb=som3th1ng#tk.rss_all'
         ));
 
         // ditch annoying query params and fragment, keep useful params
         $this->assertEquals(
-            $this->ref.'?my=stuff&is=kept',
+            $this->ref . '?my=stuff&is=kept',
             cleanup_url(
-                $this->ref.'?fb=zomg&my=stuff&utm_medium=numnum&is=kept#tk.rss_all'
+                $this->ref . '?fb=zomg&my=stuff&utm_medium=numnum&is=kept#tk.rss_all'
             )
         );
 
         // ditch annoying query params, keep useful params and fragment
         $this->assertEquals(
-            $this->ref.'?my=stuff&is=kept#again',
+            $this->ref . '?my=stuff&is=kept#again',
             cleanup_url(
-                $this->ref.'?fb=zomg&my=stuff&utm_medium=numnum&is=kept#again'
+                $this->ref . '?fb=zomg&my=stuff&utm_medium=numnum&is=kept#again'
             )
         );
     }

tests/http/UrlUtils/GetUrlSchemeTest.php

@@ -1,13 +1,14 @@
 <?php
+
 /**
  * Unitary tests for get_url_scheme()
  */
 
 namespace Shaarli\Http;
 
-require_once 'application/http/UrlUtils.php';
+use Shaarli\TestCase;
 
-class GetUrlSchemeTest extends \Shaarli\TestCase
+class GetUrlSchemeTest extends TestCase
 {
     /**
      * Get empty scheme string for empty UrlUtils

tests/http/UrlUtils/UnparseUrlTest.php

@@ -1,23 +1,24 @@
 <?php
+
 /**
  * Unpares UrlUtils's tests
  */
 
 namespace Shaarli\Http;
 
-require_once 'application/http/UrlUtils.php';
+use Shaarli\TestCase;
 
 /**
  * Unitary tests for unparse_url()
  */
-class UnparseUrlTest extends \Shaarli\TestCase
+class UnparseUrlTest extends TestCase
 {
     /**
      * Thanks for building nothing
      */
     public function testUnparseEmptyArray()
     {
-        $this->assertEquals('', unparse_url(array()));
+        $this->assertEquals('', unparse_url([]));
     }
 
     /**
@@ -26,7 +27,7 @@ public function testUnparseEmptyArray()
     public function testUnparseFull()
     {
         $ref = 'http://username:password@hostname:9090/path'
-              .'?arg1=value1&arg2=value2#anchor';
+              . '?arg1=value1&arg2=value2#anchor';
         $this->assertEquals($ref, unparse_url(parse_url($ref)));
     }
 }

tests/http/UrlUtils/WhitelistProtocolsTest.php

@@ -2,14 +2,14 @@
 
 namespace Shaarli\Http;
 
-require_once 'application/http/UrlUtils.php';
+use Shaarli\TestCase;
 
 /**
  * Class WhitelistProtocolsTest
  *
  * Test whitelist_protocols() function of UrlUtils.
  */
-class WhitelistProtocolsTest extends \Shaarli\TestCase
+class WhitelistProtocolsTest extends TestCase
 {
     /**
      * Test whitelist_protocols() on a note (relative URL).
@@ -30,7 +30,7 @@ public function testWhitelistProtocolMissing()
     {
         $whitelist = ['ftp', 'magnet'];
         $url = 'test.tld/path/?query=value#hash';
-        $this->assertEquals('http://'. $url, whitelist_protocols($url, $whitelist));
+        $this->assertEquals('http://' . $url, whitelist_protocols($url, $whitelist));
     }
 
     /**

tests/languages/bootstrap.php

@@ -1,4 +1,5 @@
 <?php
+
 require_once 'tests/bootstrap.php';
 
 if (! empty(getenv('UT_LOCALE'))) {

tests/languages/de/UtilsDeTest.php

@@ -1,7 +1,8 @@
 <?php
 
-require_once 'tests/UtilsTest.php';
+namespace Shaarli\Tests;
 
+use DateTime;
 
 class UtilsDeTest extends UtilsTest
 {

tests/languages/en/UtilsEnTest.php

@@ -1,7 +1,8 @@
 <?php
 
-require_once 'tests/UtilsTest.php';
+namespace Shaarli\Tests;
 
+use DateTime;
 
 class UtilsEnTest extends UtilsTest
 {

tests/languages/fr/LanguagesFrTest.php

@@ -1,9 +1,10 @@
 <?php
 
-
+namespace Shaarli\Tests;
-namespace Shaarli;
 
 use Shaarli\Config\ConfigManager;
+use Shaarli\Languages;
+use Shaarli\TestCase;
 
 /**
  * Class LanguagesFrTest
@@ -12,7 +13,7 @@
  *
  * @package Shaarli
  */
-class LanguagesFrTest extends \Shaarli\TestCase
+class LanguagesFrTest extends TestCase
 {
     /**
      * @var string Config file path (without extension).

tests/languages/fr/UtilsFrTest.php

@@ -1,7 +1,8 @@
 <?php
 
-require_once 'tests/UtilsTest.php';
+namespace Shaarli\Tests;
 
+use DateTime;
 
 class UtilsFrTest extends UtilsTest
 {

tests/legacy/LegacyDummyUpdater.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Updater;
 
 use Exception;

tests/legacy/LegacyLinkDBTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Link datastore tests
  */
@@ -6,14 +7,10 @@
 namespace Shaarli\Legacy;
 
 use DateTime;
-use ReferenceLinkDB;
 use ReflectionClass;
 use Shaarli;
 use Shaarli\Bookmark\Bookmark;
-
+use Shaarli\Tests\Utils\ReferenceLinkDB;
-require_once 'application/Utils.php';
-require_once 'tests/utils/ReferenceLinkDB.php';
-
 
 /**
  * Unitary tests for LegacyLinkDBTest
@@ -118,7 +115,7 @@ public function testCheckDBNew()
         $this->assertFileNotExists(self::$testDatastore);
 
         $checkDB = self::getMethod('check');
-        $checkDB->invokeArgs($linkDB, array());
+        $checkDB->invokeArgs($linkDB, []);
         $this->assertFileExists(self::$testDatastore);
 
         // ensure the correct data has been written
@@ -135,7 +132,7 @@ public function testCheckDBLoad()
         $this->assertGreaterThan(0, $datastoreSize);
 
         $checkDB = self::getMethod('check');
-        $checkDB->invokeArgs($linkDB, array());
+        $checkDB->invokeArgs($linkDB, []);
 
         // ensure the datastore is left unmodified
         $this->assertEquals(
@@ -185,7 +182,7 @@ public function testSave()
         $testDB = new LegacyLinkDB(self::$testDatastore, true, false);
         $dbSize = sizeof($testDB);
 
-        $link = array(
+        $link = [
             'id' => 43,
             'title' => 'an additional link',
             'url' => 'http://dum.my',
@@ -193,7 +190,7 @@ public function testSave()
             'private' => 0,
             'created' => DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, '20150518_190000'),
             'tags' => 'unit test'
-        );
+        ];
         $testDB[$link['id']] = $link;
         $testDB->save('tests');
 
@@ -239,12 +236,12 @@ public function testCountHiddenPublic()
     public function testDays()
     {
         $this->assertEquals(
-            array('20100309', '20100310', '20121206', '20121207', '20130614', '20150310'),
+            ['20100309', '20100310', '20121206', '20121207', '20130614', '20150310'],
             self::$publicLinkDB->days()
         );
 
         $this->assertEquals(
-            array('20100309', '20100310', '20121206', '20121207', '20130614', '20141125', '20150310'),
+            ['20100309', '20100310', '20121206', '20121207', '20130614', '20141125', '20150310'],
             self::$privateLinkDB->days()
         );
     }
@@ -280,7 +277,7 @@ public function testGetUnknownLinkFromURL()
     public function testAllTags()
     {
         $this->assertEquals(
-            array(
+            [
                 'web' => 3,
                 'cartoon' => 2,
                 'gnu' => 2,
@@ -300,12 +297,12 @@ public function testAllTags()
                 'coding-style' => 1,
                 'quality' => 1,
                 'standards' => 1,
-            ),
+            ],
             self::$publicLinkDB->linksCountPerTag()
         );
 
         $this->assertEquals(
-            array(
+            [
                 'web' => 4,
                 'cartoon' => 3,
                 'gnu' => 2,
@@ -332,11 +329,11 @@ public function testAllTags()
                 'coding-style' => 1,
                 'quality' => 1,
                 'standards' => 1,
-            ),
+            ],
             self::$privateLinkDB->linksCountPerTag()
         );
         $this->assertEquals(
-            array(
+            [
                 'web' => 4,
                 'cartoon' => 2,
                 'gnu' => 1,
@@ -349,17 +346,17 @@ public function testAllTags()
                 'Mercurial' => 1,
                 '.hidden' => 1,
                 'hashtag' => 1,
-            ),
+            ],
             self::$privateLinkDB->linksCountPerTag(['web'])
         );
         $this->assertEquals(
-            array(
+            [
                 'web' => 1,
                 'html' => 1,
                 'w3c' => 1,
                 'css' => 1,
                 'Mercurial' => 1,
-            ),
+            ],
             self::$privateLinkDB->linksCountPerTag(['web'], 'private')
         );
     }
@@ -370,7 +367,7 @@ public function testAllTags()
     public function testFilterString()
     {
         $tags = 'dev cartoon';
-        $request = array('searchtags' => $tags);
+        $request = ['searchtags' => $tags];
         $this->assertEquals(
             2,
             count(self::$privateLinkDB->filterSearch($request, true, false))
@@ -382,8 +379,8 @@ public function testFilterString()
      */
     public function testFilterArray()
     {
-        $tags = array('dev', 'cartoon');
+        $tags = ['dev', 'cartoon'];
-        $request = array('searchtags' => $tags);
+        $request = ['searchtags' => $tags];
         $this->assertEquals(
             2,
             count(self::$privateLinkDB->filterSearch($request, true, false))
@@ -397,7 +394,7 @@ public function testFilterArray()
     public function testHiddenTags()
     {
         $tags = '.hidden';
-        $request = array('searchtags' => $tags);
+        $request = ['searchtags' => $tags];
         $this->assertEquals(
             1,
             count(self::$privateLinkDB->filterSearch($request, true, false))
@@ -639,7 +636,7 @@ public function testConsistentOrder()
         for ($i = 0; $i < 4; ++$i) {
             $linkDB[$nextId + $i] = [
                 'id' => $nextId + $i,
-                'url' => 'http://'. $i,
+                'url' => 'http://' . $i,
                 'created' => $creation,
                 'title' => true,
                 'description' => true,
@@ -657,7 +654,7 @@ public function testConsistentOrder()
                     continue;
                 }
                 $this->assertEquals($nextId + $count, $link['id']);
-                $this->assertEquals('http://'. $count, $link['url']);
+                $this->assertEquals('http://' . $count, $link['url']);
                 if (--$count < 0) {
                     break;
                 }

tests/legacy/LegacyLinkFilterTest.php

@@ -2,10 +2,9 @@
 
 namespace Shaarli\Bookmark;
 
-use Exception;
-use ReferenceLinkDB;
 use Shaarli\Legacy\LegacyLinkDB;
 use Shaarli\Legacy\LegacyLinkFilter;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 
 /**
  * Class LegacyLinkFilterTest.
@@ -450,28 +449,28 @@ public function testFilterCrossedSearch()
             1,
             count(self::$linkFilter->filter(
                 LegacyLinkFilter::$FILTER_TAG | LegacyLinkFilter::$FILTER_TEXT,
-                array($tags, $terms)
+                [$tags, $terms]
             ))
         );
         $this->assertEquals(
             2,
             count(self::$linkFilter->filter(
                 LegacyLinkFilter::$FILTER_TAG | LegacyLinkFilter::$FILTER_TEXT,
-                array('', $terms)
+                ['', $terms]
             ))
         );
         $this->assertEquals(
             1,
             count(self::$linkFilter->filter(
                 LegacyLinkFilter::$FILTER_TAG | LegacyLinkFilter::$FILTER_TEXT,
-                array(false, 'PSR-2')
+                [false, 'PSR-2']
             ))
         );
         $this->assertEquals(
             1,
             count(self::$linkFilter->filter(
                 LegacyLinkFilter::$FILTER_TAG | LegacyLinkFilter::$FILTER_TEXT,
-                array($tags, '')
+                [$tags, '']
             ))
         );
         $this->assertEquals(

tests/legacy/LegacyUpdaterTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Updater;
 
 use DateTime;
@@ -9,18 +10,16 @@
 use Shaarli\Config\ConfigPhp;
 use Shaarli\Legacy\LegacyLinkDB;
 use Shaarli\Legacy\LegacyUpdater;
+use Shaarli\TestCase;
+use Shaarli\Tests\updater\DummyUpdater;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 use Shaarli\Thumbnailer;
 
-require_once 'application/updater/UpdaterUtils.php';
-require_once 'tests/updater/DummyUpdater.php';
-require_once 'tests/utils/ReferenceLinkDB.php';
-require_once 'inc/rain.tpl.class.php';
-
 /**
  * Class UpdaterTest.
  * Runs unit tests against the updater class.
  */
-class LegacyUpdaterTest extends \Shaarli\TestCase
+class LegacyUpdaterTest extends TestCase
 {
     /**
      * @var string Path to test datastore.
@@ -42,7 +41,7 @@ class LegacyUpdaterTest extends \Shaarli\TestCase
      */
     protected function setUp(): void
     {
-        copy('tests/utils/config/configJson.json.php', self::$configFile .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$configFile . '.json.php');
         $this->conf = new ConfigManager(self::$configFile);
     }
 
@@ -51,10 +50,10 @@ protected function setUp(): void
      */
     public function testReadEmptyUpdatesFile()
     {
-        $this->assertEquals(array(), UpdaterUtils::readUpdatesFile(''));
+        $this->assertEquals([], UpdaterUtils::readUpdatesFile(''));
         $updatesFile = $this->conf->get('resource.data_dir') . '/updates.txt';
         touch($updatesFile);
-        $this->assertEquals(array(), UpdaterUtils::readUpdatesFile($updatesFile));
+        $this->assertEquals([], UpdaterUtils::readUpdatesFile($updatesFile));
         unlink($updatesFile);
     }
 
@@ -64,7 +63,7 @@ public function testReadEmptyUpdatesFile()
     public function testReadWriteUpdatesFile()
     {
         $updatesFile = $this->conf->get('resource.data_dir') . '/updates.txt';
-        $updatesMethods = array('m1', 'm2', 'm3');
+        $updatesMethods = ['m1', 'm2', 'm3'];
 
         UpdaterUtils::writeUpdatesFile($updatesFile, $updatesMethods);
         $readMethods = UpdaterUtils::readUpdatesFile($updatesFile);
@@ -86,7 +85,7 @@ public function testWriteEmptyUpdatesFile()
         $this->expectException(\Exception::class);
         $this->expectExceptionMessageRegExp('/Updates file path is not set(.*)/');
 
-        UpdaterUtils::writeUpdatesFile('', array('test'));
+        UpdaterUtils::writeUpdatesFile('', ['test']);
     }
 
     /**
@@ -101,7 +100,7 @@ public function testWriteUpdatesFileNotWritable()
         touch($updatesFile);
         chmod($updatesFile, 0444);
         try {
-            @UpdaterUtils::writeUpdatesFile($updatesFile, array('test'));
+            @UpdaterUtils::writeUpdatesFile($updatesFile, ['test']);
         } catch (Exception $e) {
             unlink($updatesFile);
             throw $e;
@@ -115,17 +114,17 @@ public function testWriteUpdatesFileNotWritable()
      */
     public function testNoUpdates()
     {
-        $updates = array(
+        $updates = [
             'updateMethodDummy1',
             'updateMethodDummy2',
             'updateMethodDummy3',
             'updateMethodException',
-        );
+        ];
-        $updater = new DummyUpdater($updates, array(), $this->conf, true);
+        $updater = new DummyUpdater($updates, [], $this->conf, true);
-        $this->assertEquals(array(), $updater->update());
+        $this->assertEquals([], $updater->update());
 
-        $updater = new DummyUpdater(array(), array(), $this->conf, false);
+        $updater = new DummyUpdater([], [], $this->conf, false);
-        $this->assertEquals(array(), $updater->update());
+        $this->assertEquals([], $updater->update());
     }
 
     /**
@@ -133,13 +132,13 @@ public function testNoUpdates()
      */
     public function testUpdatesFirstTime()
     {
-        $updates = array('updateMethodException',);
+        $updates = ['updateMethodException',];
-        $expectedUpdates = array(
+        $expectedUpdates = [
             'updateMethodDummy1',
             'updateMethodDummy2',
             'updateMethodDummy3',
-        );
+        ];
-        $updater = new DummyUpdater($updates, array(), $this->conf, true);
+        $updater = new DummyUpdater($updates, [], $this->conf, true);
         $this->assertEquals($expectedUpdates, $updater->update());
     }
 
@@ -148,14 +147,14 @@ public function testUpdatesFirstTime()
      */
     public function testOneUpdate()
     {
-        $updates = array(
+        $updates = [
             'updateMethodDummy1',
             'updateMethodDummy3',
             'updateMethodException',
-        );
+        ];
-        $expectedUpdate = array('updateMethodDummy2');
+        $expectedUpdate = ['updateMethodDummy2'];
 
-        $updater = new DummyUpdater($updates, array(), $this->conf, true);
+        $updater = new DummyUpdater($updates, [], $this->conf, true);
         $this->assertEquals($expectedUpdate, $updater->update());
     }
 
@@ -166,13 +165,13 @@ public function testUpdateFailed()
     {
         $this->expectException(\Exception::class);
 
-        $updates = array(
+        $updates = [
             'updateMethodDummy1',
             'updateMethodDummy2',
             'updateMethodDummy3',
-        );
+        ];
 
-        $updater = new DummyUpdater($updates, array(), $this->conf, true);
+        $updater = new DummyUpdater($updates, [], $this->conf, true);
         $updater->update();
     }
 
@@ -197,7 +196,7 @@ public function testUpdateMergeDeprecatedConfig()
         $this->conf->setConfigFile('tests/updater/config');
 
         // merge configs
-        $updater = new LegacyUpdater(array(), array(), $this->conf, true);
+        $updater = new LegacyUpdater([], [], $this->conf, true);
         // This writes a new config file in tests/updater/config.php
         $updater->updateMethodMergeDeprecatedConfigFile();
 
@@ -214,7 +213,7 @@ public function testUpdateMergeDeprecatedConfig()
      */
     public function testMergeDeprecatedConfigNoFile()
     {
-        $updater = new LegacyUpdater(array(), array(), $this->conf, true);
+        $updater = new LegacyUpdater([], [], $this->conf, true);
         $updater->updateMethodMergeDeprecatedConfigFile();
 
         $this->assertEquals('root', $this->conf->get('credentials.login'));
@@ -225,14 +224,14 @@ public function testMergeDeprecatedConfigNoFile()
      */
     public function testRenameDashTags()
     {
-        $refDB = new \ReferenceLinkDB(true);
+        $refDB = new ReferenceLinkDB(true);
         $refDB->write(self::$testDatastore);
         $linkDB = new LegacyLinkDB(self::$testDatastore, true, false);
 
-        $this->assertEmpty($linkDB->filterSearch(array('searchtags' => 'exclude')));
+        $this->assertEmpty($linkDB->filterSearch(['searchtags' => 'exclude']));
-        $updater = new LegacyUpdater(array(), $linkDB, $this->conf, true);
+        $updater = new LegacyUpdater([], $linkDB, $this->conf, true);
         $updater->updateMethodRenameDashTags();
-        $this->assertNotEmpty($linkDB->filterSearch(array('searchtags' =>  'exclude')));
+        $this->assertNotEmpty($linkDB->filterSearch(['searchtags' =>  'exclude']));
     }
 
     /**
@@ -247,7 +246,7 @@ public function testConfigToJson()
         // The ConfigIO is initialized with ConfigPhp.
         $this->assertTrue($this->conf->getConfigIO() instanceof ConfigPhp);
 
-        $updater = new LegacyUpdater(array(), array(), $this->conf, false);
+        $updater = new LegacyUpdater([], [], $this->conf, false);
         $done = $updater->updateMethodConfigToJson();
         $this->assertTrue($done);
 
@@ -272,7 +271,7 @@ public function testConfigToJson()
     public function testConfigToJsonNothingToDo()
     {
         $filetime = filemtime($this->conf->getConfigFileExt());
-        $updater = new LegacyUpdater(array(), array(), $this->conf, false);
+        $updater = new LegacyUpdater([], [], $this->conf, false);
         $done = $updater->updateMethodConfigToJson();
         $this->assertTrue($done);
         $expected = filemtime($this->conf->getConfigFileExt());
@@ -291,7 +290,7 @@ public function testEscapeConfig()
         $headerLink = '<script>alert("header_link");</script>';
         $this->conf->set('general.title', $title);
         $this->conf->set('general.header_link', $headerLink);
-        $updater = new LegacyUpdater(array(), array(), $this->conf, true);
+        $updater = new LegacyUpdater([], [], $this->conf, true);
         $done = $updater->updateMethodEscapeUnescapedConfig();
         $this->assertTrue($done);
         $this->conf->reload();
@@ -306,9 +305,9 @@ public function testEscapeConfig()
     public function testUpdateApiSettings()
     {
         $confFile = 'sandbox/config';
-        copy(self::$configFile .'.json.php', $confFile .'.json.php');
+        copy(self::$configFile . '.json.php', $confFile . '.json.php');
         $conf = new ConfigManager($confFile);
-        $updater = new LegacyUpdater(array(), array(), $conf, true);
+        $updater = new LegacyUpdater([], [], $conf, true);
 
         $this->assertFalse($conf->exists('api.enabled'));
         $this->assertFalse($conf->exists('api.secret'));
@@ -316,7 +315,7 @@ public function testUpdateApiSettings()
         $conf->reload();
         $this->assertTrue($conf->get('api.enabled'));
         $this->assertTrue($conf->exists('api.secret'));
-        unlink($confFile .'.json.php');
+        unlink($confFile . '.json.php');
     }
 
     /**
@@ -325,15 +324,15 @@ public function testUpdateApiSettings()
     public function testUpdateApiSettingsNothingToDo()
     {
         $confFile = 'sandbox/config';
-        copy(self::$configFile .'.json.php', $confFile .'.json.php');
+        copy(self::$configFile . '.json.php', $confFile . '.json.php');
         $conf = new ConfigManager($confFile);
         $conf->set('api.enabled', false);
         $conf->set('api.secret', '');
-        $updater = new LegacyUpdater(array(), array(), $conf, true);
+        $updater = new LegacyUpdater([], [], $conf, true);
         $updater->updateMethodApiSettings();
         $this->assertFalse($conf->get('api.enabled'));
         $this->assertEmpty($conf->get('api.secret'));
-        unlink($confFile .'.json.php');
+        unlink($confFile . '.json.php');
     }
 
     /**
@@ -341,8 +340,8 @@ public function testUpdateApiSettingsNothingToDo()
      */
     public function testDatastoreIds()
     {
-        $links = array(
+        $links = [
-            '20121206_182539' => array(
+            '20121206_182539' => [
                 'linkdate' => '20121206_182539',
                 'title' => 'Geek and Poke',
                 'url' => 'http://geek-and-poke.com/',
@@ -350,25 +349,25 @@ public function testDatastoreIds()
                 'tags' => 'dev cartoon tag1  tag2   tag3  tag4   ',
                 'updated' => '20121206_190301',
                 'private' => false,
-            ),
+            ],
-            '20121206_172539' => array(
+            '20121206_172539' => [
                 'linkdate' => '20121206_172539',
                 'title' => 'UserFriendly - Samba',
                 'url' => 'http://ars.userfriendly.org/cartoons/?id=20010306',
                 'description' => '',
                 'tags' => 'samba cartoon web',
                 'private' => false,
-            ),
+            ],
-            '20121206_142300' => array(
+            '20121206_142300' => [
                 'linkdate' => '20121206_142300',
                 'title' => 'UserFriendly - Web Designer',
                 'url' => 'http://ars.userfriendly.org/cartoons/?id=20121206',
                 'description' => 'Naming conventions... #private',
                 'tags' => 'samba cartoon web',
                 'private' => true,
-            ),
+            ],
-        );
+        ];
-        $refDB = new \ReferenceLinkDB(true);
+        $refDB = new ReferenceLinkDB(true);
         $refDB->setLinks($links);
         $refDB->write(self::$testDatastore);
         $linkDB = new LegacyLinkDB(self::$testDatastore, true, false);
@@ -378,12 +377,12 @@ public function testDatastoreIds()
         $this->conf->set('resource.data_dir', 'sandbox');
         $this->conf->set('resource.datastore', self::$testDatastore);
 
-        $updater = new LegacyUpdater(array(), $linkDB, $this->conf, true);
+        $updater = new LegacyUpdater([], $linkDB, $this->conf, true);
         $this->assertTrue($updater->updateMethodDatastoreIds());
 
         $linkDB = new LegacyLinkDB(self::$testDatastore, true, false);
 
-        $backupFiles = glob($this->conf->get('resource.data_dir') . '/datastore.'. date('YmdH') .'*.php');
+        $backupFiles = glob($this->conf->get('resource.data_dir') . '/datastore.' . date('YmdH') . '*.php');
         $backup = null;
         foreach ($backupFiles as $backupFile) {
             if (strpos($backupFile, '_1') === false) {
@@ -437,7 +436,7 @@ public function testDatastoreIds()
      */
     public function testDatastoreIdsNothingToDo()
     {
-        $refDB = new \ReferenceLinkDB(true);
+        $refDB = new ReferenceLinkDB(true);
         $refDB->write(self::$testDatastore);
         $linkDB = new LegacyLinkDB(self::$testDatastore, true, false);
 
@@ -445,7 +444,7 @@ public function testDatastoreIdsNothingToDo()
         $this->conf->set('resource.datastore', self::$testDatastore);
 
         $checksum = hash_file('sha1', self::$testDatastore);
-        $updater = new LegacyUpdater(array(), $linkDB, $this->conf, true);
+        $updater = new LegacyUpdater([], $linkDB, $this->conf, true);
         $this->assertTrue($updater->updateMethodDatastoreIds());
         $this->assertEquals($checksum, hash_file('sha1', self::$testDatastore));
     }
@@ -478,9 +477,9 @@ public function testDefaultThemeWithCustomTheme()
         $sandbox = 'sandbox/config';
         copy(self::$configFile . '.json.php', $sandbox . '.json.php');
         $this->conf = new ConfigManager($sandbox);
-        mkdir('sandbox/'. $theme);
+        mkdir('sandbox/' . $theme);
-        touch('sandbox/'. $theme .'/linklist.html');
+        touch('sandbox/' . $theme . '/linklist.html');
-        $this->conf->set('resource.raintpl_tpl', 'sandbox/'. $theme .'/');
+        $this->conf->set('resource.raintpl_tpl', 'sandbox/' . $theme . '/');
         $updater = new LegacyUpdater([], [], $this->conf, true);
         $this->assertTrue($updater->updateMethodDefaultTheme());
 
@@ -490,8 +489,8 @@ public function testDefaultThemeWithCustomTheme()
         $this->assertEquals('sandbox', $this->conf->get('resource.raintpl_tpl'));
         $this->assertEquals($theme, $this->conf->get('resource.theme'));
         unlink($sandbox . '.json.php');
-        unlink('sandbox/'. $theme .'/linklist.html');
+        unlink('sandbox/' . $theme . '/linklist.html');
-        rmdir('sandbox/'. $theme);
+        rmdir('sandbox/' . $theme);
     }
 
     /**
@@ -572,11 +571,11 @@ public function testUpdatePiwikUrlValid()
         $this->conf->set('plugins.PIWIK_URL', $url);
         $updater = new LegacyUpdater([], [], $this->conf, true);
         $this->assertTrue($updater->updateMethodPiwikUrl());
-        $this->assertEquals('http://'. $url, $this->conf->get('plugins.PIWIK_URL'));
+        $this->assertEquals('http://' . $url, $this->conf->get('plugins.PIWIK_URL'));
 
         // reload from file
         $this->conf = new ConfigManager($sandboxConf);
-        $this->assertEquals('http://'. $url, $this->conf->get('plugins.PIWIK_URL'));
+        $this->assertEquals('http://' . $url, $this->conf->get('plugins.PIWIK_URL'));
     }
 
     /**
@@ -781,12 +780,12 @@ public function testUpdateStickyValid()
             1 => ['id' => 1] + $blank,
             2 => ['id' => 2] + $blank,
         ];
-        $refDB = new \ReferenceLinkDB(true);
+        $refDB = new ReferenceLinkDB(true);
         $refDB->setLinks($links);
         $refDB->write(self::$testDatastore);
         $linkDB = new LegacyLinkDB(self::$testDatastore, true, false);
 
-        $updater = new LegacyUpdater(array(), $linkDB, $this->conf, true);
+        $updater = new LegacyUpdater([], $linkDB, $this->conf, true);
         $this->assertTrue($updater->updateMethodSetSticky());
 
         $linkDB = new LegacyLinkDB(self::$testDatastore, true, false);
@@ -812,12 +811,12 @@ public function testUpdateStickyNothingToDo()
             1 => ['id' => 1, 'sticky' => true] + $blank,
             2 => ['id' => 2] + $blank,
         ];
-        $refDB = new \ReferenceLinkDB(true);
+        $refDB = new ReferenceLinkDB(true);
         $refDB->setLinks($links);
         $refDB->write(self::$testDatastore);
         $linkDB = new LegacyLinkDB(self::$testDatastore, true, false);
 
-        $updater = new LegacyUpdater(array(), $linkDB, $this->conf, true);
+        $updater = new LegacyUpdater([], $linkDB, $this->conf, true);
         $this->assertTrue($updater->updateMethodSetSticky());
 
         $linkDB = new LegacyLinkDB(self::$testDatastore, true, false);

tests/netscape/BookmarkExportTest.php

@@ -10,8 +10,7 @@
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
-
+use Shaarli\Tests\Utils\ReferenceLinkDB;
-require_once 'tests/utils/ReferenceLinkDB.php';
 
 /**
  * Netscape bookmark export
@@ -29,7 +28,7 @@ class BookmarkExportTest extends TestCase
     protected static $conf;
 
     /**
-     * @var \ReferenceLinkDB instance.
+     * @var ReferenceLinkDB instance.
      */
     protected static $refDb = null;
 
@@ -64,7 +63,7 @@ public static function setUpBeforeClass(): void
         $mutex = new NoMutex();
         static::$conf = new ConfigManager('tests/utils/config/configJson');
         static::$conf->set('resource.datastore', static::$testDatastore);
-        static::$refDb = new \ReferenceLinkDB();
+        static::$refDb = new ReferenceLinkDB();
         static::$refDb->write(static::$testDatastore);
         static::$history = new History('sandbox/history.php');
         static::$pluginManager = new PluginManager(static::$conf);

tests/netscape/BookmarkImportTest.php

@@ -135,7 +135,7 @@ public function testImportEmptyData()
         $files = file2array('empty.htm');
         $this->assertEquals(
             'File empty.htm (0 bytes) has an unknown file format.'
-            .' Nothing was imported.',
+            . ' Nothing was imported.',
             $this->netscapeBookmarkUtils->import(null, $files)
         );
         $this->assertEquals(0, $this->bookmarkService->count());
@@ -162,7 +162,7 @@ public function testImportLowecaseDoctype()
         $files = file2array('lowercase_doctype.htm');
         $this->assertStringMatchesFormat(
             'File lowercase_doctype.htm (386 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import(null, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -177,7 +177,7 @@ public function testImportInternetExplorerEncoding()
         $files = file2array('internet_explorer_encoding.htm');
         $this->assertStringMatchesFormat(
             'File internet_explorer_encoding.htm (356 bytes) was successfully processed in %d seconds:'
-            .' 1 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 1 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import([], $files)
         );
         $this->assertEquals(1, $this->bookmarkService->count());
@@ -205,7 +205,7 @@ public function testImportNested()
         $files = file2array('netscape_nested.htm');
         $this->assertStringMatchesFormat(
             'File netscape_nested.htm (1337 bytes) was successfully processed in %d seconds:'
-            .' 8 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 8 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import([], $files)
         );
         $this->assertEquals(8, $this->bookmarkService->count());
@@ -326,7 +326,7 @@ public function testImportDefaultPrivacyNoPost()
         $files = file2array('netscape_basic.htm');
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import([], $files)
         );
 
@@ -365,11 +365,11 @@ public function testImportDefaultPrivacyNoPost()
      */
     public function testImportKeepPrivacy()
     {
-        $post = array('privacy' => 'default');
+        $post = ['privacy' => 'default'];
         $files = file2array('netscape_basic.htm');
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
 
@@ -408,11 +408,11 @@ public function testImportKeepPrivacy()
      */
     public function testImportAsPublic()
     {
-        $post = array('privacy' => 'public');
+        $post = ['privacy' => 'public'];
         $files = file2array('netscape_basic.htm');
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -426,11 +426,11 @@ public function testImportAsPublic()
      */
     public function testImportAsPrivate()
     {
-        $post = array('privacy' => 'private');
+        $post = ['privacy' => 'private'];
         $files = file2array('netscape_basic.htm');
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -447,10 +447,10 @@ public function testOverwriteAsPublic()
         $files = file2array('netscape_basic.htm');
 
         // import bookmarks as private
-        $post = array('privacy' => 'private');
+        $post = ['privacy' => 'private'];
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -459,13 +459,13 @@ public function testOverwriteAsPublic()
         $this->assertTrue($this->bookmarkService->get(1)->isPrivate());
 
         // re-import as public, enable overwriting
-        $post = array(
+        $post = [
             'privacy' => 'public',
             'overwrite' => 'true'
-        );
+        ];
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 2 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 2 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -482,10 +482,10 @@ public function testOverwriteAsPrivate()
         $files = file2array('netscape_basic.htm');
 
         // import bookmarks as public
-        $post = array('privacy' => 'public');
+        $post = ['privacy' => 'public'];
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -494,13 +494,13 @@ public function testOverwriteAsPrivate()
         $this->assertFalse($this->bookmarkService->get(1)->isPrivate());
 
         // re-import as private, enable overwriting
-        $post = array(
+        $post = [
             'privacy' => 'private',
             'overwrite' => 'true'
-        );
+        ];
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 2 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 2 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -514,21 +514,21 @@ public function testOverwriteAsPrivate()
      */
     public function testSkipOverwrite()
     {
-        $post = array('privacy' => 'public');
+        $post = ['privacy' => 'public'];
         $files = file2array('netscape_basic.htm');
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
         $this->assertEquals(0, $this->bookmarkService->count(BookmarkFilter::$PRIVATE));
 
         // re-import as private, DO NOT enable overwriting
-        $post = array('privacy' => 'private');
+        $post = ['privacy' => 'private'];
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 0 bookmarks imported, 0 bookmarks overwritten, 2 bookmarks skipped.',
+            . ' 0 bookmarks imported, 0 bookmarks overwritten, 2 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -540,14 +540,14 @@ public function testSkipOverwrite()
      */
     public function testSetDefaultTags()
     {
-        $post = array(
+        $post = [
             'privacy' => 'public',
             'default_tags' => 'tag1 tag2 tag3'
-        );
+        ];
         $files = file2array('netscape_basic.htm');
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -561,14 +561,14 @@ public function testSetDefaultTags()
      */
     public function testSanitizeDefaultTags()
     {
-        $post = array(
+        $post = [
             'privacy' => 'public',
             'default_tags' => 'tag1& tag2 "tag3"'
-        );
+        ];
         $files = file2array('netscape_basic.htm');
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -597,7 +597,7 @@ public function testSetDefaultTagsWithCustomSeparator()
         $files = file2array('netscape_basic.htm');
         $this->assertStringMatchesFormat(
             'File netscape_basic.htm (482 bytes) was successfully processed in %d seconds:'
-            .' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 2 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
             $this->netscapeBookmarkUtils->import($post, $files)
         );
         $this->assertEquals(2, $this->bookmarkService->count());
@@ -630,8 +630,8 @@ public function testImportSameDate()
         $files = file2array('same_date.htm');
         $this->assertStringMatchesFormat(
             'File same_date.htm (453 bytes) was successfully processed in %d seconds:'
-            .' 3 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
+            . ' 3 bookmarks imported, 0 bookmarks overwritten, 0 bookmarks skipped.',
-            $this->netscapeBookmarkUtils->import(array(), $files)
+            $this->netscapeBookmarkUtils->import([], $files)
         );
         $this->assertEquals(3, $this->bookmarkService->count());
         $this->assertEquals(0, $this->bookmarkService->count(BookmarkFilter::$PRIVATE));

tests/plugins/PluginAddlinkTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Plugin\Addlink;
 
 use Shaarli\Plugin\PluginManager;
@@ -25,7 +26,7 @@ protected function setUp(): void
     public function testAddlinkHeaderLoggedIn()
     {
         $str = 'stuff';
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = TemplatePage::LINKLIST;
         $data['_LOGGEDIN_'] = true;
         $data['_BASE_PATH_'] = '/subfolder';
@@ -34,7 +35,7 @@ public function testAddlinkHeaderLoggedIn()
         $this->assertEquals($str, $data[$str]);
         $this->assertEquals(1, count($data['fields_toolbar']));
 
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = $str;
         $data['_LOGGEDIN_'] = true;
         $data['_BASE_PATH_'] = '/subfolder';
@@ -50,7 +51,7 @@ public function testAddlinkHeaderLoggedIn()
     public function testAddlinkHeaderLoggedOut()
     {
         $str = 'stuff';
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = TemplatePage::LINKLIST;
         $data['_LOGGEDIN_'] = false;
         $data['_BASE_PATH_'] = '/subfolder';

tests/plugins/PluginArchiveorgTest.php

@@ -2,10 +2,6 @@
 
 namespace Shaarli\Plugin\Archiveorg;
 
-/**
- * PluginArchiveorgTest.php
- */
-
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
 
@@ -47,16 +43,16 @@ public function testArchiveorgLinklistOnExternalLinks(): void
     {
         $str = 'http://randomstr.com/test';
 
-        $data = array(
+        $data = [
             'title' => $str,
-            'links' => array(
+            'links' => [
-                array(
+                [
                     'url' => $str,
                     'private' => 0,
                     'real_url' => $str
-                )
+                ]
-            )
+            ]
-        );
+        ];
 
         $data = hook_archiveorg_render_linklist($data);
 
@@ -84,41 +80,41 @@ public function testArchiveorgLinklistOnInternalLinks(): void
         $internalLink3 = 'http://shaarli.shaarli/shaare/z7u-_Q';
         $internalLinkRealURL3 = '/shaare/z7u-_Q';
 
-        $data = array(
+        $data = [
             'title' => $internalLink1,
-            'links' => array(
+            'links' => [
-                array(
+                [
                     'url' => $internalLink1,
                     'private' => 0,
                     'real_url' => $internalLinkRealURL1
-                ),
+                ],
-                array(
+                [
                     'url' => $internalLink1,
                     'private' => 1,
                     'real_url' => $internalLinkRealURL1
-                ),
+                ],
-                array(
+                [
                     'url' => $internalLink2,
                     'private' => 0,
                     'real_url' => $internalLinkRealURL2
-                ),
+                ],
-                array(
+                [
                     'url' => $internalLink2,
                     'private' => 1,
                     'real_url' => $internalLinkRealURL2
-                ),
+                ],
-                array(
+                [
                     'url' => $internalLink3,
                     'private' => 0,
                     'real_url' => $internalLinkRealURL3
-                ),
+                ],
-                array(
+                [
                     'url' => $internalLink3,
                     'private' => 1,
                     'real_url' => $internalLinkRealURL3
-                )
+                ]
-            )
+            ]
-        );
+        ];
 
         $data = hook_archiveorg_render_linklist($data);
 

tests/plugins/PluginIssoTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Plugin\Isso;
 
 use DateTime;
@@ -55,16 +56,16 @@ public function testIssoDisplayed(): void
 
         $str = 'http://randomstr.com/test';
         $date = '20161118_100001';
-        $data = array(
+        $data = [
             'title' => $str,
-            'links' => array(
+            'links' => [
-                array(
+                [
                     'id' => 12,
                     'url' => $str,
                     'created' => DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, $date),
-                )
+                ]
-            )
+            ]
-        );
+        ];
 
         $data = hook_isso_render_linklist($data, $conf);
 
@@ -76,11 +77,11 @@ public function testIssoDisplayed(): void
         $this->assertEquals(1, count($data['plugin_end_zone']));
         $this->assertNotFalse(strpos(
             $data['plugin_end_zone'][0],
-            'data-isso-id="'. $data['links'][0]['id'] .'"'
+            'data-isso-id="' . $data['links'][0]['id'] . '"'
         ));
         $this->assertNotFalse(strpos(
             $data['plugin_end_zone'][0],
-            'data-title="'. $data['links'][0]['id'] .'"'
+            'data-title="' . $data['links'][0]['id'] . '"'
         ));
         $this->assertNotFalse(strpos($data['plugin_end_zone'][0], 'embed.min.js'));
     }
@@ -96,28 +97,34 @@ public function testIssoMultipleLinks(): void
         $str = 'http://randomstr.com/test';
         $date1 = '20161118_100001';
         $date2 = '20161118_100002';
-        $data = array(
+        $data = [
             'title' => $str,
-            'links' => array(
+            'links' => [
-                array(
+                [
                     'id' => 12,
                     'url' => $str,
                     'shorturl' => $short1 = 'abcd',
                     'created' => DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, $date1),
-                ),
+                ],
-                array(
+                [
                     'id' => 13,
                     'url' => $str . '2',
                     'shorturl' => $short2 = 'efgh',
                     'created' => DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, $date2),
-                ),
+                ],
-            )
+            ]
-        );
+        ];
 
         $processed = hook_isso_render_linklist($data, $conf);
         // link_plugin should be added for the icon
-        $this->assertContainsPolyfill('<a href="/shaare/'. $short1 .'#isso-thread">', $processed['links'][0]['link_plugin'][0]);
+        $this->assertContainsPolyfill(
-        $this->assertContainsPolyfill('<a href="/shaare/'. $short2 .'#isso-thread">', $processed['links'][1]['link_plugin'][0]);
+            '<a href="/shaare/' . $short1 . '#isso-thread">',
+            $processed['links'][0]['link_plugin'][0]
+        );
+        $this->assertContainsPolyfill(
+            '<a href="/shaare/' . $short2 . '#isso-thread">',
+            $processed['links'][1]['link_plugin'][0]
+        );
     }
 
     /**
@@ -130,23 +137,26 @@ public function testIssoNotDisplayedWhenSearch(): void
 
         $str = 'http://randomstr.com/test';
         $date = '20161118_100001';
-        $data = array(
+        $data = [
             'title' => $str,
-            'links' => array(
+            'links' => [
-                array(
+                [
                     'id' => 12,
                     'url' => $str,
                     'shorturl' => $short1 = 'abcd',
                     'created' => DateTime::createFromFormat(Bookmark::LINK_DATE_FORMAT, $date),
-                )
+                ]
-            ),
+            ],
             'search_term' => $str
-        );
+        ];
 
         $processed = hook_isso_render_linklist($data, $conf);
 
         // link_plugin should be added for the icon
-        $this->assertContainsPolyfill('<a href="/shaare/'. $short1 .'#isso-thread">', $processed['links'][0]['link_plugin'][0]);
+        $this->assertContainsPolyfill(
+            '<a href="/shaare/' . $short1 . '#isso-thread">',
+            $processed['links'][0]['link_plugin'][0]
+        );
     }
 
     /**

tests/plugins/PluginPlayvideosTest.php

@@ -1,9 +1,6 @@
 <?php
-namespace Shaarli\Plugin\Playvideos;
 
-/**
+namespace Shaarli\Plugin\Playvideos;
- * PluginPlayvideosTest.php
- */
 
 use Shaarli\Plugin\PluginManager;
 use Shaarli\Render\TemplatePage;
@@ -30,14 +27,14 @@ protected function setUp(): void
     public function testPlayvideosHeader()
     {
         $str = 'stuff';
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = TemplatePage::LINKLIST;
 
         $data = hook_playvideos_render_header($data);
         $this->assertEquals($str, $data[$str]);
         $this->assertEquals(1, count($data['buttons_toolbar']));
 
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = $str;
         $this->assertEquals($str, $data[$str]);
         $this->assertArrayNotHasKey('buttons_toolbar', $data);
@@ -49,14 +46,14 @@ public function testPlayvideosHeader()
     public function testPlayvideosFooter()
     {
         $str = 'stuff';
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = TemplatePage::LINKLIST;
 
         $data = hook_playvideos_render_footer($data);
         $this->assertEquals($str, $data[$str]);
         $this->assertEquals(2, count($data['js_files']));
 
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = $str;
         $this->assertEquals($str, $data[$str]);
         $this->assertArrayNotHasKey('js_files', $data);

tests/plugins/PluginPubsubhubbubTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Plugin\Pubsubhubbub;
 
 use Shaarli\Config\ConfigManager;
@@ -37,7 +38,7 @@ public function testPubSubRssRenderFeed()
         $data['_PAGE_'] = TemplatePage::FEED_RSS;
 
         $data = hook_pubsubhubbub_render_feed($data, $conf);
-        $expected = '<atom:link rel="hub" href="'. $hub .'" />';
+        $expected = '<atom:link rel="hub" href="' . $hub . '" />';
         $this->assertEquals($expected, $data['feed_plugins_header'][0]);
     }
 
@@ -52,7 +53,7 @@ public function testPubSubAtomRenderFeed()
         $data['_PAGE_'] = TemplatePage::FEED_ATOM;
 
         $data = hook_pubsubhubbub_render_feed($data, $conf);
-        $expected = '<link rel="hub" href="'. $hub .'" />';
+        $expected = '<link rel="hub" href="' . $hub . '" />';
         $this->assertEquals($expected, $data['feed_plugins_header'][0]);
     }
 }

tests/plugins/PluginQrcodeTest.php

@@ -1,9 +1,6 @@
 <?php
-namespace Shaarli\Plugin\Qrcode;
 
-/**
+namespace Shaarli\Plugin\Qrcode;
- * PluginQrcodeTest.php
- */
 
 use Shaarli\Plugin\PluginManager;
 use Shaarli\Render\TemplatePage;
@@ -30,14 +27,14 @@ protected function setUp(): void
     public function testQrcodeLinklist()
     {
         $str = 'http://randomstr.com/test';
-        $data = array(
+        $data = [
             'title' => $str,
-            'links' => array(
+            'links' => [
-                array(
+                [
                     'url' => $str,
-                )
+                ]
-            )
+            ]
-        );
+        ];
 
         $data = hook_qrcode_render_linklist($data);
         $link = $data['links'][0];
@@ -56,14 +53,14 @@ public function testQrcodeLinklist()
     public function testQrcodeFooter()
     {
         $str = 'stuff';
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = TemplatePage::LINKLIST;
 
         $data = hook_qrcode_render_footer($data);
         $this->assertEquals($str, $data[$str]);
         $this->assertEquals(1, count($data['js_files']));
 
-        $data = array($str => $str);
+        $data = [$str => $str];
         $data['_PAGE_'] = $str;
         $this->assertEquals($str, $data[$str]);
         $this->assertArrayNotHasKey('js_files', $data);

tests/plugins/PluginWallabagTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Plugin\Wallabag;
 
 use Shaarli\Config\ConfigManager;

tests/plugins/WallabagInstanceTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Plugin\Wallabag;
 
 /**

tests/render/PageCacheManagerTest.php

@@ -18,7 +18,7 @@ class PageCacheManagerTest extends TestCase
     protected static $testCacheDir = 'sandbox/dummycache';
 
     // dummy cached file names / content
-    protected static $pages = array('a', 'toto', 'd7b59c');
+    protected static $pages = ['a', 'toto', 'd7b59c'];
 
     /** @var PageCacheManager */
     protected $cacheManager;

tests/render/ThemeUtilsTest.php

@@ -16,7 +16,7 @@ public function testGetThemes()
     {
         $themes = ['theme1', 'default', 'Bl1p_- bL0p'];
         foreach ($themes as $theme) {
-            mkdir('sandbox/tpl/'. $theme, 0755, true);
+            mkdir('sandbox/tpl/' . $theme, 0755, true);
         }
 
         // include a file which should be ignored
@@ -29,7 +29,7 @@ public function testGetThemes()
         $this->assertFalse(in_array('supertheme', $res));
 
         foreach ($themes as $theme) {
-            rmdir('sandbox/tpl/'. $theme);
+            rmdir('sandbox/tpl/' . $theme);
         }
         unlink('sandbox/tpl/supertheme');
         rmdir('sandbox/tpl');

tests/security/BanManagerTest.php

@@ -1,6 +1,5 @@
 <?php
 
-
 namespace Shaarli\Security;
 
 use Psr\Log\LoggerInterface;

tests/security/LoginManagerTest.php

@@ -349,7 +349,11 @@ public function testCheckCredentialsFromLdapWrongLoginAndPassword()
     {
         $this->configManager->set('ldap.host', 'dummy');
         $this->assertFalse(
-            $this->loginManager->checkCredentialsFromLdap($this->login, $this->password, function() { return null; }, function() { return false; })
+            $this->loginManager->checkCredentialsFromLdap($this->login, $this->password, function () {
+                return null;
+            }, function () {
+                return false;
+            })
         );
     }
 
@@ -360,7 +364,11 @@ public function testCheckCredentialsFromLdapGoodLoginAndPassword()
     {
         $this->configManager->set('ldap.host', 'dummy');
         $this->assertTrue(
-            $this->loginManager->checkCredentialsFromLdap($this->login, $this->password, function() { return null; }, function() { return true; })
+            $this->loginManager->checkCredentialsFromLdap($this->login, $this->password, function () {
+                return null;
+            }, function () {
+                return true;
+            })
         );
     }
 }

tests/security/SessionManagerTest.php

@@ -4,6 +4,7 @@
 
 use Shaarli\FakeConfigManager;
 use Shaarli\TestCase;
+use Shaarli\Tests\Utils\ReferenceSessionIdHashes;
 
 /**
  * Test coverage for SessionManager
@@ -27,7 +28,7 @@ class SessionManagerTest extends TestCase
      */
     public static function setUpBeforeClass(): void
     {
-        self::$sidHashes = \ReferenceSessionIdHashes::getHashes();
+        self::$sidHashes = ReferenceSessionIdHashes::getHashes();
     }
 
     /**

tests/updater/DummyUpdater.php

@@ -1,5 +1,6 @@
 <?php
-namespace Shaarli\Updater;
+
+namespace Shaarli\Tests\updater;
 
 use Exception;
 use ReflectionClass;
@@ -7,6 +8,7 @@
 use Shaarli\Bookmark\BookmarkFileService;
 use Shaarli\Bookmark\LinkDB;
 use Shaarli\Config\ConfigManager;
+use Shaarli\Updater\Updater;
 
 /**
  * Class DummyUpdater.

tests/updater/UpdaterTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Shaarli\Updater;
 
 use Exception;
@@ -9,7 +10,8 @@
 use Shaarli\History;
 use Shaarli\Plugin\PluginManager;
 use Shaarli\TestCase;
-
+use Shaarli\Tests\updater\DummyUpdater;
+use Shaarli\Tests\Utils\ReferenceLinkDB;
 
 /**
  * Class UpdaterTest.
@@ -35,7 +37,7 @@ class UpdaterTest extends TestCase
     /** @var BookmarkServiceInterface */
     protected $bookmarkService;
 
-    /** @var \ReferenceLinkDB */
+    /** @var ReferenceLinkDB */
     protected $refDB;
 
     /** @var Updater */
@@ -47,10 +49,10 @@ class UpdaterTest extends TestCase
     protected function setUp(): void
     {
         $mutex = new NoMutex();
-        $this->refDB = new \ReferenceLinkDB();
+        $this->refDB = new ReferenceLinkDB();
         $this->refDB->write(self::$testDatastore);
 
-        copy('tests/utils/config/configJson.json.php', self::$configFile .'.json.php');
+        copy('tests/utils/config/configJson.json.php', self::$configFile . '.json.php');
         $this->conf = new ConfigManager(self::$configFile);
         $this->bookmarkService = new BookmarkFileService(
             $this->conf,
@@ -67,10 +69,10 @@ protected function setUp(): void
      */
     public function testReadEmptyUpdatesFile()
     {
-        $this->assertEquals(array(), UpdaterUtils::readUpdatesFile(''));
+        $this->assertEquals([], UpdaterUtils::readUpdatesFile(''));
         $updatesFile = $this->conf->get('resource.data_dir') . '/updates.txt';
         touch($updatesFile);
-        $this->assertEquals(array(), UpdaterUtils::readUpdatesFile($updatesFile));
+        $this->assertEquals([], UpdaterUtils::readUpdatesFile($updatesFile));
         unlink($updatesFile);
     }
 
@@ -80,7 +82,7 @@ public function testReadEmptyUpdatesFile()
     public function testReadWriteUpdatesFile()
     {
         $updatesFile = $this->conf->get('resource.data_dir') . '/updates.txt';
-        $updatesMethods = array('m1', 'm2', 'm3');
+        $updatesMethods = ['m1', 'm2', 'm3'];
 
         UpdaterUtils::writeUpdatesFile($updatesFile, $updatesMethods);
         $readMethods = UpdaterUtils::readUpdatesFile($updatesFile);
@@ -102,7 +104,7 @@ public function testWriteEmptyUpdatesFile()
         $this->expectException(\Exception::class);
         $this->expectExceptionMessageRegExp('/Updates file path is not set(.*)/');
 
-        UpdaterUtils::writeUpdatesFile('', array('test'));
+        UpdaterUtils::writeUpdatesFile('', ['test']);
     }
 
     /**
@@ -117,7 +119,7 @@ public function testWriteUpdatesFileNotWritable()
         touch($updatesFile);
         chmod($updatesFile, 0444);
         try {
-            @UpdaterUtils::writeUpdatesFile($updatesFile, array('test'));
+            @UpdaterUtils::writeUpdatesFile($updatesFile, ['test']);
         } catch (Exception $e) {
             unlink($updatesFile);
             throw $e;
@@ -131,17 +133,17 @@ public function testWriteUpdatesFileNotWritable()
      */
     public function testNoUpdates()
     {
-        $updates = array(
+        $updates = [
             'updateMethodDummy1',
             'updateMethodDummy2',
             'updateMethodDummy3',
             'updateMethodException',
-        );
+        ];
-        $updater = new DummyUpdater($updates, array(), $this->conf, true);
+        $updater = new DummyUpdater($updates, [], $this->conf, true);
-        $this->assertEquals(array(), $updater->update());
+        $this->assertEquals([], $updater->update());
 
-        $updater = new DummyUpdater(array(), array(), $this->conf, false);
+        $updater = new DummyUpdater([], [], $this->conf, false);
-        $this->assertEquals(array(), $updater->update());
+        $this->assertEquals([], $updater->update());
     }
 
     /**
@@ -149,13 +151,13 @@ public function testNoUpdates()
      */
     public function testUpdatesFirstTime()
     {
-        $updates = array('updateMethodException',);
+        $updates = ['updateMethodException',];
-        $expectedUpdates = array(
+        $expectedUpdates = [
             'updateMethodDummy1',
             'updateMethodDummy2',
             'updateMethodDummy3',
-        );
+        ];
-        $updater = new DummyUpdater($updates, array(), $this->conf, true);
+        $updater = new DummyUpdater($updates, [], $this->conf, true);
         $this->assertEquals($expectedUpdates, $updater->update());
     }
 
@@ -164,14 +166,14 @@ public function testUpdatesFirstTime()
      */
     public function testOneUpdate()
     {
-        $updates = array(
+        $updates = [
             'updateMethodDummy1',
             'updateMethodDummy3',
             'updateMethodException',
-        );
+        ];
-        $expectedUpdate = array('updateMethodDummy2');
+        $expectedUpdate = ['updateMethodDummy2'];
 
-        $updater = new DummyUpdater($updates, array(), $this->conf, true);
+        $updater = new DummyUpdater($updates, [], $this->conf, true);
         $this->assertEquals($expectedUpdate, $updater->update());
     }
 
@@ -182,13 +184,13 @@ public function testUpdateFailed()
     {
         $this->expectException(\Exception::class);
 
-        $updates = array(
+        $updates = [
             'updateMethodDummy1',
             'updateMethodDummy2',
             'updateMethodDummy3',
-        );
+        ];
 
-        $updater = new DummyUpdater($updates, array(), $this->conf, true);
+        $updater = new DummyUpdater($updates, [], $this->conf, true);
         $updater->update();
     }
 

tests/utils/CurlUtils.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Old-style mock for cURL, as PHPUnit doesn't allow to mock global functions
  */

tests/utils/FakeApplicationUtils.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Shaarli;
+namespace Shaarli\Tests\Utils;
 
 use Shaarli\Helper\ApplicationUtils;
 

tests/utils/FakeBookmarkService.php

@@ -1,13 +1,8 @@
 <?php
 
+namespace Shaarli\Tests\Utils;
 
-use Shaarli\Bookmark\BookmarkArray;
-use Shaarli\Bookmark\BookmarkFilter;
-use Shaarli\Bookmark\BookmarkIO;
 use Shaarli\Bookmark\BookmarkFileService;
-use Shaarli\Bookmark\Exception\EmptyDataStoreException;
-use Shaarli\Config\ConfigManager;
-use Shaarli\History;
 
 class FakeBookmarkService extends BookmarkFileService
 {

tests/utils/RainTPL.php

@@ -0,0 +1,6 @@
+<?php
+
+class RainTPL
+{
+    public static $tpl_dir = '';
+}

tests/utils/ReferenceHistory.php

@@ -1,5 +1,8 @@
 <?php
 
+namespace Shaarli\Tests\Utils;
+
+use DateTime;
 use Shaarli\Helper\FileUtils;
 use Shaarli\History;