From 68ea1d2b30db8ab295e47e9ac5f6c8e81676caf7 Mon Sep 17 00:00:00 2001 From: ArthurHoaro Date: Tue, 8 Mar 2016 10:00:53 +0100 Subject: [PATCH] Fixes #512: retrieving title didn't match the first closing tag --- application/LinkUtils.php | 2 +- tests/LinkUtilsTest.php | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/application/LinkUtils.php b/application/LinkUtils.php index 26dd6b6..d8dc8b5 100644 --- a/application/LinkUtils.php +++ b/application/LinkUtils.php @@ -9,7 +9,7 @@ */ function html_extract_title($html) { - if (preg_match('!(.*)!is', $html, $matches)) { + if (preg_match('!(.*?)!is', $html, $matches)) { return trim(str_replace("\n", ' ', $matches[1])); } return false; diff --git a/tests/LinkUtilsTest.php b/tests/LinkUtilsTest.php index c225759..609a80c 100644 --- a/tests/LinkUtilsTest.php +++ b/tests/LinkUtilsTest.php @@ -15,6 +15,8 @@ class LinkUtilsTest extends PHPUnit_Framework_TestCase $title = 'Read me please.'; $html = 'stuff'. $title .''; $this->assertEquals($title, html_extract_title($html)); + $html = ''. $title .'blablaanother'; + $this->assertEquals($title, html_extract_title($html)); } /**