Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix: synchronous metadata retrieval is failing in strict mode

Browse source 
Metadata can now only be string or null.

Fixes #1653
This commit is contained in:
ArthurHoaro 2020-12-16 14:04:32 +01:00
parent e4b8330e45
commit 6a3a78d023
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
application/front/controller/admin/ShaarePublishController.php
View file

@ -227,7 +227,7 @@ class ShaarePublishController extends ShaarliAdminController
protected function buildFormData(array $link, bool $isNew, Request $request): array
{
$link['tags'] = strlen($link['tags']) > 0
$link['tags'] = $link['tags'] !== null && strlen($link['tags']) > 0
? $link['tags'] . $this->container->conf->get('general.tags_separator', ' ')
: $link['tags']
;

9
application/http/MetadataRetriever.php
View file

@ -60,10 +60,15 @@ class MetadataRetriever
$title = mb_convert_encoding($title, 'utf-8', $charset);
}
return [
return array_map([$this, 'cleanMetadata'], [
'title' => $title,
'description' => $description,
'tags' => $tags,
];
]);
}
protected function cleanMetadata($data): ?string
{
return !is_string($data) || empty(trim($data)) ? null : trim($data);
}
}

2
tests/http/MetadataRetrieverTest.php
View file

@ -41,7 +41,7 @@ class MetadataRetrieverTest extends TestCase
$remoteCharset = 'utf-8';
$expectedResult = [
'title' => $remoteTitle,
'title' => trim($remoteTitle),
'description' => $remoteDesc,
'tags' => $remoteTags,
];