diff --git a/application/TimeZone.php b/application/TimeZone.php index e363d90..26f2232 100644 --- a/application/TimeZone.php +++ b/application/TimeZone.php @@ -101,10 +101,6 @@ function generateTimeZoneForm($preselectedTimezone='') */ function isTimeZoneValid($continent, $city) { - if ($continent == 'UTC' && $city == 'UTC') { - return true; - } - return in_array( $continent.'/'.$city, timezone_identifiers_list() diff --git a/index.php b/index.php index e9b0bf4..47bae6e 100644 --- a/index.php +++ b/index.php @@ -1277,11 +1277,15 @@ function renderPage() { if (!empty($_POST['title']) ) { - if (!tokenOk($_POST['token'])) die('Wrong token.'); // Go away! + if (!tokenOk($_POST['token'])) { + die('Wrong token.'); // Go away! + } $tz = 'UTC'; - if (!empty($_POST['continent']) && !empty($_POST['city'])) - if (isTimeZoneValid($_POST['continent'],$_POST['city'])) - $tz = $_POST['continent'].'/'.$_POST['city']; + if (!empty($_POST['continent']) && !empty($_POST['city']) + && isTimeZoneValid($_POST['continent'], $_POST['city']) + ) { + $tz = $_POST['continent'] . '/' . $_POST['city']; + } $GLOBALS['timezone'] = $tz; $GLOBALS['title']=$_POST['title']; $GLOBALS['titleLink']=$_POST['titleLink']; @@ -2108,10 +2112,10 @@ function install() if (!empty($_POST['setlogin']) && !empty($_POST['setpassword'])) { $tz = 'UTC'; - if (!empty($_POST['continent']) && !empty($_POST['city'])) { - if (isTimeZoneValid($_POST['continent'], $_POST['city'])) { - $tz = $_POST['continent'].'/'.$_POST['city']; - } + if (!empty($_POST['continent']) && !empty($_POST['city']) + && isTimeZoneValid($_POST['continent'], $_POST['city']) + ) { + $tz = $_POST['continent'].'/'.$_POST['city']; } $GLOBALS['timezone'] = $tz; // Everything is ok, let's create config file. diff --git a/tests/TimeZoneTest.php b/tests/TimeZoneTest.php index b219030..2976d11 100644 --- a/tests/TimeZoneTest.php +++ b/tests/TimeZoneTest.php @@ -67,7 +67,6 @@ class TimeZoneTest extends PHPUnit_Framework_TestCase { $this->assertTrue(isTimeZoneValid('America', 'Argentina/Ushuaia')); $this->assertTrue(isTimeZoneValid('Europe', 'Oslo')); - $this->assertTrue(isTimeZoneValid('UTC', 'UTC')); } /** @@ -78,5 +77,6 @@ class TimeZoneTest extends PHPUnit_Framework_TestCase $this->assertFalse(isTimeZoneValid('CEST', 'CEST')); $this->assertFalse(isTimeZoneValid('Europe', 'Atlantis')); $this->assertFalse(isTimeZoneValid('Middle_Earth', 'Moria')); + $this->assertFalse(isTimeZoneValid('UTC', 'UTC')); } }