Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix: bulk add - use unique HTML ID

Browse source 
Use links loop ID to make ID unique and fix browser labels behaviour.

Fixes #1685
This commit is contained in:
ArthurHoaro 2021-01-19 11:35:42 +01:00
parent 544bbdaf83
commit 8fbc29de02
2 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
tpl/default/editlink.batch.html
View file

@ -20,6 +20,7 @@
</div> </div>
{loop="$links"} {loop="$links"}
{$batchId=$key}
{include="editlink"} {include="editlink"}
{/loop} {/loop}

23
tpl/default/editlink.html
View file

@ -1,3 +1,4 @@
{$batchId=isset($batchId) ? $batchId : ''}
{if="empty($batch_mode)"} {if="empty($batch_mode)"}
<!DOCTYPE html> <!DOCTYPE html>
<html{if="$language !== 'auto'"} lang="{$language}"{/if}> <html{if="$language !== 'auto'"} lang="{$language}"{/if}>
@ -10,7 +11,7 @@
{ignore}Lil hack: when included in a loop in batch mode, `$value` is assigned by RainTPL with template vars.{/ignore} {ignore}Lil hack: when included in a loop in batch mode, `$value` is assigned by RainTPL with template vars.{/ignore}
{function="extract($value) ? '' : ''"} {function="extract($value) ? '' : ''"}
{/if} {/if}
<div id="editlinkform" class="edit-link-container" class="pure-g"> <div id="editlinkform{$batchId}" class="edit-link-container" class="pure-g">
<div class="pure-u-lg-1-5 pure-u-1-24"></div> <div class="pure-u-lg-1-5 pure-u-1-24"></div>
<form method="post" <form method="post"
name="linkform" name="linkform"
@ -27,16 +28,16 @@ <h2 class="window-title">
{/if} {/if}
{if="!$link_is_new"}<div class="created-date">{'Created:'|t} {$link.created|format_date}</div>{/if} {if="!$link_is_new"}<div class="created-date">{'Created:'|t} {$link.created|format_date}</div>{/if}
<div> <div>
<label for="lf_url">{'URL'|t}</label> <label for="lf_url{$batchId}">{'URL'|t}</label>
</div> </div>
<div> <div>
<input type="text" name="lf_url" id="lf_url" value="{$link.url}" class="lf_input"> <input type="text" name="lf_url" id="lf_url{$batchId}" value="{$link.url}" class="lf_input">
</div> </div>
<div> <div>
<label for="lf_title">{'Title'|t}</label> <label for="lf_title{$batchId}">{'Title'|t}</label>
</div> </div>
<div class="{$asyncLoadClass}"> <div class="{$asyncLoadClass}">
<input type="text" name="lf_title" id="lf_title" value="{$link.title}" <input type="text" name="lf_title" id="lf_title{$batchId}" value="{$link.title}"
class="lf_input {if="!$async_metadata"}autofocus{/if}" class="lf_input {if="!$async_metadata"}autofocus{/if}"
> >
<div class="icon-container"> <div class="icon-container">
@ -44,19 +45,19 @@ <h2 class="window-title">
</div> </div>
</div> </div>
<div> <div>
<label for="lf_description">{'Description'|t}</label> <label for="lf_description{$batchId}">{'Description'|t}</label>
</div> </div>
<div class="{if="$retrieve_description"}{$asyncLoadClass}{/if}"> <div class="{if="$retrieve_description"}{$asyncLoadClass}{/if}">
<textarea name="lf_description" id="lf_description" class="autofocus">{$link.description}</textarea> <textarea name="lf_description" id="lf_description{$batchId}" class="autofocus">{$link.description}</textarea>
<div class="icon-container"> <div class="icon-container">
<i class="loader"></i> <i class="loader"></i>
</div> </div>
</div> </div>
<div> <div>
<label for="lf_tags">{'Tags'|t}</label> <label for="lf_tags{$batchId}">{'Tags'|t}</label>
</div> </div>
<div class="{if="$retrieve_description"}{$asyncLoadClass}{/if}"> <div class="{if="$retrieve_description"}{$asyncLoadClass}{/if}">
<input type="text" name="lf_tags" id="lf_tags" value="{$link.tags}" class="lf_input autofocus" <input type="text" name="lf_tags" id="lf_tags{$batchId}" value="{$link.tags}" class="lf_input autofocus"
data-list="{loop="$tags"}{$key}, {/loop}" data-multiple data-autofirst autocomplete="off" > data-list="{loop="$tags"}{$key}, {/loop}" data-multiple data-autofirst autocomplete="off" >
<div class="icon-container"> <div class="icon-container">
<i class="loader"></i> <i class="loader"></i>
@ -64,11 +65,11 @@ <h2 class="window-title">
</div> </div>
<div> <div>
<input type="checkbox" name="lf_private" id="lf_private" <input type="checkbox" name="lf_private" id="lf_private{$batchId}"
{if="$link.private === true"} {if="$link.private === true"}
checked="checked" checked="checked"
{/if}> {/if}>
&nbsp;<label for="lf_private">{'Private'|t}</label> &nbsp;<label for="lf_private{$batchId}">{'Private'|t}</label>
</div> </div>
{if="$formatter==='markdown'"} {if="$formatter==='markdown'"}