Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

cleanup: refactor annoying URL patterns in a single loop

Browse source 
* fixes https://github.com/shaarli/Shaarli/issues/133
This commit is contained in:
nodiscc 2015-03-04 19:52:24 +01:00
parent bc1ef5b94a
commit ad2a397c66
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
index.php
View file

@ -1642,15 +1642,12 @@ function renderPage()
{ {
$url=$_GET['post']; $url=$_GET['post'];
// We remove the annoying parameters added by FeedBurner and GoogleFeedProxy (?utm_source=...) // We remove the annoying parameters added by FeedBurner, GoogleFeedProxy, Facebook...
$i=strpos($url,'&utm_source='); if ($i!==false) $url=substr($url,0,$i); $annoyingpatterns = array('&utm_source=', '?utm_source=', '#xtor=RSS-', '?fb_', '?__scoop', '#tk.rss_all?', '?utm_campaign=', '?utm_medium=');
$i=strpos($url,'?utm_source='); if ($i!==false) $url=substr($url,0,$i); foreach($annoyingpatterns as $pattern)
$i=strpos($url,'#xtor=RSS-'); if ($i!==false) $url=substr($url,0,$i); {
$i=strpos($url,'?fb_'); if ($i!==false) $url=substr($url,0,$i); $i=strpos($url,$pattern); if ($i!==false) $url=substr($url,0,$i);
$i=strpos($url,'?__scoop'); if ($i!==false) $url=substr($url,0,$i); }
$i=strpos($url,'#tk.rss_all?'); if ($i!==false) $url=substr($url,0,$i);
$i=strpos($url,'?utm_campaign='); if ($i!==false) $url=substr($url,0,$i);
$i=strpos($url,'?utm_medium='); if ($i!==false) $url=substr($url,0,$i);
$link_is_new = false; $link_is_new = false;
$link = $LINKSDB->getLinkFromUrl($url); // Check if URL is not already in database (in this case, we will edit the existing link) $link = $LINKSDB->getLinkFromUrl($url); // Check if URL is not already in database (in this case, we will edit the existing link)