Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix division by zero in tagcloud

Browse source 
It happens if we have a maximum of 1 occurrence in tags (log(1) = 0)
This commit is contained in:
ArthurHoaro 2020-01-26 14:52:10 +01:00
parent c653ae3bfb
commit b495d5c92a
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
index.php
View file

@ -659,6 +659,7 @@ function renderPage($conf, $pluginManager, $bookmarkService, $history, $sessionM
alphabetical_sort($tags, false, true); alphabetical_sort($tags, false, true);
$logMaxCount = $maxcount > 1 ? log($maxcount, 30) : 1;
$tagList = array(); $tagList = array();
foreach ($tags as $key => $value) { foreach ($tags as $key => $value) {
if (in_array($key, $filteringTags)) { if (in_array($key, $filteringTags)) {
@ -666,8 +667,8 @@ function renderPage($conf, $pluginManager, $bookmarkService, $history, $sessionM
} }
// Tag font size scaling: // Tag font size scaling:
// default 15 and 30 logarithm bases affect scaling, // default 15 and 30 logarithm bases affect scaling,
// 22 and 6 are arbitrary font sizes for max and min sizes. // 2.2 and 0.8 are arbitrary font sizes in em.
$size = log($value, 15) / log($maxcount, 30) * 2.2 + 0.8; $size = log($value, 15) / $logMaxCount * 2.2 + 0.8;
$tagList[$key] = array( $tagList[$key] = array(
'count' => $value, 'count' => $value,
'size' => number_format($size, 2, '.', ''), 'size' => number_format($size, 2, '.', ''),