Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix UT: LinkDBTest - make each tests independant

Browse source 
Otherwise the datastore is empty in the last test, making it
inconsistent due to dates issues.
This commit is contained in:
ArthurHoaro 2019-08-10 12:42:53 +02:00
parent 7ff3ed1d63
commit bd1adc8df6
1 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
tests/bookmark/LinkDBTest.php
View file

@ -49,17 +49,7 @@ class LinkDBTest extends \PHPUnit\Framework\TestCase
* - by tag, * - by tag,
* - by text, * - by text,
* - etc. * - etc.
*/ *
public static function setUpBeforeClass()
{
self::$refDB = new ReferenceLinkDB();
self::$refDB->write(self::$testDatastore);
self::$publicLinkDB = new LinkDB(self::$testDatastore, false, false);
self::$privateLinkDB = new LinkDB(self::$testDatastore, true, false);
}
/**
* Resets test data for each test * Resets test data for each test
*/ */
protected function setUp() protected function setUp()
@ -67,6 +57,12 @@ class LinkDBTest extends \PHPUnit\Framework\TestCase
if (file_exists(self::$testDatastore)) { if (file_exists(self::$testDatastore)) {
unlink(self::$testDatastore); unlink(self::$testDatastore);
} }
self::$refDB = new ReferenceLinkDB();
self::$refDB->write(self::$testDatastore);
self::$publicLinkDB = new LinkDB(self::$testDatastore, false, false);
self::$privateLinkDB = new LinkDB(self::$testDatastore, true, false);
} }
/** /**
@ -191,7 +187,7 @@ class LinkDBTest extends \PHPUnit\Framework\TestCase
$dbSize = sizeof($testDB); $dbSize = sizeof($testDB);
$link = array( $link = array(
'id' => 42, 'id' => 43,
'title' => 'an additional link', 'title' => 'an additional link',
'url' => 'http://dum.my', 'url' => 'http://dum.my',
'description' => 'One more', 'description' => 'One more',
@ -626,7 +622,7 @@ class LinkDBTest extends \PHPUnit\Framework\TestCase
*/ */
public function testConsistentOrder() public function testConsistentOrder()
{ {
$nextId = 42; $nextId = 43;
$creation = DateTime::createFromFormat('Ymd_His', '20190807_130444'); $creation = DateTime::createFromFormat('Ymd_His', '20190807_130444');
$linkDB = new LinkDB(self::$testDatastore, true, false); $linkDB = new LinkDB(self::$testDatastore, true, false);
for ($i = 0; $i < 4; ++$i) { for ($i = 0; $i < 4; ++$i) {
@ -646,6 +642,9 @@ class LinkDBTest extends \PHPUnit\Framework\TestCase
$linkDB = new LinkDB(self::$testDatastore, true, false); $linkDB = new LinkDB(self::$testDatastore, true, false);
$count = 3; $count = 3;
foreach ($linkDB as $link) { foreach ($linkDB as $link) {
if ($link['sticky'] === true) {
continue;
}
$this->assertEquals($nextId + $count, $link['id']); $this->assertEquals($nextId + $count, $link['id']);
$this->assertEquals('http://'. $count, $link['url']); $this->assertEquals('http://'. $count, $link['url']);
if (--$count < 0) { if (--$count < 0) {