diff --git a/application/SessionManager.php b/application/SessionManager.php index 3aa4ddf..71f0b38 100644 --- a/application/SessionManager.php +++ b/application/SessionManager.php @@ -12,12 +12,12 @@ class SessionManager * Constructor * * @param array $session The $_SESSION array (reference) - * @param ConfigManager $conf ConfigManager instance (reference) + * @param ConfigManager $conf ConfigManager instance */ - public function __construct(& $session, & $conf) + public function __construct(& $session, $conf) { $this->session = &$session; - $this->conf = &$conf; + $this->conf = $conf; } /** diff --git a/tests/SessionManagerTest.php b/tests/SessionManagerTest.php index a92c3cc..aa75962 100644 --- a/tests/SessionManagerTest.php +++ b/tests/SessionManagerTest.php @@ -1,4 +1,6 @@ generateToken(); @@ -61,9 +54,7 @@ class SessionManagerTest extends TestCase $token => 1, ], ]; - $conf = new FakeConfigManager(); - $sessionManager = new SessionManager($session, $conf); - + $sessionManager = new SessionManager($session, self::$conf); // check and destroy the token $this->assertTrue($sessionManager->checkToken($token)); @@ -79,8 +70,7 @@ class SessionManagerTest extends TestCase public function testGenerateAndCheckToken() { $session = []; - $conf = new FakeConfigManager(); - $sessionManager = new SessionManager($session, $conf); + $sessionManager = new SessionManager($session, self::$conf); $token = $sessionManager->generateToken(); @@ -102,8 +92,7 @@ class SessionManagerTest extends TestCase public function testCheckInvalidToken() { $session = []; - $conf = new FakeConfigManager(); - $sessionManager = new SessionManager($session, $conf); + $sessionManager = new SessionManager($session, self::$conf); $this->assertFalse($sessionManager->checkToken('4dccc3a45ad9d03e5542b90c37d8db6d10f2b38b')); } diff --git a/tests/utils/FakeConfigManager.php b/tests/utils/FakeConfigManager.php new file mode 100644 index 0000000..f29760c --- /dev/null +++ b/tests/utils/FakeConfigManager.php @@ -0,0 +1,12 @@ +