Knah-Tsaeb/MyShaarli
Knah-Tsaeb/MyShaarli
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #1671 from ArthurHoaro/fix/plugin-colors-update

Browse source 
Fix default_colors plugin: update CSS file on color change
This commit is contained in:
ArthurHoaro 2021-01-03 11:43:54 +01:00 committed by GitHub
parent 20ba77a2dc 035a002edc
commit ed4ee8f029
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 37 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
plugins/default_colors/default_colors.php
View file

@ -46,6 +46,20 @@ function default_colors_init($conf)
}
}
/**
* When plugin parameters are saved, we regenerate the custom CSS file with provided settings.
*
* @param array $data $_POST array
*
* @return array Updated $_POST array
*/
function hook_default_colors_save_plugin_parameters($data)
{
default_colors_generate_css_file($data);
return $data;
}
/**
* When linklist is displayed, include default_colors CSS file.
*

23
tests/plugins/PluginDefaultColorsTest.php
View file

@ -193,4 +193,27 @@ class PluginDefaultColorsTest extends TestCase
$result = default_colors_format_css_rule($data, '');
$this->assertEmpty($result);
}
/**
* Make sure that a new CSS file is generated when save_plugin_parameters hook is triggered.
*/
public function testHookSavePluginParameters(): void
{
$params = [
'other1' => true,
'DEFAULT_COLORS_BACKGROUND' => 'pink',
'other2' => ['yep'],
'DEFAULT_COLORS_DARK_MAIN' => '',
];
hook_default_colors_save_plugin_parameters($params);
$this->assertFileExists($file = 'sandbox/default_colors/default_colors.css');
$content = file_get_contents($file);
$expected = ':root {
--background-color: pink;
}
';
$this->assertEquals($expected, $content);
}
}