Fix division by zero in tagcloud (#1411)

Fix division by zero in tagcloud
This commit is contained in:
ArthurHoaro 2020-01-26 14:55:07 +01:00 committed by GitHub
commit f6637392a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -659,6 +659,7 @@ function renderPage($conf, $pluginManager, $bookmarkService, $history, $sessionM
alphabetical_sort($tags, false, true); alphabetical_sort($tags, false, true);
$logMaxCount = $maxcount > 1 ? log($maxcount, 30) : 1;
$tagList = array(); $tagList = array();
foreach ($tags as $key => $value) { foreach ($tags as $key => $value) {
if (in_array($key, $filteringTags)) { if (in_array($key, $filteringTags)) {
@ -666,8 +667,8 @@ function renderPage($conf, $pluginManager, $bookmarkService, $history, $sessionM
} }
// Tag font size scaling: // Tag font size scaling:
// default 15 and 30 logarithm bases affect scaling, // default 15 and 30 logarithm bases affect scaling,
// 22 and 6 are arbitrary font sizes for max and min sizes. // 2.2 and 0.8 are arbitrary font sizes in em.
$size = log($value, 15) / log($maxcount, 30) * 2.2 + 0.8; $size = log($value, 15) / $logMaxCount * 2.2 + 0.8;
$tagList[$key] = array( $tagList[$key] = array(
'count' => $value, 'count' => $value,
'size' => number_format($size, 2, '.', ''), 'size' => number_format($size, 2, '.', ''),