Merge pull request #961 from thewilli/private-shaarli-login-redirect

added option to redirect all anonymous users to login page
This commit is contained in:
VirtualTam 2017-09-18 21:25:02 +02:00 committed by GitHub
commit fc1c1b8869
3 changed files with 20 additions and 0 deletions

View file

@ -327,6 +327,7 @@ protected function setDefaultValues()
$this->setEmpty('privacy.default_private_links', false); $this->setEmpty('privacy.default_private_links', false);
$this->setEmpty('privacy.hide_public_links', false); $this->setEmpty('privacy.hide_public_links', false);
$this->setEmpty('privacy.force_login', false);
$this->setEmpty('privacy.hide_timestamps', false); $this->setEmpty('privacy.hide_timestamps', false);
// default state of the 'remember me' checkbox of the login form // default state of the 'remember me' checkbox of the login form
$this->setEmpty('privacy.remember_user_default', true); $this->setEmpty('privacy.remember_user_default', true);

View file

@ -90,6 +90,7 @@ _These settings should not be edited_
- **default_private_links**: Check the private checkbox by default for every new link. - **default_private_links**: Check the private checkbox by default for every new link.
- **hide_public_links**: All links are hidden while logged out. - **hide_public_links**: All links are hidden while logged out.
- **force_login**: if **hide_public_links** and this are set to `true`, all anonymous users are redirected to the login page.
- **hide_timestamps**: Timestamps are hidden. - **hide_timestamps**: Timestamps are hidden.
- **remember_user_default**: Default state of the login page's *remember me* checkbox - **remember_user_default**: Default state of the login page's *remember me* checkbox
- `true`: checked by default, `false`: unchecked by default - `true`: checked by default, `false`: unchecked by default
@ -194,6 +195,7 @@ _These settings should not be edited_
"privacy": { "privacy": {
"default_private_links": true, "default_private_links": true,
"hide_public_links": false, "hide_public_links": false,
"force_login": false,
"hide_timestamps": false, "hide_timestamps": false,
"remember_user_default": true "remember_user_default": true
}, },

View file

@ -718,6 +718,23 @@ function renderPage($conf, $pluginManager, $LINKSDB, $history)
$query = (isset($_SERVER['QUERY_STRING'])) ? $_SERVER['QUERY_STRING'] : ''; $query = (isset($_SERVER['QUERY_STRING'])) ? $_SERVER['QUERY_STRING'] : '';
$targetPage = Router::findPage($query, $_GET, isLoggedIn()); $targetPage = Router::findPage($query, $_GET, isLoggedIn());
if (
// if the user isn't logged in
!isLoggedIn() &&
// and Shaarli doesn't have public content...
$conf->get('privacy.hide_public_links') &&
// and is configured to enforce the login
$conf->get('privacy.force_login') &&
// and the current page isn't already the login page
$targetPage !== Router::$PAGE_LOGIN &&
// and the user is not requesting a feed (which would lead to a different content-type as expected)
$targetPage !== Router::$PAGE_FEED_ATOM &&
$targetPage !== Router::$PAGE_FEED_RSS
) {
// force current page to be the login page
$targetPage = Router::$PAGE_LOGIN;
}
// Call plugin hooks for header, footer and includes, specifying which page will be rendered. // Call plugin hooks for header, footer and includes, specifying which page will be rendered.
// Then assign generated data to RainTPL. // Then assign generated data to RainTPL.
$common_hooks = array( $common_hooks = array(