ArthurHoaro
4e3875c0ce
Feature: highlight fulltext search results
...
How it works:
1. when a fulltext search is made, Shaarli looks for the first
occurence position of every term matching the search. No change here,
but we store these positions in an array, in Bookmark's additionalContent.
2. when formatting bookmarks (through BookmarkFormatter
implementation):
1. first we insert specific tokens at every search result positions
2. we format the content (escape HTML, apply markdown, etc.)
3. as a last step, we replace our token with displayable span
elements
Cons: this tightens coupling between search filters and formatters
Pros: it was absolutely necessary not to perform the
search twice. this solution has close to no impact on performances.
Fixes #205
2020-10-16 20:31:12 +02:00
ArthurHoaro
81c9df1363
Merge pull request #1593 from ArthurHoaro/fix/no-url-rewriting
2020-10-16 19:26:03 +02:00
ArthurHoaro
3adbdc2a83
Inject ROOT_PATH in plugin instead of regenerating it everywhere
2020-10-16 13:06:06 +02:00
ArthurHoaro
7f5250421b
Support using Shaarli without URL rewriting
...
- Shaarli can be fully used by prefixing any URL with /index.php/
- {$base_path} used in templates already works with this configuration
- Assets path (outside of theme's assets) must be prefixed with {$root_url}/
- Documentation section in « Server configuration »
Fixes #1590
2020-10-16 12:47:11 +02:00
ArthurHoaro
4b3aca6623
Strict types: fix an issue in daily where the date could be an int
2020-10-16 12:04:46 +02:00
ArthurHoaro
efb7d21b52
Add strict types for bookmarks management
...
Parameters typing and using strict types overall increase the codebase
quality by enforcing the a given parameter will have the expected type.
It also removes the need to unnecessary unit tests checking methods
behavior with invalid input.
2020-10-13 13:50:11 +02:00
ArthurHoaro
fd1ddad98d
Add mutex on datastore I/O operations
...
To make sure that there is no concurrent operation on the datastore file.
Fixes #1132
2020-10-13 12:38:19 +02:00
ArthurHoaro
458b6b9918
Merge pull request #1540 from ArthurHoaro/fix/metadata-regexes
...
Improve regex to extract HTML metadata (title, description, etc.)
2020-10-13 12:26:55 +02:00
ArthurHoaro
543b16b4f4
Merge pull request #1525 from ArthurHoaro/feature/rest-api-bookmark-dates
...
REST API: allow override of creation and update dates
2020-10-13 12:26:01 +02:00
ArthurHoaro
8fabcd0224
Add Markdown Extra formatter
...
Library: [Parsedown Extra](https://github.com/erusev/parsedown-extra )
Also sort dependencies alphabetically.
Fixes #1169
2020-10-13 12:20:34 +02:00
ArthurHoaro
72fbbcd679
Security: fix multiple XSS vulnerabilities + fix search tags with special chars
...
XSS vulnerabilities fixed in editlink, linklist, tag.cloud and tag.list.
Also fixed tag search with special characters: urlencode function needs to be applied on raw data, before espaping, otherwise the rendered URL is wrong.
2020-10-06 17:30:18 +02:00
ArthurHoaro
7b18876361
Merge pull request #1575 from ArthurHoaro/feature/php8
2020-10-03 12:59:16 +02:00
ArthurHoaro
ee07b7283f
Merge pull request #1574 from stoeps13/hosting-fix
2020-10-03 12:59:01 +02:00
ArthurHoaro
255b2264a1
Revert unrelated changes and add unit tests
2020-09-30 15:57:57 +02:00
ArthurHoaro
80a3efe116
Fix a bug preventing to edit bookmark with ID #0
2020-09-30 15:31:34 +02:00
Christoph Stoettner
25cb75552b
Fix identation
2020-09-30 12:29:54 +02:00
Christoph Stoettner
d8ef4a893f
Change to ->container->environment
2020-09-30 12:27:44 +02:00
ArthurHoaro
1ea09a1b8b
Fix warning if the encoding retrieved from external headers is invalid
...
Also fixed the regex to support this failing header: charset="utf-8"\r\n"
2020-09-30 11:11:19 +02:00
ArthurHoaro
ab58f25420
Compatibility with PHP 8
2020-09-29 18:57:22 +02:00
Christoph Stoettner
676571dab9
Workaround for hoster (ionos)
...
The hoster writes the environment variable with bearer token to
REDIRECT_HTTP_AUTHORIZATION and needs to provide RewriteBase / to
.htaccess
2020-09-29 12:15:04 +02:00
ArthurHoaro
abe033be85
Fix invalid redirection using the path of an external domain
...
Fixes #1554
2020-09-22 15:37:26 +02:00
ArthurHoaro
5baafe5001
Merge pull request #1559 from ArthurHoaro/fix/edit-redirect
...
Fix redirection to referer after editing a link
2020-09-22 14:15:13 +02:00
ArthurHoaro
98e7a59ca2
Merge pull request #1539 from ArthurHoaro/feature/manual-root-url
2020-09-22 14:08:54 +02:00
ArthurHoaro
2785d85e0a
Fix redirection to referer after editing a link
...
Fixes #1545
2020-09-22 14:04:10 +02:00
ArthurHoaro
0d930454a2
Merge pull request #1553 from ArthurHoaro/fix/404-page
...
Properly handle 404 errors
2020-09-12 21:41:58 +02:00
ArthurHoaro
4af591ff3c
Merge pull request #1551 from ArthurHoaro/fix/plugin-save-metadata
...
Plugins: do not save metadata along plugin parameters
2020-09-12 21:41:24 +02:00
ArthurHoaro
b93cfeba7b
Fix subfolder configuration in unit tests
2020-09-12 21:39:01 +02:00
ArthurHoaro
650a5f09cb
Add manual configuration for root URL
...
This new setting under 'general.root_url' allows to override automatic discovery of Shaarli instance's URL.
Fixes #1339
2020-09-12 21:39:01 +02:00
ArthurHoaro
4ff703e369
Plugins: do not save metadata along plugin parameters
...
Also prevent the token to be saved.
Fixes #1550
2020-09-12 13:29:34 +02:00
ArthurHoaro
d52ab0b1e9
Properly handle 404 errors
...
Use 404 template instead of default Slim error page if the route is not found.
Fixes #827
2020-09-12 12:42:19 +02:00
ArthurHoaro
6128ab6a55
Merge pull request #1552 from ArthurHoaro/feature/better-initializer
2020-09-12 12:14:18 +02:00
ArthurHoaro
da7acb9830
Improve default bookmarks after install
...
Used @nodiscc suggestion in #1148 (slightly edited).
It provides a description of what Shaarli does, Markdown rendering demo, and a thumbnail link.
Fixes #1148
2020-09-10 16:29:17 +02:00
ArthurHoaro
e2dff28b44
Merge pull request #1547 from ArthurHoaro/fix/daily-visibility
...
Fix visibility issue on daily page
2020-09-06 14:16:08 +02:00
ArthurHoaro
949a095310
Merge pull request #1538 from ArthurHoaro/feature/plugins-bookmark-service
...
Inject BookmarkServiceInterface in plugins data
2020-09-06 14:13:16 +02:00
ArthurHoaro
27ddfec3c3
Fix visibility issue on daily page
...
This filter (links by day) didn't apply any visibility parameter.
Fixes #1543
2020-09-06 14:11:02 +02:00
ArthurHoaro
2ba51040c7
Merge pull request #1541 from ArthurHoaro/fix/legacy-login-encoding
2020-09-03 18:54:45 +02:00
ArthurHoaro
d33cffdb2e
Fix: encoding in legacy route login redirection to post bookmark
...
When a bookmark is post from a logged out user, he is first redirected to the login page with 'returnurl' containing the link, then redirected again when the login is processed.
We need to reencode the posted URL, otherwise the browser does not handle the fragment as a part of the posted parameter.
2020-09-03 18:46:10 +02:00
ArthurHoaro
2cd0509b50
Improve regex to extract HTML metadata (title, description, etc.)
...
Also added a bunch of tests to cover more use cases.
Fixes #1375
2020-09-03 17:46:26 +02:00
ArthurHoaro
80b708a878
Inject BookmarkServiceInterface in plugins data
...
Related discussion: ilesinge/shaarli-related#7
2020-09-03 15:08:08 +02:00
ArthurHoaro
46d3f8162b
Merge pull request #1537 from ArthurHoaro/fix/back-compatible-targets
2020-09-03 14:57:24 +02:00
ArthurHoaro
ce7918386a
Improve backward compatibility for LegacyRouter
...
LegacyRouter is no longer used for routing, only in existing plugins to match the _PAGE_ parameter.
So we change a few of its values there, to match the new ones defined in TemplatePage.
@see discussion in shaarli/Shaarli#1537
2020-09-03 10:09:36 +02:00
ArthurHoaro
9e6371a6fd
Merge pull request #1520 from ArthurHoaro/fix/jp-language
2020-09-03 08:46:47 +02:00
ArthurHoaro
0a286f6946
Merge pull request #1526 from kcaran/links_per_page
2020-09-03 08:45:48 +02:00
ArthurHoaro
2835ac7cbe
Merge pull request #1524 from ArthurHoaro/fix/rss-sticky
...
Fixed: Pinned bookmarks are displayed first in ATOM/RSS feeds
2020-09-03 08:45:12 +02:00
ArthurHoaro
ca636b898c
Merge pull request #1536 from ArthurHoaro/fix/login-private-shaarli
...
Fix login loop for private instances
2020-09-03 08:35:18 +02:00
ArthurHoaro
d95624add4
Merge pull request #1534 from ArthurHoaro/fix/legacy-route-post
2020-09-03 08:35:05 +02:00
ArthurHoaro
14fcfb5213
Fix login loop for private instances
...
GET /login and POST /login have 2 distinct route name.
Fixes #1533
2020-09-01 11:26:24 +02:00
ArthurHoaro
11aa4a7a29
Support redirection of legacy route 'do=configure'
2020-09-01 10:40:35 +02:00
ArthurHoaro
9e2d47e519
Fix legacy redirection when Shaarli instance is under a subfolder
2020-09-01 10:40:18 +02:00
ArthurHoaro
aca995e09c
Fix support for legacy route login redirection
...
Makes sure that the user is properly redirected to the bookmark form after login, even with legacy routes
2020-09-01 10:12:54 +02:00