Commit graph

215 commits

Author SHA1 Message Date
ArthurHoaro
cf92b4dd15 Apply the new system (Bookmark + Service) to the whole code base
See https://github.com/shaarli/Shaarli/issues/1307
2020-01-18 09:55:59 +01:00
Lucas Cimon
d9bfceaddf Avoiding warning 'PHP Notice: Undefined index: updated' 2020-01-12 14:55:37 +01:00
ArthurHoaro
e0e24335f7 Fix undefined thumbnail on OpenGraph headers
Fixes #1362
2019-09-10 18:40:07 +02:00
ArthurHoaro
7ff3ed1d63
Merge pull request #1336 from ArthurHoaro/hotfix/atom-author
ATOM Feed: use instance name as author name instead of URL
2019-08-10 12:08:22 +02:00
agentcobra
419eef1f56
little fix template
fix link between label and checkbox (updateCheck)
2019-08-01 12:33:25 +02:00
ArthurHoaro
f9b99c7217 ATOM Feed: use instance name as author name instead of URL
Related FreshRSS/FreshRSS#2466
2019-07-29 19:37:51 +02:00
Luce Carević
06a8992737
maj linklist
put back the link on the thumbmail and fix a11y
2019-07-28 12:33:06 +02:00
Luce Carević
d1bcf28db3 fix a11y 2019-07-13 18:56:43 +02:00
Luce Carević
719ef8e896 fix a11y 2019-07-13 18:26:31 +02:00
ArthurHoaro
01ba8a0700
Merge pull request #1323 from llune/patch-5
fix a11y label
2019-07-13 15:09:47 +02:00
ArthurHoaro
b15d065905
Merge pull request #1321 from llune/patch-3
a11y fix img without alt
2019-07-13 15:09:20 +02:00
ArthurHoaro
c088ae99bf
Merge pull request #1324 from llune/patch-6
a11y fix add banner mobile version
2019-07-13 15:09:08 +02:00
ArthurHoaro
19ba060669
Merge pull request #1322 from llune/patch-4
fix a11y label
2019-07-13 15:08:50 +02:00
Luce Carević
84b8426c31
a11y fix add banner mobile version 2019-07-13 00:40:30 +02:00
Luce Carević
cadf4d5bd6
fix a11y label 2019-07-13 00:09:54 +02:00
Luce Carević
6177da0c30
fix a11y label 2019-07-13 00:07:50 +02:00
Luce Carević
d91719ab97
fix img without alt 2019-07-13 00:04:25 +02:00
Luce Carević
b43c98fecb
fix blank 2019-07-12 23:56:43 +02:00
Luce Carević
852872930f
a11y fix: label and tabindex
Don't use tabindex values other than -1, 0. (see https://webaim.org/techniques/keyboard/tabindex).

Fix inputs without labels (the placeholder attribute is not a proper labelling method)
2019-07-12 23:54:42 +02:00
ArthurHoaro
6a4872520c Automatically retrieve description for new bookmarks
If the option is enabled, it will try to find a meta tag containing
the page description and keywords, just like we do for the page title.
It will either look for regular meta tag or OpenGraph ones.

The option is disabled by default.

Note that keywords meta tags is mostly not used.

In `configure` template, the variable associated with this setting
is `$retrieve_description`.

Fixes #1302
2019-07-06 12:21:52 +02:00
ArthurHoaro
5321f704b5 Daily - display the current day instead of the previous one
Also mention if it's today or yesterday for clarity using `dayDesc`
variable

Fixes #1299
2019-05-25 16:40:45 +02:00
ArthurHoaro
8ed59f107e
Merge pull request #1301 from ArthurHoaro/template/print-css
Add print CSS rules to the default template
2019-05-25 15:38:49 +02:00
ArthurHoaro
b2143ff480 Switch from FontAwesome v4.x to ForkAwesome
And use the Shaarli icon made by @xuv in the header and footer (default template).
2019-05-19 12:03:14 +02:00
ArthurHoaro
374f89e721 Add print CSS rules to the default template
Fixes #1291

  * Display the header bar only on the first page
  * Hide search bars, pagination buttons, filters, and edit/delete buttons
2019-05-08 12:17:52 +02:00
ArthurHoaro
06783e8f1a
Merge pull request #1297 from ArthurHoaro/hotfix/mobile-select-all
Hide select all button on mobile view
2019-05-08 11:44:54 +02:00
ArthurHoaro
160d9a7741
Merge pull request #1296 from ArthurHoaro/feature/sticky-label
Display sticky label in linklist
2019-05-08 11:00:33 +02:00
ArthurHoaro
51c5de1105 Hide select all button on mobile view
Bulk actions are not available on mobile view yet
2019-04-22 12:39:15 +02:00
ArthurHoaro
786f35f270
Merge pull request #1276 from ArthurHoaro/feature/bulk-visibility
Bulk action: set visibility
2019-04-22 12:31:09 +02:00
ArthurHoaro
d3defcac1c Display sticky label in linklist
Add sticky label, like private label, in linklist to make it more visible.
2019-04-22 11:26:37 +02:00
Luce Carević
da815e3f2e delete useless titles 2019-03-02 13:40:21 +01:00
Luce Carević
de07aad18f fix empty links and hide <i> for screenreaders 2019-03-02 13:32:36 +01:00
Luce Carević
c31dd67c5d footer and contentinfo 2019-03-02 12:56:08 +01:00
ArthurHoaro
8d03f705eb Bulk action: set visibility
Added 2 buttons when link checkboxes are checked to set them either public or private.

Related to #572 #1160
2019-02-09 17:59:53 +01:00
ArthurHoaro
cb974e4747 Accessibility: specify the HTML lang attribute
The lang is based on the user defined one. If the language is automatic, no language will be specified.

Fixes #1216
2019-02-09 14:29:35 +01:00
VirtualTam
49106a5d8c fix: ensure HTML tags are stripped from OpenGraph description
Fixes https://github.com/shaarli/Shaarli/issues/1250
Relates to https://github.com/shaarli/Shaarli/issues/1242

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
2019-01-18 22:58:09 +01:00
Aurélien Tamisier
5e0a898bb1
Merge pull request #1247 from llune/patch-5
add label to form - accessibility issue
2018-12-02 13:56:16 +01:00
Luce Carević
0c42c5e359
add label to form - accessibility issue
Don't use placeholder instead of label for form input.
2018-11-30 20:39:13 +01:00
Luce Carević
db06c261f6
fix translation string 2018-11-30 20:36:10 +01:00
ArthurHoaro
e95247d41d
Merge pull request #1205 from ArthurHoaro/feature/opengraph
Add OpenGraph meta tags on permalink page
2018-10-06 13:31:07 +02:00
ArthurHoaro
a062416918
Merge pull request #1208 from ArthurHoaro/feature/select-all
Add a button to toggle all checkboxes of displayed links
2018-10-06 13:30:29 +02:00
ArthurHoaro
8cac122086
Merge pull request #1211 from ArthurHoaro/hotfix/img-request
Fix a bug making thumbnail to request the current page
2018-10-06 13:29:10 +02:00
ArthurHoaro
d9bf5b31ff Sticky feature - Add translation and display for logged out users 2018-10-06 13:13:57 +02:00
ArthurHoaro
4154c25b5f Add a button to set links as sticky
Meaning that they always appear on top of all links

Fixes #186
2018-10-06 12:55:05 +02:00
ArthurHoaro
8c75c43e7e Fix a bug making thumbnail to request the current page 2018-08-14 11:43:54 +02:00
ArthurHoaro
fc574e6454 Add a button to toggle all checkboxes of displayed links
Related to #1160
2018-08-13 13:13:26 +02:00
ArthurHoaro
a120fb2977 Add OpenGraph meta tags on permalink page
Includes:
  - og:title
  - og:type -> article
  - og:image -> if there is a thumbnail
  - og:url -> permalink
  - og:description -> first 300 chars of raw description
  - article:published_time
  - article:modified_time
  - article:tag -> one OG meta tag for each shaare tag

Fixes #258
2018-08-13 10:55:48 +02:00
ArthurHoaro
dccd62cbd6
Merge pull request #1195 from llune/patch-3
Delete redundant titles
2018-08-10 17:47:43 +02:00
llune
be5db0a5cf
Delete redundant titles
Redundant titles are an accessibility issue and should be avoided.

See : https://accessibilitytips.com/2008/04/14/avoiding-redundant-title-attributes/
2018-08-02 22:48:00 +02:00
llune
667963435f
alt should be empty 2018-08-02 21:23:34 +02:00
llune
a71e1aa73e
empty alt on logo image
The alt does not provide any useful information for screenreader users. It just adds noise.
2018-08-02 21:21:00 +02:00
ArthurHoaro
bf3c9934d2 Fix fatal error on daily page: use new thumbnail system
Also fix:

  * include the login manager in the daily RSS feed function
  * remove redirector setting in the vintage theme

Fixes #1190
2018-07-29 17:49:53 +02:00
ArthurHoaro
e87f57c758 Remove Firefox Social API shaare
Firefox Social support has been dropped in Firefox 57.

Related to #1023
2018-07-28 11:26:12 +02:00
ArthurHoaro
ad5f47adba
Merge pull request #687 from ArthurHoaro/web-thumb
Use web-thumbnailer to retrieve thumbnails
2018-07-28 09:41:29 +02:00
ArthurHoaro
7b4fea0e39 Bunch of improvement for thumbnails integration:
- add a default thumb size value (125x90px)
  - improve private vertical bar visual, especially with thumbnails
  - translations
  - add a sync thumbs button in tool and empty picwall page
  - fixes WT download mode in JSON config
2018-07-17 13:16:50 +02:00
nodiscc
738b1873c3 tpl: default/vintage: pluginsadmin: fix link to documentation
Ref #930
2018-07-12 22:12:55 +02:00
ArthurHoaro
b302b3c584 Thumbnails: add a common mode to only retrieve thumbs from popular media websites 2018-07-05 20:34:22 +02:00
ArthurHoaro
fcba541e2f Bump WT version 2018-07-05 20:34:22 +02:00
ArthurHoaro
28f2652460 Add a page to update all thumbnails through AJAX requests in both templates 2018-07-05 20:34:22 +02:00
ArthurHoaro
787faa42f3 Take code review into account
Upgrade web-thumbnailer and display thumbs right after download
2018-07-05 20:34:22 +02:00
ArthurHoaro
e85b7a05a1 Update thumbnail integration after rebasing the branch 2018-07-05 20:31:35 +02:00
Mark Schmitz
0deaedeeae Merge remote-tracking branch 'upstream/master' 2018-06-07 14:23:53 +01:00
Mark Schmitz
f6b3295d28 also for new default tpl add meta tag to block sending the referrer vintage -> #692 2018-06-07 14:23:41 +01:00
VirtualTam
89ccc83ba4 Login: update PageBuilder and default/vintage templates
Signed-off-by: VirtualTam <virtualtam@flibidi.net>
2018-06-02 16:46:06 +02:00
ArthurHoaro
8f816d8ddf
Merge pull request #1135 from ArthurHoaro/ci/csslint
Reformat SCSS to SASS format and run SASSLint in CI
2018-05-29 20:20:02 +02:00
ArthurHoaro
4de024d7c3 Adds Stakali Android app to 3rd party lists 2018-05-13 12:35:30 +02:00
ArthurHoaro
9d0fc86250 Add classes to default template to avoid using IDs in SCSS 2018-05-10 13:26:11 +02:00
nodiscc
5991f7a993 default/editlink.tpl: title: Shaare -> New Shaare 2018-04-14 14:15:00 +02:00
Mark Schmitz
d811e4fda6 load user css at last, after plugin css to enable changing plugin styles 2018-04-13 13:21:58 +01:00
ArthurHoaro
7e9bd977ee Webpack / Update front paths in template files 2018-03-28 19:01:17 +02:00
ArthurHoaro
b3375c7f86 Webpack / Remove frontend dependencies from tpl/ & inc/ and move them to assets/ 2018-03-28 19:01:17 +02:00
VirtualTam
44acf70681 Refactor login / ban authentication steps
Relates to https://github.com/shaarli/Shaarli/issues/324

Added:
- Add the `LoginManager` class to manage logins and bans

Changed:
- Refactor IP ban management
- Simplify logic
- Avoid using globals, inject dependencies

Fixed:
- Use `ban_duration` instead of `ban_after` when setting a new ban

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
2018-02-05 18:12:09 +01:00
ArthurHoaro
bc3ce7ec2a
Merge pull request #1038 from ArthurHoaro/feature/public-only-filter
Add a filter to only display public links
2018-02-02 19:22:37 +01:00
ArthurHoaro
d2f6d909e5 Public/private filter: use two separate buttons
#1038
2018-01-24 18:46:31 +01:00
ArthurHoaro
d799554259 Fix an issue preventing the Save button to appear for plugin parameters
is a special variable in RainTPL used in loops
2018-01-01 15:40:51 +01:00
ArthurHoaro
9d4736a3e9 Add a filter to only display public links
When the key filter is clicked once, it only displays private link. When it is clicked on again, it becomes red and only public links are displayed. Another click and all links are displayed. The current visibility status is shown in the search banner

Fixes #1030
2017-12-16 14:32:56 +01:00
ArthurHoaro
25d0cfa5a8 Add CSS class and IDs in Shaarli's menu
Fixes #877
2017-12-16 13:51:55 +01:00
ArthurHoaro
3ec25cc00f
Merge pull request #1017 from ArthurHoaro/feature/mobile-icon
Add apple-touch-icon meta tag
2017-11-18 14:01:02 +01:00
ArthurHoaro
9d245de6e6 Add apple-touch-icon meta tag
Fixes #997
2017-11-18 12:46:33 +01:00
ArthurHoaro
844be5d556
Merge pull request #1014 from ArthurHoaro/feature/no-plugin
Improve messages if there is no plugin or parameter available in the admin page
2017-11-12 11:03:40 +01:00
ArthurHoaro
ece7db113a Improve messages if there is no plugin or parameter available in the admin page
Fixes #931
2017-11-11 11:01:28 +01:00
ArthurHoaro
055ce4bd19 Fix alignement and better clarity for 'List all links with those tags' button
Fix CSS class typo and display the link as a button

Fixes #999
2017-11-08 19:21:00 +01:00
ArthurHoaro
a89f423dfa Remove redirector setting from Configure page
This feature is pretty much useless these days as browsers have builtin features to support the thag "<meta name='referrer'", so keep the setting page as clean as possible.

Also, avoid advertising it too much, because I'm pretty sure it doesn't work very well with markdown descriptions (as Parsedown have some trouble regarding URL detection (without MarkDown link tag)).
2017-11-07 20:31:55 +01:00
ArthurHoaro
94c1756562 Theme improvements: move thumbnails to the right and reduce margins overall
* Reduce multiple margins (markdown, space between block, etc.)
  * Move thumbnails to the right in the same line as the title
  * Move edit button as floating to the left
  * Move fold/collapse and checkbox buttons as floating to the right
  * Add a bunch of HTML ID in the linklist template

Relates to #877
2017-10-28 15:11:57 +02:00
ArthurHoaro
f39580c6fd Add language selection in the configure page of the default theme 2017-10-22 13:16:53 +02:00
ArthurHoaro
40ec173e68 JS translation 2017-10-22 12:56:55 +02:00
ArthurHoaro
12266213d0 Shaarli's translation
* translation system and unit tests
 * Translations everywhere

Dont use translation merge

It is not available with PHP builtin gettext, so it would have lead to inconsistency.
2017-10-22 12:55:03 +02:00
ArthurHoaro
be9ddff2fb Merge pull request #987 from ArthurHoaro/hotfix/security-issue
Fix security issue reported by @chb9
2017-10-07 11:33:20 +02:00
ArthurHoaro
d14555a3df Fix security issue reported by @chbi
Vulnerability introduced by 6ccd0b218f - release with Shaarli v0.9.1.
2017-10-07 11:27:44 +02:00
VirtualTam
c8d96b4729 Merge pull request #979 from ArthurHoaro/feature/assets-cache-version
Add a version hash for asset loading to prevent browser's cache issue
2017-10-06 14:32:07 +02:00
ArthurHoaro
9c46b347b8 Fix jumpy textarea with long content in post edit
We manually reset the scroll position, to avoid height = 'auto' jump to the top

Fixes #971
2017-10-01 11:49:17 +02:00
ArthurHoaro
bfe4f536bb Add a version hash for asset loading to prevent browser's cache issue
The hash is generated using the same salt as the one used for credentials (1 salt per instance)  in order to avoid exposing the instance version.

Fixes #965
2017-10-01 11:10:37 +02:00
nodiscc
ceb738c591 visited links color: same hue as unvisited links, darkened
Related to https://github.com/shaarli/Shaarli/issues/877
Plain grey links would lead to think that the link is somehow disabled/inaccessible/private
This slightly improves clarity/usability
2017-09-04 22:36:21 +02:00
ArthurHoaro
96a1c79456 Merge pull request #939 from ArthurHoaro/hotfix/firefox-social-title
Firefox Social title: Use document.title instead of RainTPL variable
2017-09-02 13:54:38 +02:00
ArthurHoaro
206c45bd05 Firefox Social title: Use document.title instead of RainTPL variable
Fixes #929
2017-09-02 13:50:52 +02:00
ArthurHoaro
87d019986e Merge pull request #950 from thewilli/delete-fix
fixed link deletion
2017-09-01 18:25:44 +02:00
Willi Eggeling
a74f52a8d2 fixed link deletion
When deleting links, the js of the default theme separated ids by an escaped space ('+').
There was a trailing '+' after the ids which led to the php code detecting multiple values
even for single values. In combination with the id '0' this could led to no id found at all
and a resulting php error.

this commit fixes the behavior and adds an additional error handling and trimming to the php code.
2017-08-30 12:54:58 +02:00
Willi Eggeling
2e07e77573 new setting: default value for 'remember me' checkbox
- the default state for the login page's 'remember me' checkbox can now be configured
- adapted the default and vintage theme to consider the new setting
- added documentation for the new setting
2017-08-27 16:03:37 +02:00
Willi Eggeling
958fc15fec fixed note bookmarklet
- the double quotes used in the alert() call of the note bookmarklet in the default template collided with the ones of the href tag
- replaced the double quotes with single ones (just like the link bookmarklet)
2017-08-24 10:20:32 +02:00
ArthurHoaro
da95579da7 Merge pull request #925 from ArthurHoaro/theme/remove-2nd-sort-by
Remove the 2nd green 'sort by' row in link list
2017-08-19 17:57:29 +02:00
ArthurHoaro
ebc6dc3e8d Remove the 2nd green 'sort by' row in link list
It isn't really useful and doesn't look good if there isn't enough tags
2017-08-19 17:51:06 +02:00