4bf35ba56b
Relates to #372 Modifications: - move checkUpdate() to ApplicationUtils - reduce file I/O operations during version checks - apply coding conventions - add test coverage Tools: - create a sandbox directory for tests Signed-off-by: VirtualTam <virtualtam@flibidi.net>
318 lines
8.5 KiB
PHP
318 lines
8.5 KiB
PHP
<?php
|
|
/**
|
|
* ApplicationUtils' tests
|
|
*/
|
|
|
|
require_once 'application/ApplicationUtils.php';
|
|
|
|
/**
|
|
* Fake ApplicationUtils class to avoid HTTP requests
|
|
*/
|
|
class FakeApplicationUtils extends ApplicationUtils
|
|
{
|
|
public static $VERSION_CODE = '';
|
|
|
|
/**
|
|
* Toggle HTTP requests, allow overriding the version code
|
|
*/
|
|
public static function getLatestGitVersionCode($url, $timeout=0)
|
|
{
|
|
return self::$VERSION_CODE;
|
|
}
|
|
}
|
|
|
|
|
|
/**
|
|
* Unitary tests for Shaarli utilities
|
|
*/
|
|
class ApplicationUtilsTest extends PHPUnit_Framework_TestCase
|
|
{
|
|
protected static $testUpdateFile = 'sandbox/update.txt';
|
|
protected static $testVersion = '0.5.0';
|
|
protected static $versionPattern = '/^\d+\.\d+\.\d+$/';
|
|
|
|
/**
|
|
* Reset test data for each test
|
|
*/
|
|
public function setUp()
|
|
{
|
|
FakeApplicationUtils::$VERSION_CODE = '';
|
|
if (file_exists(self::$testUpdateFile)) {
|
|
unlink(self::$testUpdateFile);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Retrieve the latest version code available on Git
|
|
*
|
|
* Expected format: Semantic Versioning - major.minor.patch
|
|
*/
|
|
public function testGetLatestGitVersionCode()
|
|
{
|
|
$testTimeout = 10;
|
|
|
|
$this->assertEquals(
|
|
'0.5.4',
|
|
ApplicationUtils::getLatestGitVersionCode(
|
|
'https://raw.githubusercontent.com/shaarli/Shaarli/'
|
|
.'v0.5.4/shaarli_version.php',
|
|
$testTimeout
|
|
)
|
|
);
|
|
$this->assertRegexp(
|
|
self::$versionPattern,
|
|
ApplicationUtils::getLatestGitVersionCode(
|
|
'https://raw.githubusercontent.com/shaarli/Shaarli/'
|
|
.'master/shaarli_version.php',
|
|
$testTimeout
|
|
)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Attempt to retrieve the latest version from an invalid URL
|
|
*/
|
|
public function testGetLatestGitVersionCodeInvalidUrl()
|
|
{
|
|
$this->assertFalse(
|
|
ApplicationUtils::getLatestGitVersionCode('htttp://null.io', 0)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Test update checks - the user is logged off
|
|
*/
|
|
public function testCheckUpdateLoggedOff()
|
|
{
|
|
$this->assertFalse(
|
|
ApplicationUtils::checkUpdate(self::$testVersion, 'null', 0, false, false)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Test update checks - the user has disabled updates
|
|
*/
|
|
public function testCheckUpdateUserDisabled()
|
|
{
|
|
$this->assertFalse(
|
|
ApplicationUtils::checkUpdate(self::$testVersion, 'null', 0, false, true)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* A newer version is available
|
|
*/
|
|
public function testCheckUpdateNewVersionNew()
|
|
{
|
|
$newVersion = '1.8.3';
|
|
FakeApplicationUtils::$VERSION_CODE = $newVersion;
|
|
|
|
$version = FakeApplicationUtils::checkUpdate(
|
|
self::$testVersion,
|
|
self::$testUpdateFile,
|
|
100,
|
|
true,
|
|
true
|
|
);
|
|
|
|
$this->assertEquals($newVersion, $version);
|
|
}
|
|
|
|
/**
|
|
* No available information about versions
|
|
*/
|
|
public function testCheckUpdateNewVersionUnavailable()
|
|
{
|
|
$version = FakeApplicationUtils::checkUpdate(
|
|
self::$testVersion,
|
|
self::$testUpdateFile,
|
|
100,
|
|
true,
|
|
true
|
|
);
|
|
|
|
$this->assertFalse($version);
|
|
}
|
|
|
|
/**
|
|
* Shaarli is up-to-date
|
|
*/
|
|
public function testCheckUpdateNewVersionUpToDate()
|
|
{
|
|
FakeApplicationUtils::$VERSION_CODE = self::$testVersion;
|
|
|
|
$version = FakeApplicationUtils::checkUpdate(
|
|
self::$testVersion,
|
|
self::$testUpdateFile,
|
|
100,
|
|
true,
|
|
true
|
|
);
|
|
|
|
$this->assertFalse($version);
|
|
}
|
|
|
|
/**
|
|
* Time-traveller's Shaarli
|
|
*/
|
|
public function testCheckUpdateNewVersionMaartiMcFly()
|
|
{
|
|
FakeApplicationUtils::$VERSION_CODE = '0.4.1';
|
|
|
|
$version = FakeApplicationUtils::checkUpdate(
|
|
self::$testVersion,
|
|
self::$testUpdateFile,
|
|
100,
|
|
true,
|
|
true
|
|
);
|
|
|
|
$this->assertFalse($version);
|
|
}
|
|
|
|
/**
|
|
* The version has been checked recently and Shaarli is up-to-date
|
|
*/
|
|
public function testCheckUpdateNewVersionTwiceUpToDate()
|
|
{
|
|
FakeApplicationUtils::$VERSION_CODE = self::$testVersion;
|
|
|
|
// Create the update file
|
|
$version = FakeApplicationUtils::checkUpdate(
|
|
self::$testVersion,
|
|
self::$testUpdateFile,
|
|
100,
|
|
true,
|
|
true
|
|
);
|
|
|
|
$this->assertFalse($version);
|
|
|
|
// Reuse the update file
|
|
$version = FakeApplicationUtils::checkUpdate(
|
|
self::$testVersion,
|
|
self::$testUpdateFile,
|
|
100,
|
|
true,
|
|
true
|
|
);
|
|
|
|
$this->assertFalse($version);
|
|
}
|
|
|
|
/**
|
|
* The version has been checked recently and Shaarli is outdated
|
|
*/
|
|
public function testCheckUpdateNewVersionTwiceOutdated()
|
|
{
|
|
$newVersion = '1.8.3';
|
|
FakeApplicationUtils::$VERSION_CODE = $newVersion;
|
|
|
|
// Create the update file
|
|
$version = FakeApplicationUtils::checkUpdate(
|
|
self::$testVersion,
|
|
self::$testUpdateFile,
|
|
100,
|
|
true,
|
|
true
|
|
);
|
|
$this->assertEquals($newVersion, $version);
|
|
|
|
// Reuse the update file
|
|
$version = FakeApplicationUtils::checkUpdate(
|
|
self::$testVersion,
|
|
self::$testUpdateFile,
|
|
100,
|
|
true,
|
|
true
|
|
);
|
|
$this->assertEquals($newVersion, $version);
|
|
}
|
|
|
|
/**
|
|
* Check supported PHP versions
|
|
*/
|
|
public function testCheckSupportedPHPVersion()
|
|
{
|
|
$minVersion = '5.3';
|
|
ApplicationUtils::checkPHPVersion($minVersion, '5.4.32');
|
|
ApplicationUtils::checkPHPVersion($minVersion, '5.5');
|
|
ApplicationUtils::checkPHPVersion($minVersion, '5.6.10');
|
|
}
|
|
|
|
/**
|
|
* Check a unsupported PHP version
|
|
* @expectedException Exception
|
|
* @expectedExceptionMessageRegExp /Your PHP version is obsolete/
|
|
*/
|
|
public function testCheckSupportedPHPVersion51()
|
|
{
|
|
ApplicationUtils::checkPHPVersion('5.3', '5.1.0');
|
|
}
|
|
|
|
/**
|
|
* Check another unsupported PHP version
|
|
* @expectedException Exception
|
|
* @expectedExceptionMessageRegExp /Your PHP version is obsolete/
|
|
*/
|
|
public function testCheckSupportedPHPVersion52()
|
|
{
|
|
ApplicationUtils::checkPHPVersion('5.3', '5.2');
|
|
}
|
|
|
|
/**
|
|
* Checks resource permissions for the current Shaarli installation
|
|
*/
|
|
public function testCheckCurrentResourcePermissions()
|
|
{
|
|
$config = array(
|
|
'CACHEDIR' => 'cache',
|
|
'CONFIG_FILE' => 'data/config.php',
|
|
'DATADIR' => 'data',
|
|
'DATASTORE' => 'data/datastore.php',
|
|
'IPBANS_FILENAME' => 'data/ipbans.php',
|
|
'LOG_FILE' => 'data/log.txt',
|
|
'PAGECACHE' => 'pagecache',
|
|
'RAINTPL_TMP' => 'tmp',
|
|
'RAINTPL_TPL' => 'tpl',
|
|
'UPDATECHECK_FILENAME' => 'data/lastupdatecheck.txt'
|
|
);
|
|
$this->assertEquals(
|
|
array(),
|
|
ApplicationUtils::checkResourcePermissions($config)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks resource permissions for a non-existent Shaarli installation
|
|
*/
|
|
public function testCheckCurrentResourcePermissionsErrors()
|
|
{
|
|
$config = array(
|
|
'CACHEDIR' => 'null/cache',
|
|
'CONFIG_FILE' => 'null/data/config.php',
|
|
'DATADIR' => 'null/data',
|
|
'DATASTORE' => 'null/data/store.php',
|
|
'IPBANS_FILENAME' => 'null/data/ipbans.php',
|
|
'LOG_FILE' => 'null/data/log.txt',
|
|
'PAGECACHE' => 'null/pagecache',
|
|
'RAINTPL_TMP' => 'null/tmp',
|
|
'RAINTPL_TPL' => 'null/tpl',
|
|
'UPDATECHECK_FILENAME' => 'null/data/lastupdatecheck.txt'
|
|
);
|
|
$this->assertEquals(
|
|
array(
|
|
'"null/tpl" directory is not readable',
|
|
'"null/cache" directory is not readable',
|
|
'"null/cache" directory is not writable',
|
|
'"null/data" directory is not readable',
|
|
'"null/data" directory is not writable',
|
|
'"null/pagecache" directory is not readable',
|
|
'"null/pagecache" directory is not writable',
|
|
'"null/tmp" directory is not readable',
|
|
'"null/tmp" directory is not writable'
|
|
),
|
|
ApplicationUtils::checkResourcePermissions($config)
|
|
);
|
|
}
|
|
}
|