63ef549749
Relates to https://github.com/shaarli/Shaarli/pull/731 Added: - require the presence of the 'Authorization' header Changed: - use the HTTP Bearer Token authorization schema See: - https://jwt.io/introduction/#how-do-json-web-tokens-work- - https://tools.ietf.org/html/rfc6750 - http://security.stackexchange.com/q/108662 Signed-off-by: VirtualTam <virtualtam@flibidi.net>
207 lines
6.9 KiB
PHP
207 lines
6.9 KiB
PHP
<?php
|
|
|
|
namespace Shaarli\Api;
|
|
|
|
use Slim\Container;
|
|
use Slim\Http\Environment;
|
|
use Slim\Http\Request;
|
|
use Slim\Http\Response;
|
|
|
|
/**
|
|
* Class ApiMiddlewareTest
|
|
*
|
|
* Test the REST API Slim Middleware.
|
|
*
|
|
* Note that we can't test a valid use case here, because the middleware
|
|
* needs to call a valid controller/action during its execution.
|
|
*
|
|
* @package Api
|
|
*/
|
|
class ApiMiddlewareTest extends \PHPUnit_Framework_TestCase
|
|
{
|
|
/**
|
|
* @var string datastore to test write operations
|
|
*/
|
|
protected static $testDatastore = 'sandbox/datastore.php';
|
|
|
|
/**
|
|
* @var \ConfigManager instance
|
|
*/
|
|
protected $conf;
|
|
|
|
/**
|
|
* @var \ReferenceLinkDB instance.
|
|
*/
|
|
protected $refDB = null;
|
|
|
|
/**
|
|
* @var Container instance.
|
|
*/
|
|
protected $container;
|
|
|
|
/**
|
|
* Before every test, instantiate a new Api with its config, plugins and links.
|
|
*/
|
|
public function setUp()
|
|
{
|
|
$this->conf = new \ConfigManager('tests/utils/config/configJson.json.php');
|
|
$this->conf->set('api.secret', 'NapoleonWasALizard');
|
|
|
|
$this->refDB = new \ReferenceLinkDB();
|
|
$this->refDB->write(self::$testDatastore);
|
|
|
|
$this->container = new Container();
|
|
$this->container['conf'] = $this->conf;
|
|
}
|
|
|
|
/**
|
|
* After every test, remove the test datastore.
|
|
*/
|
|
public function tearDown()
|
|
{
|
|
@unlink(self::$testDatastore);
|
|
}
|
|
|
|
/**
|
|
* Invoke the middleware with the API disabled:
|
|
* should return a 401 error Unauthorized.
|
|
*/
|
|
public function testInvokeMiddlewareApiDisabled()
|
|
{
|
|
$this->conf->set('api.enabled', false);
|
|
$mw = new ApiMiddleware($this->container);
|
|
$env = Environment::mock([
|
|
'REQUEST_METHOD' => 'GET',
|
|
'REQUEST_URI' => '/echo',
|
|
]);
|
|
$request = Request::createFromEnvironment($env);
|
|
$response = new Response();
|
|
/** @var Response $response */
|
|
$response = $mw($request, $response, null);
|
|
|
|
$this->assertEquals(401, $response->getStatusCode());
|
|
$body = json_decode((string) $response->getBody());
|
|
$this->assertEquals('Not authorized', $body);
|
|
}
|
|
|
|
/**
|
|
* Invoke the middleware with the API disabled in debug mode:
|
|
* should return a 401 error Unauthorized - with a specific message and a stacktrace.
|
|
*/
|
|
public function testInvokeMiddlewareApiDisabledDebug()
|
|
{
|
|
$this->conf->set('api.enabled', false);
|
|
$this->conf->set('dev.debug', true);
|
|
$mw = new ApiMiddleware($this->container);
|
|
$env = Environment::mock([
|
|
'REQUEST_METHOD' => 'GET',
|
|
'REQUEST_URI' => '/echo',
|
|
]);
|
|
$request = Request::createFromEnvironment($env);
|
|
$response = new Response();
|
|
/** @var Response $response */
|
|
$response = $mw($request, $response, null);
|
|
|
|
$this->assertEquals(401, $response->getStatusCode());
|
|
$body = json_decode((string) $response->getBody());
|
|
$this->assertEquals('Not authorized: API is disabled', $body->message);
|
|
$this->assertContains('ApiAuthorizationException', $body->stacktrace);
|
|
}
|
|
|
|
/**
|
|
* Invoke the middleware without a token (debug):
|
|
* should return a 401 error Unauthorized - with a specific message and a stacktrace.
|
|
*/
|
|
public function testInvokeMiddlewareNoTokenProvidedDebug()
|
|
{
|
|
$this->conf->set('dev.debug', true);
|
|
$mw = new ApiMiddleware($this->container);
|
|
$env = Environment::mock([
|
|
'REQUEST_METHOD' => 'GET',
|
|
'REQUEST_URI' => '/echo',
|
|
]);
|
|
$request = Request::createFromEnvironment($env);
|
|
$response = new Response();
|
|
/** @var Response $response */
|
|
$response = $mw($request, $response, null);
|
|
|
|
$this->assertEquals(401, $response->getStatusCode());
|
|
$body = json_decode((string) $response->getBody());
|
|
$this->assertEquals('Not authorized: JWT token not provided', $body->message);
|
|
$this->assertContains('ApiAuthorizationException', $body->stacktrace);
|
|
}
|
|
|
|
/**
|
|
* Invoke the middleware without a secret set in settings (debug):
|
|
* should return a 401 error Unauthorized - with a specific message and a stacktrace.
|
|
*/
|
|
public function testInvokeMiddlewareNoSecretSetDebug()
|
|
{
|
|
$this->conf->set('dev.debug', true);
|
|
$this->conf->set('api.secret', '');
|
|
$mw = new ApiMiddleware($this->container);
|
|
$env = Environment::mock([
|
|
'REQUEST_METHOD' => 'GET',
|
|
'REQUEST_URI' => '/echo',
|
|
'HTTP_AUTHORIZATION'=> 'Bearer jwt',
|
|
]);
|
|
$request = Request::createFromEnvironment($env);
|
|
$response = new Response();
|
|
/** @var Response $response */
|
|
$response = $mw($request, $response, null);
|
|
|
|
$this->assertEquals(401, $response->getStatusCode());
|
|
$body = json_decode((string) $response->getBody());
|
|
$this->assertEquals('Not authorized: Token secret must be set in Shaarli\'s administration', $body->message);
|
|
$this->assertContains('ApiAuthorizationException', $body->stacktrace);
|
|
}
|
|
|
|
/**
|
|
* Invoke the middleware with an invalid JWT token header
|
|
*/
|
|
public function testInvalidJwtAuthHeaderDebug()
|
|
{
|
|
$this->conf->set('dev.debug', true);
|
|
$mw = new ApiMiddleware($this->container);
|
|
$env = Environment::mock([
|
|
'REQUEST_METHOD' => 'GET',
|
|
'REQUEST_URI' => '/echo',
|
|
'HTTP_AUTHORIZATION'=> 'PolarBearer jwt',
|
|
]);
|
|
$request = Request::createFromEnvironment($env);
|
|
$response = new Response();
|
|
/** @var Response $response */
|
|
$response = $mw($request, $response, null);
|
|
|
|
$this->assertEquals(401, $response->getStatusCode());
|
|
$body = json_decode((string) $response->getBody());
|
|
$this->assertEquals('Not authorized: Invalid JWT header', $body->message);
|
|
$this->assertContains('ApiAuthorizationException', $body->stacktrace);
|
|
}
|
|
|
|
/**
|
|
* Invoke the middleware with an invalid JWT token (debug):
|
|
* should return a 401 error Unauthorized - with a specific message and a stacktrace.
|
|
*
|
|
* Note: specific JWT errors tests are handled in ApiUtilsTest.
|
|
*/
|
|
public function testInvokeMiddlewareInvalidJwtDebug()
|
|
{
|
|
$this->conf->set('dev.debug', true);
|
|
$mw = new ApiMiddleware($this->container);
|
|
$env = Environment::mock([
|
|
'REQUEST_METHOD' => 'GET',
|
|
'REQUEST_URI' => '/echo',
|
|
'HTTP_AUTHORIZATION'=> 'Bearer jwt',
|
|
]);
|
|
$request = Request::createFromEnvironment($env);
|
|
$response = new Response();
|
|
/** @var Response $response */
|
|
$response = $mw($request, $response, null);
|
|
|
|
$this->assertEquals(401, $response->getStatusCode());
|
|
$body = json_decode((string) $response->getBody());
|
|
$this->assertEquals('Not authorized: Malformed JWT token', $body->message);
|
|
$this->assertContains('ApiAuthorizationException', $body->stacktrace);
|
|
}
|
|
}
|