This changes creates a new form in addlink page allowing to create multiple bookmarks at once more easily. It focuses on re-using as much existing code and template component as possible. These changes includes: - a new form in addlink (hidden behind a button by default), containing a text area for URL, and tags/private status to apply to created links - this form displays a new template called editlink.batch, itself including editlink template multiple times - User interation in this new templates are handle by a new JS script (shaare-batch.js) making AJAX requests, and therefore does not need page reloading - ManageShaareController has been split into 3 distinct controllers: + ShaareAdd: displays addlink template + ShaareManage: various operation applied on existing shaares (change visibility, pin, deletion, etc.) + ShaarePublish: handles creation/edit forms and saving Shaare's form - Updated translations Fixes #137
146 lines
4.5 KiB
PHP
146 lines
4.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Shaarli\Front\Controller\Admin\ShaareManageControllerTest;
|
|
|
|
use Shaarli\Bookmark\Bookmark;
|
|
use Shaarli\Bookmark\Exception\BookmarkNotFoundException;
|
|
use Shaarli\Front\Controller\Admin\FrontAdminControllerMockHelper;
|
|
use Shaarli\Front\Controller\Admin\ShaareManageController;
|
|
use Shaarli\Http\HttpAccess;
|
|
use Shaarli\Security\SessionManager;
|
|
use Shaarli\TestCase;
|
|
use Slim\Http\Request;
|
|
use Slim\Http\Response;
|
|
|
|
class PinBookmarkTest extends TestCase
|
|
{
|
|
use FrontAdminControllerMockHelper;
|
|
|
|
/** @var ShaareManageController */
|
|
protected $controller;
|
|
|
|
public function setUp(): void
|
|
{
|
|
$this->createContainer();
|
|
|
|
$this->container->httpAccess = $this->createMock(HttpAccess::class);
|
|
$this->controller = new ShaareManageController($this->container);
|
|
}
|
|
|
|
/**
|
|
* Test pin bookmark - with valid input
|
|
*
|
|
* @dataProvider initialStickyValuesProvider()
|
|
*/
|
|
public function testPinBookmarkIsStickyNull(?bool $sticky, bool $expectedValue): void
|
|
{
|
|
$id = 123;
|
|
|
|
$request = $this->createMock(Request::class);
|
|
$response = new Response();
|
|
|
|
$bookmark = (new Bookmark())
|
|
->setId(123)
|
|
->setUrl('http://domain.tld')
|
|
->setTitle('Title 123')
|
|
->setSticky($sticky)
|
|
;
|
|
|
|
$this->container->bookmarkService->expects(static::once())->method('get')->with(123)->willReturn($bookmark);
|
|
$this->container->bookmarkService->expects(static::once())->method('set')->with($bookmark, true);
|
|
|
|
// Make sure that PluginManager hook is triggered
|
|
$this->container->pluginManager
|
|
->expects(static::once())
|
|
->method('executeHooks')
|
|
->with('save_link')
|
|
;
|
|
|
|
$result = $this->controller->pinBookmark($request, $response, ['id' => (string) $id]);
|
|
|
|
static::assertSame(302, $result->getStatusCode());
|
|
static::assertSame(['/subfolder/'], $result->getHeader('location'));
|
|
|
|
static::assertSame($expectedValue, $bookmark->isSticky());
|
|
}
|
|
|
|
public function initialStickyValuesProvider(): array
|
|
{
|
|
// [initialStickyState, isStickyAfterPin]
|
|
return [[null, true], [false, true], [true, false]];
|
|
}
|
|
|
|
/**
|
|
* Test pin bookmark - invalid bookmark ID
|
|
*/
|
|
public function testDisplayEditFormInvalidId(): void
|
|
{
|
|
$id = 'invalid';
|
|
|
|
$request = $this->createMock(Request::class);
|
|
$response = new Response();
|
|
|
|
$this->container->sessionManager
|
|
->expects(static::once())
|
|
->method('setSessionParameter')
|
|
->with(SessionManager::KEY_ERROR_MESSAGES, ['Bookmark with identifier invalid could not be found.'])
|
|
;
|
|
|
|
$result = $this->controller->pinBookmark($request, $response, ['id' => $id]);
|
|
|
|
static::assertSame(302, $result->getStatusCode());
|
|
static::assertSame(['/subfolder/'], $result->getHeader('location'));
|
|
}
|
|
|
|
/**
|
|
* Test pin bookmark - Bookmark ID not provided
|
|
*/
|
|
public function testDisplayEditFormIdNotProvided(): void
|
|
{
|
|
$request = $this->createMock(Request::class);
|
|
$response = new Response();
|
|
|
|
$this->container->sessionManager
|
|
->expects(static::once())
|
|
->method('setSessionParameter')
|
|
->with(SessionManager::KEY_ERROR_MESSAGES, ['Bookmark with identifier could not be found.'])
|
|
;
|
|
|
|
$result = $this->controller->pinBookmark($request, $response, []);
|
|
|
|
static::assertSame(302, $result->getStatusCode());
|
|
static::assertSame(['/subfolder/'], $result->getHeader('location'));
|
|
}
|
|
|
|
/**
|
|
* Test pin bookmark - bookmark not found
|
|
*/
|
|
public function testDisplayEditFormBookmarkNotFound(): void
|
|
{
|
|
$id = 123;
|
|
|
|
$request = $this->createMock(Request::class);
|
|
$response = new Response();
|
|
|
|
$this->container->bookmarkService
|
|
->expects(static::once())
|
|
->method('get')
|
|
->with($id)
|
|
->willThrowException(new BookmarkNotFoundException())
|
|
;
|
|
|
|
$this->container->sessionManager
|
|
->expects(static::once())
|
|
->method('setSessionParameter')
|
|
->with(SessionManager::KEY_ERROR_MESSAGES, ['Bookmark with identifier 123 could not be found.'])
|
|
;
|
|
|
|
$result = $this->controller->pinBookmark($request, $response, ['id' => (string) $id]);
|
|
|
|
static::assertSame(302, $result->getStatusCode());
|
|
static::assertSame(['/subfolder/'], $result->getHeader('location'));
|
|
}
|
|
}
|