From 434c12672fd739581d74358317107ce0db4917c5 Mon Sep 17 00:00:00 2001
From: logmanoriginal <logmanoriginal@users.noreply.github.com>
Date: Tue, 22 Jan 2019 18:11:52 +0100
Subject: [PATCH] lib: Ignore required attribute on lists an checkboxes

References #1014
---
 lib/BridgeCard.php         | 10 ++++++++++
 lib/ParameterValidator.php |  5 ++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/lib/BridgeCard.php b/lib/BridgeCard.php
index a3493b75..9d42cacf 100644
--- a/lib/BridgeCard.php
+++ b/lib/BridgeCard.php
@@ -207,6 +207,11 @@ This bridge is not fetching its content through a secure connection</div>';
 	 * @return string The list input field
 	 */
 	private static function getListInput($entry, $id, $name) {
+		if(isset($entry['required'])) {
+			Debug::log('The "required" attribute is not supported for lists.');
+			unset($entry['required']);
+		}
+
 		$list = '<select '
 		. self::getInputAttributes($entry)
 		. ' id="'
@@ -267,6 +272,11 @@ This bridge is not fetching its content through a secure connection</div>';
 	 * @return string The checkbox input field
 	 */
 	private static function getCheckboxInput($entry, $id, $name) {
+		if(isset($entry['required'])) {
+			Debug::log('The "required" attribute is not supported for checkboxes.');
+			unset($entry['required']);
+		}
+
 		return '<input '
 		. self::getInputAttributes($entry)
 		. ' id="'
diff --git a/lib/ParameterValidator.php b/lib/ParameterValidator.php
index 91fe7c92..11fd3adf 100644
--- a/lib/ParameterValidator.php
+++ b/lib/ParameterValidator.php
@@ -196,7 +196,10 @@ class ParameterValidator {
 				if(isset($data[$id]) && !empty($data[$id])) {
 					$queriedContexts[$context] = true;
 				} elseif(isset($properties['required'])
-				&& $properties['required'] === true) {
+				&& $properties['required'] === true
+				&& isset($properties['type'])
+				&& $properties['type'] !== 'checkbox'
+				&& $properties['type'] !== 'list') {
 					$queriedContexts[$context] = false;
 					break;
 				}