From e5a6baab967c457456679687233cdabd14158a12 Mon Sep 17 00:00:00 2001 From: triatic <42704418+triatic@users.noreply.github.com> Date: Thu, 15 Nov 2018 21:00:01 +0000 Subject: [PATCH] [TwitterBridge] Decode HTML entities (#926) Removes duplicate encoding like &quot; (should be "). --- bridges/TwitterBridge.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/bridges/TwitterBridge.php b/bridges/TwitterBridge.php index 47bc30d2..fc7b78bd 100644 --- a/bridges/TwitterBridge.php +++ b/bridges/TwitterBridge.php @@ -144,9 +144,9 @@ class TwitterBridge extends BridgeAbstract { $item = array(); // extract username and sanitize - $item['username'] = $tweet->getAttribute('data-screen-name'); + $item['username'] = htmlspecialchars_decode($tweet->getAttribute('data-screen-name'), ENT_QUOTES); // extract fullname (pseudonym) - $item['fullname'] = $tweet->getAttribute('data-name'); + $item['fullname'] = htmlspecialchars_decode($tweet->getAttribute('data-name'), ENT_QUOTES); // get author $item['author'] = $item['fullname'] . ' (@' . $item['username'] . ')'; // get avatar link @@ -158,7 +158,8 @@ class TwitterBridge extends BridgeAbstract { // extract tweet timestamp $item['timestamp'] = $tweet->find('span.js-short-timestamp', 0)->getAttribute('data-time'); // generate the title - $item['title'] = strip_tags($this->fixAnchorSpacing($tweet->find('p.js-tweet-text', 0), '')); + $item['title'] = strip_tags($this->fixAnchorSpacing(htmlspecialchars_decode( + $tweet->find('p.js-tweet-text', 0), ENT_QUOTES), '')); switch($this->queriedContext) { case 'By list': @@ -268,6 +269,7 @@ EOD; EOD; } + $item['content'] = htmlspecialchars_decode($item['content'], ENT_QUOTES); // put out $this->items[] = $item;