From ea289a0cea454109d813e8b2248b215e41321dc5 Mon Sep 17 00:00:00 2001 From: Joseph Date: Wed, 27 Jan 2021 06:06:59 +0000 Subject: [PATCH] [GithubIssueBridge] Fix issue id and comment id extraction (#1950) --- bridges/GithubIssueBridge.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/bridges/GithubIssueBridge.php b/bridges/GithubIssueBridge.php index 29a336bd..46fbc4c1 100644 --- a/bridges/GithubIssueBridge.php +++ b/bridges/GithubIssueBridge.php @@ -109,8 +109,7 @@ class GithubIssueBridge extends BridgeAbstract { } private function extractIssueComment($issueNbr, $title, $comment){ - - $uri = $this->buildGitHubIssueCommentUri($issueNbr, $comment->parent->id); + $uri = $this->buildGitHubIssueCommentUri($issueNbr, $comment->id); $author = $comment->find('.author', 0)->plaintext; @@ -171,9 +170,9 @@ class GithubIssueBridge extends BridgeAbstract { case 'Project Issues': foreach($html->find('.js-active-navigation-container .js-navigation-item') as $issue) { $info = $issue->find('.opened-by', 0); - $issueNbr = substr( - trim($info->plaintext), 1, strpos(trim($info->plaintext), ' ') - ); + + preg_match('/\/([0-9]+)$/', $issue->find('a', 0)->href, $match); + $issueNbr = $match[1]; $item = array(); $item['content'] = '';