Commit graph

1668 commits

Author SHA1 Message Date
Pierre Mazière
1b3c8a8aeb [core + bridges] add BridgeAbstract::$inputs and BridgeAbstract::getInput()
Inputs are not stored in BridgeAbstract::$parameters anymore to separate
static data from dynamic data.
The getInput method allows for more readable code.

Also fix an "undefined index 'global'" notice

Probability of breaking bridges: high !

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
a4fd7b8b98 [GooglePlusPostBridge] fix uninitialized $param
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
2047955f06 [core] rename $param to $inputs
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
d1715f6efc [core] fix missing curly brackets
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
ea46d532dc [TwitterBridge] fix getURI() and simplify code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
85625318b1 [core] variable renaming
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
ea1d53a24a [core] fix global parameter values propagatino
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
701aff420d [core] code simplification
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
de1b39c8e5 [core + bridges] get rid of loadMetadata
if a bridge needs to modify some of the data that were initialized
there, ::__construct() should be used instead.

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:05:03 +02:00
Pierre Mazière
2301a12cc6 [WordpPessBridge] implement getURI() and simplify code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
792578aefb [WikipediaBridge] remove useless code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
a24e6ea323 [WikipediaBridge] implement and use getURI() and getName()
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
0de4fce41d [WhydBridge] remove useless code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
341ce2bf3e [VkBridge] remove useless $request member
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
720b7924c5 [TwitchApiBridge] Simplify parameters and remove useless code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
7857325d9c [core] set checkboxes default value to false
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
72e3031d5c [TwitchApiBridge] remove useless code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
05001f6b2e [SoundcloudBridge] remove useless code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
292f0f85ad [ParuVenduImmoBridge] fix undefined $param variable
and remove useless member $request

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
614d425da4 [InstagramBridge] fix uri, remove useless code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
760141a751 [InstagramBridge] fix parameter 'u' requirement status
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
d95fa6117a [IdenticaBridge] remove useless code and fix getURI()
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
c061057861 [GoogleSearchBridge] remove useless checks and useless member $request
still broken though

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
2f1fa81082 [GBAtempBridge] remove useless checks and simplify code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
ed0fd12193 [DailymotionBridge] simplify code
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
0d36ca21df [CNETBridge] remove useless member $topicName
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
1de7fb748c [BandcampBridge] remove useless member $request
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
Pierre Mazière
755d3e133f [ABCTabsBridge] remove useless member $request
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-28 13:00:55 +02:00
LogMANOriginal
a8797641fd Merge pull request #369 from Frenzie/master
Fix Esperanto
2016-08-28 11:56:35 +02:00
Frans de Jonge
84c45e459e Fix Esperanto 2016-08-28 11:48:27 +02:00
LogMANOriginal
5448edcd79 Merge pull request #368 from Frenzie/master 2016-08-28 11:44:55 +02:00
Frans de Jonge
0fcde196b9 WikipediaBridge: improved title detection
* improved title detection through changed AddTodaysFeaturedArticleGeneric function call
* added Dutch Wikipedia support
2016-08-28 11:42:54 +02:00
logmanoriginal
737942ae7a Merge branch 'core' of https://framagit.org/peetah/rss-bridge 2016-08-26 19:54:42 +02:00
logmanoriginal
accbe8c06f Merge branch 'ContinuousIntegration' of https://github.com/logmanoriginal/rss-bridge 2016-08-26 19:44:41 +02:00
logmanoriginal
449b2ca520 [.travis.yml][phpcs.xml] Introduce TravisCI + PHP_CodeSniffer 2016-08-26 19:01:11 +02:00
Pierre Mazière
3f36ca2a9b [core] unexpected input generates a fail
because paranoïa is the way to security !
Should this be optional ?

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:52:44 +02:00
Pierre Mazière
2670a0e400 [core] get parameters from $_GET rather than $_REQUEST
No need to play with parameters that RSS-Bridge did not ask for

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:28:47 +02:00
Pierre Mazière
b676eca0a2 [WikipediaBridge] fix 'fullarticle' feature
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:18:47 +02:00
Pierre Mazière
5e33a27f7c [KununuBridge] fix 'fullarticle' feature
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:18:26 +02:00
Pierre Mazière
23a7edebd6 [WorldOfTanksBridge] code factorization
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:15:52 +02:00
Pierre Mazière
b6fe424ddb [Gawker] fix parameter 'site' requirement status
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:12:54 +02:00
Pierre Mazière
3a0a2a9559 [FreenewsBridge] remove unused parameter 'id'
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:12:23 +02:00
Pierre Mazière
a67a219bf9 [core] remove '$param' argument from RssExpander::collectExpandableDatas
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:11:49 +02:00
Pierre Mazière
3bad5ec45c [TwitterBridge] fix 'nopic' feature
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 17:07:37 +02:00
Pierre Mazière
af1673d1c4 [WelLiveSecurity] fix proxy bypass
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 15:40:33 +02:00
Pierre Mazière
c34fdfa7fb [TwitterBridge] fix bridge name and bridge uri
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 01:49:30 +02:00
Pierre Mazière
117031bf0f [core] store parameters values in BridgeAbstract::parameters
This way, any BridgeAbstract method can now have access to these values,
no only collectData

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 01:24:53 +02:00
Pierre Mazière
dea37c8e34 [core] use BridgeAbstract::parameters to sanitize inputs
This should result in a lot of simplifications in the bridges
since data validation is now done upstream.

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 01:20:12 +02:00
Pierre Mazière
1bb94aecc6 [core] leave $_REQUEST alone
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 01:07:49 +02:00
Pierre Mazière
70a8b88b6f [IdenticaBridge] fix parameter 'u' requirement status
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
2016-08-25 00:47:52 +02:00