Commit graph

1883 commits

Author SHA1 Message Date
logmanoriginal
72f40fbd75 [formats] Allow multiple enclosures
All formats now support multiple enclosures. RSS
will show a warning if more than one enclosure
is used since many feed reader don't support
multiple enclosures with RSS (also not clearly
specified in the specification)
2016-11-12 22:04:42 +01:00
logmanoriginal
14c689e7a3 [core] Fix typos 2016-11-09 19:10:40 +01:00
logmanoriginal
84bc9d2da6 Merge branch 'ImproveFormat' of https://github.com/logmanoriginal/rss-bridge 2016-11-09 19:01:17 +01:00
logmanoriginal
42cbc2e889 [formats] Fix enclosures
All bridges failed due to missing 'enclosures' element in
the items array. With this commit all formats (ATOM, RSS
and HTML) provide support for a single 'enclosure' element
2016-11-09 18:59:17 +01:00
logmanoriginal
3a2cb9ea1e [formats] Use custom characterset in all formats
The specified characterset will now apply to all formats
thus allowing other charactersets than 'UTF-8'
2016-11-09 18:43:06 +01:00
logmanoriginal
4f4fb11789 [FormatAbstract] Allow child classes to overwrite DEFAULT_CHARSET
By using 'static' instead of 'self' the constant may
be overridden by child classes.
2016-11-09 18:41:25 +01:00
logmanoriginal
28e813620f [FormatInterface] Add missing public functions
This commit adds all missing functions to the interface
that are defined and implemented as public functions in
FormatAbstract.
2016-11-09 18:41:24 +01:00
LogMANOriginal
fdf98041e3 Merge pull request #428 from mro/feature/xml_escape
CDATA considered harmful.
2016-11-09 18:35:52 +01:00
LogMANOriginal
29e64f77aa Merge pull request #430 from sysadminstory/master
Fix Cache write verification
2016-11-09 18:26:54 +01:00
Gilles Maurer
4dfbc16a5b Fix Cache write verification
PHP operator '===' is the only strict way to mix up the value '0' and
the value 'FALSE'.

The function saveData of the FileCache tests if the write of the cache
files was done with success and raise an Exception if not. The test was
done without the '===' operator, and if the data is 0 bytes long the
error message says there is a permission error, which is false.

A data 0 bytes long is another issue, either in the json_encode function
either in the Bridge, but not a permission issue.
2016-11-09 02:11:22 +01:00
Marcus Rohrmoser
af572341b3 Fix to PR #427 (#429)
* Ouch, sorry.

* fix indentation.
2016-11-08 21:44:54 +00:00
Teromene
51e9298a2b Merge pull request #427 from mro/feature/enclosure
Revive enclosures.
2016-11-08 21:24:44 +00:00
Marcus Rohrmoser
6df657179f CDATA considered harmful.
https://evertpot.com/184/
2016-11-08 22:21:48 +01:00
Marcus Rohrmoser
2ff422d312 Revive enclosures.Reverts 0663c95. Refs #198 #175. 2016-11-08 22:03:51 +01:00
Teromene
1b3efce64d Merge pull request #426 from mro/language
don’t lie about the language.
2016-11-08 00:33:17 +00:00
Marcus Rohrmoser
750812c512 don’t lie about the language. 2016-11-07 23:29:44 +01:00
LogMANOriginal
71fc854663 Update README.md 2016-11-06 14:03:28 +01:00
logmanoriginal
120612424c [CHANGELOG] Update changelog 2016-11-06 14:00:10 +01:00
LogMANOriginal
33ecaa0b7b Merge pull request #425 from mro/readme
PHP settings
2016-11-06 13:12:44 +01:00
Marcus Rohrmoser
7ce57aefbe PHP settings 2016-11-05 21:33:31 +01:00
logmanoriginal
72981032e4 [Arte7] Fix broken feed 2016-11-05 18:24:04 +01:00
logmanoriginal
d06006d681 Merge branch 'VersionChecks' of https://github.com/logmanoriginal/rss-bridge 2016-11-05 13:11:31 +01:00
logmanoriginal
d39c1ed63a [index] Add check for 'allow_url_fopen' 2016-11-05 13:09:20 +01:00
logmanoriginal
04a195361a [index] Add check for 'libxml' extension 2016-11-05 13:05:28 +01:00
logmanoriginal
3bcd98404b [index] Add check for correct PHP version 2016-11-05 13:02:48 +01:00
logmanoriginal
8924722b93 [Arte7] Fix content parsing
Elements are now put into separate JSON containers. As such
assignment changed from : to = and as only one container
is present in each element, the final , is omitted.
JSON data is html encoded and requires decoding before decoding
via json_decode.
2016-11-05 12:48:58 +01:00
logmanoriginal
5790ebc6ba [index] Initialize variable before using it 2016-10-20 22:12:54 +02:00
LogMANOriginal
38f197fb60 Update README.md 2016-10-20 22:11:04 +02:00
LogMANOriginal
6a6ccee3cd Merge pull request #422 from JeremyRand/duckduckgo-not-by-date
[DuckDuckGoBridge] Add ability to sort by relevance instead of date.
2016-10-20 22:09:30 +02:00
logmanoriginal
85149add61 [index] Fixes a bug where requests could result in same cache file names
Previously the cache file name was only build upon bridge
parameters. If two bridges don't make use of any parameter
this would result into equal file names.
2016-10-20 22:03:23 +02:00
JeremyRand
5258551a98
[DuckDuckGoBridge] Add ability to sort by relevance instead of date. 2016-10-18 22:40:34 +00:00
logmanoriginal
6c4d28c849 Merge branch 'FeedExpander' of https://github.com/logmanoriginal/rss-bridge 2016-10-16 13:09:32 +02:00
logmanoriginal
49281a2ed3 [FeedExpander] Remove orphan getDescription function 2016-10-16 12:47:37 +02:00
logmanoriginal
ffb584f7de Merge branch 'ImproveCaching' of https://github.com/logmanoriginal/rss-bridge 2016-10-16 11:17:12 +02:00
logmanoriginal
82ed2c5ffb [FileCache] Change output format to JSON
JSON format does not serialize object instances, which we don't
want anyways, and improves readability. The hashing algorithm
changed to md5 to prevent collisions with existing cache files
2016-10-16 11:15:11 +02:00
logmanoriginal
46ce0f85d7 Merge branch 'ImproveCaching' of https://github.com/logmanoriginal/rss-bridge 2016-10-08 16:36:19 +02:00
logmanoriginal
b6feda2377 [contents] Use FileCache for getSimpleHTMLDOMCached 2016-10-08 16:30:01 +02:00
logmanoriginal
8fb4db8914 [index] Introduce CACHE_DIR 2016-10-08 16:21:00 +02:00
logmanoriginal
5c309e93dc [cache] Specify cache duration for 'purgeCache' 2016-10-08 16:18:10 +02:00
logmanoriginal
2d56b717cf [FileCache] Add property to define cache folder 2016-10-08 16:03:08 +02:00
logmanoriginal
5639b158e7 [FileCache] Change parameters to lower-case
This prevents creating multiple cache files for the same request.
2016-10-08 15:34:19 +02:00
logmanoriginal
5de4a59d41 [index] Initialize cache before loading to bridge
Previously BridgeAbstract needed to know which exact implementation
of CacheInterface was used (since we only got one right now its
not a problem). Initializing the cache in index.php instead allows
to change cache types more easily.
2016-10-08 15:29:21 +02:00
logmanoriginal
d941fa41f6 [FileCache] Remove 'isPrepareCache'
There is no need to check the absense of the parameters in
all functions. Instead 'getCacheName' is the only function
actually using the parameters and thus should check the
availability.
2016-10-08 15:21:10 +02:00
logmanoriginal
ac0a9a90ad [FileCache] Build file name solely on given parameters
Previously the cache file name was build on the original request URI
which also included the parameters. This could result in different
file name for the same request (different format). Removing the format
from the request is already done in index.php and could lead to issues
in the future (if new parameters are introduced).
2016-10-08 15:17:08 +02:00
logmanoriginal
5ccde61a19 [FileCache] Rename 'prepare' to 'setParameters'
This is a cosmetic change to use the same naming convention for
all methods.
2016-10-08 15:04:14 +02:00
logmanoriginal
0998cbde9d [cache] Directly implement CacheInterface in FileCache
The function 'prepare' previously implemented in CacheAbstract
is specifically required for FileCache and thus belongs to FileCache.
Since this change removes all code from CacheAbstract, it can be
removed completely.
2016-10-08 14:52:03 +02:00
logmanoriginal
5f1c4e1c55 [FileCache] Implement recursive directory creation 2016-10-07 23:20:32 +02:00
logmanoriginal
ad825aa88a [FileCache] Assign same permission to group as others
It makes no sense for the group to get less access rights
than anyone else
2016-10-07 23:16:33 +02:00
logmanoriginal
45890d5969 [FileCache] Don't store folder creation status
The results of the function is_dir are already cached.
See http://php.net/manual/en/function.is-dir.php
2016-10-07 22:56:10 +02:00
logmanoriginal
5fdb3b2fd9 [FileCache] Build path using function instead of constant 2016-10-07 22:36:36 +02:00